mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] configure.ac: change regex for sed version
@ 2013-01-07 22:36 Alexander Aring
  2013-01-08  8:47 ` Marc Kleine-Budde
  2013-01-08  8:48 ` Marc Kleine-Budde
  0 siblings, 2 replies; 4+ messages in thread
From: Alexander Aring @ 2013-01-07 22:36 UTC (permalink / raw)
  To: ptxdist; +Cc: Alexander Aring

Change regex for sed version in configure.ac.

This regex will match only on the first line and doesn't
look for a 'version' pattern which is not available in
sed version 4.2.2.

The new regex will match in the first line of 'sed --version' in a pattern
which starts with random character sequence(or zero) followed by whitespace
character and several digits of pattern x.x....x which x is a number.
This pattern will be save in the SED_VERSION variable.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d4c83b8..4d27a60 100644
--- a/configure.ac
+++ b/configure.ac
@@ -116,7 +116,7 @@ if test -z "$SED"; then
 fi
 
 AC_MSG_CHECKING([sed version])
-SED_VERSION=`$SED --version 2>/dev/null | $SED -ne "s/.*version \([[0-9\.]]*\)/\1/p"`
+SED_VERSION=`$SED --version 2>/dev/null | $SED -ne "1 s/.*\s\([[0-9\+\.]]\+\).*/\1/p"`
 case "$SED_VERSION" in
 3.*) AC_MSG_ERROR([we need at least GNU sed 4.x but found $SED_VERSION]) ;;
 4.*) ;;
-- 
1.8.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] configure.ac: change regex for sed version
  2013-01-07 22:36 [ptxdist] [PATCH] configure.ac: change regex for sed version Alexander Aring
@ 2013-01-08  8:47 ` Marc Kleine-Budde
  2013-01-08  8:48 ` Marc Kleine-Budde
  1 sibling, 0 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2013-01-08  8:47 UTC (permalink / raw)
  To: ptxdist; +Cc: Alexander Aring, Alexander Aring


[-- Attachment #1.1: Type: text/plain, Size: 916 bytes --]

On 01/07/2013 11:36 PM, Alexander Aring wrote:
> Change regex for sed version in configure.ac.
> 
> This regex will match only on the first line and doesn't
> look for a 'version' pattern which is not available in
> sed version 4.2.2.
> 
> The new regex will match in the first line of 'sed --version' in a pattern
> which starts with random character sequence(or zero) followed by whitespace
> character and several digits of pattern x.x....x which x is a number.
> This pattern will be save in the SED_VERSION variable.
> 
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>

Works here. Tnx, applied to master.
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] configure.ac: change regex for sed version
  2013-01-07 22:36 [ptxdist] [PATCH] configure.ac: change regex for sed version Alexander Aring
  2013-01-08  8:47 ` Marc Kleine-Budde
@ 2013-01-08  8:48 ` Marc Kleine-Budde
  2013-01-08 10:50   ` Alexander Aring
  1 sibling, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2013-01-08  8:48 UTC (permalink / raw)
  To: ptxdist; +Cc: Alexander Aring, Alexander Aring


[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]

On 01/07/2013 11:36 PM, Alexander Aring wrote:
> Change regex for sed version in configure.ac.
> 
> This regex will match only on the first line and doesn't
> look for a 'version' pattern which is not available in
> sed version 4.2.2.
> 
> The new regex will match in the first line of 'sed --version' in a pattern
> which starts with random character sequence(or zero) followed by whitespace
> character and several digits of pattern x.x....x which x is a number.
> This pattern will be save in the SED_VERSION variable.
> 
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>

Which email address do you prefer?
gmail or googlemail?

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] configure.ac: change regex for sed version
  2013-01-08  8:48 ` Marc Kleine-Budde
@ 2013-01-08 10:50   ` Alexander Aring
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Aring @ 2013-01-08 10:50 UTC (permalink / raw)
  To: Marc Kleine-Budde; +Cc: Alexander Aring, ptxdist


[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]

Hallo,

I change it to gmail.
Thanks

Regards
Alexander Aring

2013/1/8 Marc Kleine-Budde <mkl@pengutronix.de>

> On 01/07/2013 11:36 PM, Alexander Aring wrote:
> > Change regex for sed version in configure.ac.
> >
> > This regex will match only on the first line and doesn't
> > look for a 'version' pattern which is not available in
> > sed version 4.2.2.
> >
> > The new regex will match in the first line of 'sed --version' in a
> pattern
> > which starts with random character sequence(or zero) followed by
> whitespace
> > character and several digits of pattern x.x....x which x is a number.
> > This pattern will be save in the SED_VERSION variable.
> >
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
>
> Which email address do you prefer?
> gmail or googlemail?
>

>
 Marc
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
>
>

[-- Attachment #1.2: Type: text/html, Size: 2217 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-01-08 10:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-07 22:36 [ptxdist] [PATCH] configure.ac: change regex for sed version Alexander Aring
2013-01-08  8:47 ` Marc Kleine-Budde
2013-01-08  8:48 ` Marc Kleine-Budde
2013-01-08 10:50   ` Alexander Aring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox