From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: MIME-Version: 1.0 References: <20191112095115.v3ya4sdcibxvpojr@pengutronix.de> <20191112115103.9265-1-guille.rodriguez@gmail.com> <20191113093624.wqssgtvjmhueu3ei@pengutronix.de> <20191114095605.hhfgwkogkoc3xyfj@pengutronix.de> <20191114111851.le2iduanpxr2abke@pengutronix.de> <20191114133129.purhfumplzkmpgwd@pengutronix.de> In-Reply-To: <20191114133129.purhfumplzkmpgwd@pengutronix.de> From: Guillermo Rodriguez Garcia Date: Thu, 14 Nov 2019 19:50:15 +0100 Message-ID: Subject: Re: [ptxdist] [PATCH v3] python3-numpy: New package List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1412468244==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Roland Hieber Cc: ptxdist@pengutronix.de --===============1412468244== Content-Type: multipart/alternative; boundary="0000000000009db2da059752f40a" --0000000000009db2da059752f40a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El jue., 14 nov. 2019 a las 14:31, Roland Hieber () escribi=C3=B3: > On Thu, Nov 14, 2019 at 12:40:43PM +0100, Guillermo Rodriguez Garcia wrot= e: > > El jue., 14 nov. 2019 a las 12:18, Roland Hieber () > > escribi=C3=B3: > > > > > On Thu, Nov 14, 2019 at 11:07:16AM +0100, Guillermo Rodriguez Garcia > wrote: > > > > El jue., 14 nov. 2019 a las 10:56, Roland Hieber (< > rhi@pengutronix.de>) > > > > escribi=C3=B3: > > > > > > > > > > > numpy/core/src/multiarray/dragon4.c seems to be a license fou= nd > > > nowhere > > > > > > > else, so I would also add "AND UNKNOWN" to > PYTHON3_NUMPY_LICENSE > > > and > > > > > add > > > > > > > its verbatim license text with startline and endline > parameters in > > > > > > > PYTHON3_NUMPY_LICENSE_FILES. PTXdist extracts all those licen= se > > > > > > > texts mentioned in that variable and adds them to the license > > > report, > > > > > > > so it doesn't get lost too :) > > > > > > > > > > > > > On re-reading this: The license in dragon4.c is just MIT. So while > it is > > > OK > > > > to add it to LICENSE_FILES I think we should not add the "AND > unknown" > > > bit. > > > > > > Oh. I just blindly believed LICENSE.txt. But now that you say it, my > > > license matcher identifies it as "Zlib", not as "MIT". > > > > > > > Uhm, doesn't look like Zlib to me; here's the license text extracted fr= om > > dragon4.c: > > > > /* > > * Copyright (c) 2014 Ryan Juckett > > * > > * Permission is hereby granted, free of charge, to any person obtainin= g > a > > copy > > * of this software and associated documentation files (the "Software")= , > to > > * deal in the Software without restriction, including without limitati= on > > the > > * rights to use, copy, modify, merge, publish, distribute, sublicense, > > and/or > > * sell copies of the Software, and to permit persons to whom the > Software > > is > > * furnished to do so, subject to the following conditions: > > * > > * The above copyright notice and this permission notice shall be > included > > in > > * all copies or substantial portions of the Software. > > * > > * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > EXPRESS > > OR > > * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > MERCHANTABILITY, > > * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT > SHALL > > THE > > * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTH= ER > > * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > ARISING > > * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > > DEALINGS > > * IN THE SOFTWARE. > > */ > > > > And here are the MIT and Zlib licenses: > > > > https://spdx.org/licenses/MIT.html > > https://spdx.org/licenses/Zlib.html > > > > I would say that the license is indeed MIT, which is what LICENSE.txt > says: > > > > Name: dragon4 > > Files: numpy/core/src/multiarray/dragon4.c > > License: MIT > > For license text, see numpy/core/src/multiarray/dragon4.c > > We're looking at different versions of the code. Your make file > specifies 1.16.1, and indeed that license was changed in commit > 2babaaa12 ("LICENSE: update dragon4 license to MIT.") [1], which landed > in numpy 1.17.4. The _LICENSE vars should describe the version in the > make file. > Ops. You are right. I didn't realize the license had changed so I mixed things up. > > Do you want to send a version-bump to the new version > instead? ;-) > The reason why I did not do that is that 1.17.x releases break cross-compilation. I reported this (https://github.com/numpy/numpy/issues/14861) a few days ago and it has been fixed since then. So I guess yes, the best is to upgrade to 1.17.4 (will need to include a patch for the issue linked above, since the fix has not made it to any public release yet) Thank you, Guillermo > > [1]: > https://github.com/numpy/numpy/commit/2babaaa123c64c9f8d47d5b8b05942ab2c7= 9a4e3 > > - Roland > > > -- > Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > --=20 Guillermo Rodriguez Garcia guille.rodriguez@gmail.com --0000000000009db2da059752f40a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
El jue., 14 nov. 2019 a = las 14:31, Roland Hieber (<rhi@pen= gutronix.de>) escribi=C3=B3:
On Thu, Nov 14, 2019 at 12:4= 0:43PM +0100, Guillermo Rodriguez Garcia wrote:
> El jue., 14 nov. 2019 a las 12:18, Roland Hieber (<rhi@pengutronix.de>)
> escribi=C3=B3:
>
> > On Thu, Nov 14, 2019 at 11:07:16AM +0100, Guillermo Rodriguez Gar= cia wrote:
> > > El jue., 14 nov. 2019 a las 10:56, Roland Hieber (<rhi@pengutronix.de>= ;)
> > > escribi=C3=B3:
> > >
> > > > > > numpy/core/src/multiarray/dragon4.c seems to = be a license found
> > nowhere
> > > > > > else, so I would also add "AND UNKNOWN&q= uot; to PYTHON3_NUMPY_LICENSE
> > and
> > > > add
> > > > > > its verbatim license text with startline and = endline parameters in
> > > > > > PYTHON3_NUMPY_LICENSE_FILES. PTXdist extracts= all those license
> > > > > > texts mentioned in that variable and adds the= m to the license
> > report,
> > > > > > so it doesn't get lost too :)
> > > >
> > >
> > > On re-reading this: The license in dragon4.c is just MIT. So= while it is
> > OK
> > > to add it to LICENSE_FILES I think we should not add the &qu= ot;AND unknown"
> > bit.
> >
> > Oh. I just blindly believed LICENSE.txt. But now that you say it,= my
> > license matcher identifies it as "Zlib", not as "M= IT".
> >
>
> Uhm, doesn't look like Zlib to me; here's the license text ext= racted from
> dragon4.c:
>
> /*
>=C2=A0 * Copyright (c) 2014 Ryan Juckett
>=C2=A0 *
>=C2=A0 * Permission is hereby granted, free of charge, to any person ob= taining a
> copy
>=C2=A0 * of this software and associated documentation files (the "= ;Software"), to
>=C2=A0 * deal in the Software without restriction, including without li= mitation
> the
>=C2=A0 * rights to use, copy, modify, merge, publish, distribute, subli= cense,
> and/or
>=C2=A0 * sell copies of the Software, and to permit persons to whom the= Software
> is
>=C2=A0 * furnished to do so, subject to the following conditions:
>=C2=A0 *
>=C2=A0 * The above copyright notice and this permission notice shall be= included
> in
>=C2=A0 * all copies or substantial portions of the Software.
>=C2=A0 *
>=C2=A0 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY O= F ANY KIND, EXPRESS
> OR
>=C2=A0 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHA= NTABILITY,
>=C2=A0 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EV= ENT SHALL
> THE
>=C2=A0 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES = OR OTHER
>=C2=A0 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE= , ARISING
>=C2=A0 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR = OTHER
> DEALINGS
>=C2=A0 * IN THE SOFTWARE.
>=C2=A0 */
>
> And here are the MIT and Zlib licenses:
>
> https://spdx.org/licenses/MIT.html
> https://spdx.org/licenses/Zlib.html
>
> I would say that the license is indeed MIT, which is what LICENSE.txt = says:
>
> Name: dragon4
> Files: numpy/core/src/multiarray/dragon4.c
> License: MIT
>=C2=A0 =C2=A0For license text, see numpy/core/src/multiarray/dragon4.c<= br>
We're looking at different versions of the code. Your make file
specifies 1.16.1, and indeed that license was changed in commit
2babaaa12 ("LICENSE: update dragon4 license to MIT.") [1], which = landed
in numpy 1.17.4. The _LICENSE vars should describe the version in the
make file.

Ops. You are right. I didn&#= 39;t realize the license had changed so I mixed things up.
=C2=A0=

Do you want to send a version-bump to the new version
instead? ;-)

The reason why I did not = do that is that 1.17.x releases break cross-compilation.
I report= ed this (https://gi= thub.com/numpy/numpy/issues/14861) a few days ago and it has been fixed= since then.

So I guess yes, the best is to upgrade to 1.17.4= (will need to include a patch for the issue linked above, since the fix ha= s not made it to any public release yet)

Thank you= ,

Guillermo
=C2=A0

[1]: https://github.co= m/numpy/numpy/commit/2babaaa123c64c9f8d47d5b8b05942ab2c79a4e3

=C2=A0 - Roland


--
Roland Hieber, Pengutronix e.K.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | r.hieber@pengutronix.= de=C2=A0 =C2=A0 =C2=A0|
Steuerwalder Str. 21=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0| https://www.pengutronix.de/ |
31137 Hildesheim, Germany=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | Phone: +49-5121-206917-0=C2=A0 =C2=A0 |
Amtsgericht Hildesheim, HRA 2686=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| Fax:=C2= =A0 =C2=A0+49-5121-206917-5555 |


--
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com
--0000000000009db2da059752f40a-- --===============1412468244== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de --===============1412468244==--