From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] classpath: Fix for building with OpenJDK-1.8 (again)
Date: Mon, 19 Nov 2018 10:30:06 +0100 [thread overview]
Message-ID: <CABDcavbmzDf76uTDVqdtE-Yn=hRf98fMpUeqjc4joWWa6zfh8A@mail.gmail.com> (raw)
In-Reply-To: <20181117134947.3xdtw7vfmq7365zd@pengutronix.de>
El sáb., 17 nov. 2018 a las 14:50, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> On Sat, Nov 17, 2018 at 01:33:19AM +0100, Guillermo Rodriguez Garcia wrote:
> > El viernes, 16 de noviembre de 2018, Michael Olbrich <
> > m.olbrich@pengutronix.de> escribió:
> >
> > > On Fri, Nov 16, 2018 at 12:20:18PM +0100, Guillermo Rodríguez wrote:
> > > > Commit bbc978e623cafc added a patch intended to fix building
> > > > with OpenJDK 1.8, however that commit was not complete. It is
> > > > necessary to run autogen.sh so that the configure script is
> > > > regenerated and the patched m4 macros are used.
> > > >
> > > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > >
> > > Unfortunately it's not that simple. The */Makefile.am also need the
> > > 1.5 -> 1.6 change. I tried that an then I get lots of errors like this:
> > >
> > > warning: as of release 9, '_' is a keyword, and may not be used as an
> > > identifier
> >
> >
> > Uhm, those are not errors, they are warnings (as long as we specify -target
> > < 9, which is the case here). Anyway from these messages it looks like you
> > are building with OpenJDK9? That is not supposed to work; the intent of the
> > patch was to allow building with OpenJDK8... can you check the version of
> > javac?
>
> Right, I missed the errors because of all those warnings:
> [...]/classpath-0.99/java/util/regex/Matcher.java:623: error: unmappable character (0xC2) for encoding US-ASCII
> *??@since 1.5
> ^
>
> There is some white-space there that does not match the selected encoding,
> I think. If I replace this with a space, then building the package
> succeeds.
> So please add the Makefile.am changes to the first patch and create another
> to fix this whitespace.
Please let me have a look at this.
However, can you confirm which javac are you using? I believe javac
from OpenJDK 1.8 should not require any of this.
Best,
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-11-19 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 11:20 Guillermo Rodríguez
2018-11-16 17:01 ` Michael Olbrich
2018-11-17 0:33 ` Guillermo Rodriguez Garcia
2018-11-17 13:49 ` Michael Olbrich
2018-11-19 9:30 ` Guillermo Rodriguez Garcia [this message]
2018-11-22 5:57 ` Michael Olbrich
2018-11-20 15:51 ` [ptxdist] [PATCH v2 1/2] " Guillermo Rodríguez
2018-11-20 15:51 ` [ptxdist] [PATCH v2 2/2] classpath: Fix building when default locale is not UTF-8 Guillermo Rodríguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABDcavbmzDf76uTDVqdtE-Yn=hRf98fMpUeqjc4joWWa6zfh8A@mail.gmail.com' \
--to=guille.rodriguez@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox