mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] classpath: Fix JAVA autoconf variable
@ 2014-05-19 10:30 Guillermo Rodriguez Garcia
  2014-06-02  7:54 ` Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Guillermo Rodriguez Garcia @ 2014-05-19 10:30 UTC (permalink / raw)
  To: ptxdist

JAVA must point to the java binary on the target, not on the host
This is used in the shell scripts in tools/*, which are installed on the target

Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
---
 rules/classpath.make |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/rules/classpath.make b/rules/classpath.make
index ad3b7e7..c5aa02f 100644
--- a/rules/classpath.make
+++ b/rules/classpath.make
@@ -32,10 +32,14 @@ CLASSPATH_PATH := PATH=$(CROSS_PATH)
 CLASSPATH_ENV := \
  $(CROSS_ENV) \
  JAVAC=$(PTXCONF_SETUP_JAVA_SDK)/bin/javac \
- JAVA=$(PTXCONF_SETUP_JAVA_SDK)/bin/java \
+ JAVA=jamvm \
  CLASSPATH=$(PTXCONF_SETUP_JAVA_SDK)/jre/lib \
+ ac_cv_prog_java_works=yes \
  ac_cv_prog_javac_is_gcj=no

+# JAVA must point to the java binary on the target, not on the host
+# This is used by the scripts in tools/*
+
 #
 # autoconf
 #
-- 
1.7.0.4

-- 
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [PATCH] classpath: Fix JAVA autoconf variable
  2014-05-19 10:30 [ptxdist] [PATCH] classpath: Fix JAVA autoconf variable Guillermo Rodriguez Garcia
@ 2014-06-02  7:54 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2014-06-02  7:54 UTC (permalink / raw)
  To: ptxdist

Same tabs/spaces issue here.

On Mon, May 19, 2014 at 12:30:14PM +0200, Guillermo Rodriguez Garcia wrote:
> JAVA must point to the java binary on the target, not on the host
> This is used in the shell scripts in tools/*, which are installed on the target
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  rules/classpath.make |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/rules/classpath.make b/rules/classpath.make
> index ad3b7e7..c5aa02f 100644
> --- a/rules/classpath.make
> +++ b/rules/classpath.make
> @@ -32,10 +32,14 @@ CLASSPATH_PATH := PATH=$(CROSS_PATH)
>  CLASSPATH_ENV := \
>   $(CROSS_ENV) \
>   JAVAC=$(PTXCONF_SETUP_JAVA_SDK)/bin/javac \
> - JAVA=$(PTXCONF_SETUP_JAVA_SDK)/bin/java \
> + JAVA=jamvm \

So '$(JAVA)' is never used at build-time, There is only a check for its
existence, right?

>   CLASSPATH=$(PTXCONF_SETUP_JAVA_SDK)/jre/lib \
> + ac_cv_prog_java_works=yes \

... and we overwrite that here.

Looks good I think. Please resend with correct whitespaces.

Michael

>   ac_cv_prog_javac_is_gcj=no
> 
> +# JAVA must point to the java binary on the target, not on the host
> +# This is used by the scripts in tools/*
> +
>  #
>  # autoconf
>  #
> -- 
> 1.7.0.4
> 
> -- 
> Guillermo Rodriguez Garcia
> guille.rodriguez@gmail.com
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-02  7:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-19 10:30 [ptxdist] [PATCH] classpath: Fix JAVA autoconf variable Guillermo Rodriguez Garcia
2014-06-02  7:54 ` Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox