Hi Roland,

El mié., 13 nov. 2019 a las 10:36, Roland Hieber (<rhi@pengutronix.de>)
escribió:

> On Tue, Nov 12, 2019 at 12:51:03PM +0100, Guillermo Rodríguez wrote:
> > NumPy is the fundamental package for scientific computing with Python.
> >
> > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > ---
> > v2: Switch to PyPi URL; this removes the dependency on Cython.
> > v3: Update LICENSE, add LICENSE_FILES
> >
> >  rules/python3-numpy.in   | 10 ++++++++
> >  rules/python3-numpy.make | 54 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 64 insertions(+)
> >  create mode 100644 rules/python3-numpy.in
> >  create mode 100644 rules/python3-numpy.make
> >
> > diff --git a/rules/python3-numpy.in b/rules/python3-numpy.in
> > new file mode 100644
> > index 000000000..1440e409a
> > --- /dev/null
> > +++ b/rules/python3-numpy.in
> > @@ -0,0 +1,10 @@
> > +## SECTION=python3
> > +
> > +config PYTHON3_NUMPY
> > +     tristate
> > +     select PYTHON3
> > +     select HOST_PYTHON3_SETUPTOOLS
> > +     prompt "python3-numpy"
> > +     help
> > +       NumPy is the fundamental package for scientific computing with
> > +       Python.
> > diff --git a/rules/python3-numpy.make b/rules/python3-numpy.make
> > new file mode 100644
> > index 000000000..40cc351d3
> > --- /dev/null
> > +++ b/rules/python3-numpy.make
> > @@ -0,0 +1,54 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2019 by Guillermo Rodriguez <guille.rodriguez@gmail.com
> >
> > +#
> > +# For further information about the PTXdist project and license
> conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_PYTHON3_NUMPY) += python3-numpy
> > +
> > +#
> > +# Paths and names
> > +#
> > +PYTHON3_NUMPY_VERSION        := 1.16.1
> > +PYTHON3_NUMPY_MD5    := dafda51934f645d888866f98424521ae
> > +PYTHON3_NUMPY                := numpy-$(PYTHON3_NUMPY_VERSION)
> > +PYTHON3_NUMPY_SUFFIX := zip
> > +PYTHON3_NUMPY_URL    :=
> https://pypi.python.org/packages/source/n/numpy/$(PYTHON3_NUMPY).$(PYTHON3_NUMPY_SUFFIX)
> > +PYTHON3_NUMPY_SOURCE :=
> $(SRCDIR)/$(PYTHON3_NUMPY).$(PYTHON3_NUMPY_SUFFIX)
> > +PYTHON3_NUMPY_DIR    := $(BUILDDIR)/$(PYTHON3_NUMPY)
> > +PYTHON3_NUMPY_LICENSE        := BSD AND BSD-3-Clause AND MIT
>
> AND Apache-2.0, according to LICENSE.txt.


I assume you mean LICENSES_bundled.txt and not LICENSE.txt

If I am reading that correctly, the Apache license only applies to the
Sphinx theme. Since we are not bundling any documentation, I assume we can
ignore this one.


> I would also add all the other
> license files mentioned therein so we notice when they change or vanish.
>
> The Python-2.0 license in doc/scipy-sphinx-theme/LICENSE.txt is
> currently not available as an SPDX identifier, so I would leave this as
> "AND UNKNOWN", and wait until the respective SPDX issue is resolved...
> https://github.com/spdx/license-list-XML/issues/919


Same as above, this only applies to the Sphinx theme, so I assume we can
ignore this.


>
>
> numpy/core/src/multiarray/dragon4.c seems to be a license found nowhere
> else, so I would also add "AND UNKNOWN" to PYTHON3_NUMPY_LICENSE and add
> its verbatim license text with startline and endline parameters in
> PYTHON3_NUMPY_LICENSE_FILES. PTXdist extracts all those license
> texts mentioned in that variable and adds them to the license report,
> so it doesn't get lost too :)
>

OK.


>
> > +PYTHON3_NUMPY_LICENSE_FILES := \
> > +     file://LICENSE.txt;md5=d26bde5432613cce2334b93985576231
>
>
> file://doc/sphinxext/LICENSE.txt;md5=dc37e8b18377b83250218fc557984e1a \
>
> file://doc/scipy-sphinx-theme/LICENSE.txt;md5=ea17c9a65c9ae0ccdf3b0a7fd1ee4616
> \
>
> file://tools/npy_tempita/license.txt;md5=c66b85ddcd09296abff87601467724fd \
>
> file://numpy/core/src/multiarray/dragon4.c;startline=2;endline=22;md5=19537439573c5696a922ed7957c5b37e
> \
>
> (numpy/linalg/lapack_lite/LICENSE.txt is currently missing in the
> tarball, see https://github.com/numpy/numpy/issues/13295)
>
> For reference, that last one can be generated with a
>
>     sed -n 2,22p < inputfilename | md5sum
>
> Please check if all of this (especially the MD5s) make sense to you :)
>

Yes. Will double check and submit a new version of the patch.

Thank you!

Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com