* [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions.
@ 2019-12-10 18:55 Guillermo Rodríguez
2020-01-12 12:52 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: Guillermo Rodríguez @ 2019-12-10 18:55 UTC (permalink / raw)
To: ptxdist; +Cc: Guillermo Rodríguez
Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
---
.../0003-include-sysmacros-for-new-glibc.patch | 17 +++++++++++++++++
patches/udev-182/series | 1 +
2 files changed, 18 insertions(+)
create mode 100644 patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
diff --git a/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
new file mode 100644
index 000000000..b2f8db670
--- /dev/null
+++ b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
@@ -0,0 +1,17 @@
+Fix build with recent glibc releases where <sys/sysmacros.h> is no
+longer included as part of <sys/types.h>.
+
+Ref.: https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h
+
+Index: udev-182/src/libudev.h
+===================================================================
+--- udev-182.orig/src/libudev.h 2019-12-10 19:33:16.205447059 +0100
++++ udev-182/src/libudev.h 2019-12-10 19:33:27.965446957 +0100
+@@ -14,6 +14,7 @@
+
+ #include <stdarg.h>
+ #include <sys/types.h>
++#include <sys/sysmacros.h>
+ #include <sys/stat.h>
+
+ #ifdef __cplusplus
diff --git a/patches/udev-182/series b/patches/udev-182/series
index 74667acee..fe0693eb5 100644
--- a/patches/udev-182/series
+++ b/patches/udev-182/series
@@ -3,3 +3,4 @@
0001-configure.ac-fix-FTBFS-with-new-glibc.patch
0002-mtd-probe-fix-compilation.patch
# 78be5e697ec01d52a38071705c42d96a - git-ptx-patches magic
+0003-include-sysmacros-for-new-glibc.patch
--
2.21.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions.
2019-12-10 18:55 [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions Guillermo Rodríguez
@ 2020-01-12 12:52 ` Michael Olbrich
2020-01-13 8:47 ` Guillermo Rodriguez Garcia
0 siblings, 1 reply; 5+ messages in thread
From: Michael Olbrich @ 2020-01-12 12:52 UTC (permalink / raw)
To: ptxdist
On Tue, Dec 10, 2019 at 07:55:36PM +0100, Guillermo Rodríguez wrote:
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
> .../0003-include-sysmacros-for-new-glibc.patch | 17 +++++++++++++++++
> patches/udev-182/series | 1 +
> 2 files changed, 18 insertions(+)
> create mode 100644 patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
>
> diff --git a/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> new file mode 100644
> index 000000000..b2f8db670
> --- /dev/null
> +++ b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> @@ -0,0 +1,17 @@
> +Fix build with recent glibc releases where <sys/sysmacros.h> is no
> +longer included as part of <sys/types.h>.
> +
> +Ref.: https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h
> +
> +Index: udev-182/src/libudev.h
> +===================================================================
Please provide a proper patch header. Just recreating the patches with
git[1] should work.
> +--- udev-182.orig/src/libudev.h 2019-12-10 19:33:16.205447059 +0100
> ++++ udev-182/src/libudev.h 2019-12-10 19:33:27.965446957 +0100
> +@@ -14,6 +14,7 @@
> +
> + #include <stdarg.h>
> + #include <sys/types.h>
> ++#include <sys/sysmacros.h>
> + #include <sys/stat.h>
> +
> + #ifdef __cplusplus
> diff --git a/patches/udev-182/series b/patches/udev-182/series
> index 74667acee..fe0693eb5 100644
> --- a/patches/udev-182/series
> +++ b/patches/udev-182/series
> @@ -3,3 +3,4 @@
> 0001-configure.ac-fix-FTBFS-with-new-glibc.patch
> 0002-mtd-probe-fix-compilation.patch
> # 78be5e697ec01d52a38071705c42d96a - git-ptx-patches magic
> +0003-include-sysmacros-for-new-glibc.patch
This will recalculate the checksum here as well.
Michael
[1] https://www.ptxdist.org/doc/dev_manual.html#using-git
> --
> 2.21.0
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions.
2020-01-12 12:52 ` Michael Olbrich
@ 2020-01-13 8:47 ` Guillermo Rodriguez Garcia
2020-01-24 16:57 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: Guillermo Rodriguez Garcia @ 2020-01-13 8:47 UTC (permalink / raw)
To: ptxdist
El dom., 12 ene. 2020 a las 13:52, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> On Tue, Dec 10, 2019 at 07:55:36PM +0100, Guillermo Rodríguez wrote:
> > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > ---
> > .../0003-include-sysmacros-for-new-glibc.patch | 17 +++++++++++++++++
> > patches/udev-182/series | 1 +
> > 2 files changed, 18 insertions(+)
> > create mode 100644 patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> >
> > diff --git a/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > new file mode 100644
> > index 000000000..b2f8db670
> > --- /dev/null
> > +++ b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > @@ -0,0 +1,17 @@
> > +Fix build with recent glibc releases where <sys/sysmacros.h> is no
> > +longer included as part of <sys/types.h>.
> > +
> > +Ref.: https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h
> > +
> > +Index: udev-182/src/libudev.h
> > +===================================================================
>
> Please provide a proper patch header. Just recreating the patches with
> git[1] should work.
I created the patch using quilt as described in the ptxdist
documentation (https://www.ptxdist.org/doc/dev_manual.html#using-quilt).
If you don't intend to support this workflow, then I think you should
cleary state that in the docs.
Guillermo
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions.
2020-01-13 8:47 ` Guillermo Rodriguez Garcia
@ 2020-01-24 16:57 ` Michael Olbrich
2020-01-30 13:44 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: Michael Olbrich @ 2020-01-24 16:57 UTC (permalink / raw)
To: ptxdist
On Mon, Jan 13, 2020 at 09:47:37AM +0100, Guillermo Rodriguez Garcia wrote:
> El dom., 12 ene. 2020 a las 13:52, Michael Olbrich
> (<m.olbrich@pengutronix.de>) escribió:
> >
> > On Tue, Dec 10, 2019 at 07:55:36PM +0100, Guillermo Rodríguez wrote:
> > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > > ---
> > > .../0003-include-sysmacros-for-new-glibc.patch | 17 +++++++++++++++++
> > > patches/udev-182/series | 1 +
> > > 2 files changed, 18 insertions(+)
> > > create mode 100644 patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > >
> > > diff --git a/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > new file mode 100644
> > > index 000000000..b2f8db670
> > > --- /dev/null
> > > +++ b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > @@ -0,0 +1,17 @@
> > > +Fix build with recent glibc releases where <sys/sysmacros.h> is no
> > > +longer included as part of <sys/types.h>.
> > > +
> > > +Ref.: https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h
> > > +
> > > +Index: udev-182/src/libudev.h
> > > +===================================================================
> >
> > Please provide a proper patch header. Just recreating the patches with
> > git[1] should work.
>
> I created the patch using quilt as described in the ptxdist
> documentation (https://www.ptxdist.org/doc/dev_manual.html#using-quilt).
> If you don't intend to support this workflow, then I think you should
> cleary state that in the docs.
Indeed, I should add a comment to the docs about this.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions.
2020-01-24 16:57 ` Michael Olbrich
@ 2020-01-30 13:44 ` Michael Olbrich
0 siblings, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2020-01-30 13:44 UTC (permalink / raw)
To: ptxdist
On Fri, Jan 24, 2020 at 05:57:50PM +0100, Michael Olbrich wrote:
> On Mon, Jan 13, 2020 at 09:47:37AM +0100, Guillermo Rodriguez Garcia wrote:
> > El dom., 12 ene. 2020 a las 13:52, Michael Olbrich
> > (<m.olbrich@pengutronix.de>) escribió:
> > >
> > > On Tue, Dec 10, 2019 at 07:55:36PM +0100, Guillermo Rodríguez wrote:
> > > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > > > ---
> > > > .../0003-include-sysmacros-for-new-glibc.patch | 17 +++++++++++++++++
> > > > patches/udev-182/series | 1 +
> > > > 2 files changed, 18 insertions(+)
> > > > create mode 100644 patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > >
> > > > diff --git a/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > > new file mode 100644
> > > > index 000000000..b2f8db670
> > > > --- /dev/null
> > > > +++ b/patches/udev-182/0003-include-sysmacros-for-new-glibc.patch
> > > > @@ -0,0 +1,17 @@
> > > > +Fix build with recent glibc releases where <sys/sysmacros.h> is no
> > > > +longer included as part of <sys/types.h>.
> > > > +
> > > > +Ref.: https://wiki.gentoo.org/wiki/Glibc_2.26_porting_notes/sysmacros.h
> > > > +
> > > > +Index: udev-182/src/libudev.h
> > > > +===================================================================
> > >
> > > Please provide a proper patch header. Just recreating the patches with
> > > git[1] should work.
> >
> > I created the patch using quilt as described in the ptxdist
> > documentation (https://www.ptxdist.org/doc/dev_manual.html#using-quilt).
> > If you don't intend to support this workflow, then I think you should
> > cleary state that in the docs.
>
> Indeed, I should add a comment to the docs about this.
Done:
https://www.ptxdist.org/doc/dev_manual.html#using-quilt
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-30 13:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 18:55 [ptxdist] [PATCH] udev-legacy: Fix build with recent glibc versions Guillermo Rodríguez
2020-01-12 12:52 ` Michael Olbrich
2020-01-13 8:47 ` Guillermo Rodriguez Garcia
2020-01-24 16:57 ` Michael Olbrich
2020-01-30 13:44 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox