mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de
Cc: Alejandro Vazquez <avazquez.dev@gmail.com>
Subject: Re: [ptxdist] Classpath -- move out from staging?
Date: Fri, 20 Oct 2023 10:46:01 +0200	[thread overview]
Message-ID: <CABDcavacZ4NS1irMFpZSvQvnomLJX1NnP2zgb+v3KDhdrU34_Q@mail.gmail.com> (raw)
In-Reply-To: <ZTI1Fm6mb4gHzdG/@pengutronix.de>

El vie, 20 oct 2023 a las 10:06, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> Hi,
>
> On Wed, Oct 18, 2023 at 10:34:10AM +0200, Guillermo Rodriguez Garcia wrote:
> > El mié, 18 oct 2023 a las 8:00, Michael Olbrich
> > (<m.olbrich@pengutronix.de>) escribió:
> > > On Sat, Oct 14, 2023 at 04:49:12PM +0200, Guillermo Rodriguez Garcia wrote:
> > > > I see that the classpath package was moved to staging in commit
> > > > f2afdd541d3dc1cbac965ddaf899009780de2aae, with a note stating that it
> > > > could not be built with any current (Java) distribution.
> > > >
> > > > My team and I are still using this actively, and it can be built with
> > > > OpenJDK 8 which is still supported and is expected to be be supported
> > > > for a while (for example Adoptium states it will be supported "At
> > > > least until Nov 2026").
> > > >
> > > > Can we move this out of staging? If so I will prepare a patch.
> > >
> > > No. In fakt, I should have removed it entirely some time ago. I just missed
> > > it. And I will remove it soon. The problem is, that I cannot even
> > > build-test it any more and that's the minimum requirement for having it
> > > upstream.
> >
> >
> > It should build fine with OpenJDK 8 which is still fully supported and
> > widely available.
> > Are you having problems with this?
> > Can you share the details?
>
> My main test infrastructure runs on Debian. And OpenJDK 8 (and javah, the
> tool that is missing) was removed a long time ago.
>
> What's the benefit of having this upstream? You can easily put the package
> in your BSP. Is has no special requirements. You seem to be the only user
> of this package and without test coverage Upstream there is no benefit in
> keeping it here.

Well, yes, of course I can easily put the package in our BSPs (the
same could be said for any other package, though).

The benefits of having it upstream are:

1. Not having to manually add this to every BSP (we maintain a bunch
of them already and will be adding more)
2. Having it upstream may increase visibility of the package and thus
possibly increase the chances of people using it (it wouldn't be the
first time I learn about a package because I see it in ptxdist and end
up using it in our BSPs). More people using it is always a good thing
(more eyes).
3. Test coverage upstream, if we can find a way to fix that.

Would you be willing to reconsider if we can find a way to work around
the missing javah?

BR,

Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com



      reply	other threads:[~2023-10-20  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-14 14:49 Guillermo Rodriguez Garcia
2023-10-18  6:00 ` Michael Olbrich
2023-10-18  8:34   ` Guillermo Rodriguez Garcia
2023-10-20  8:06     ` Michael Olbrich
2023-10-20  8:46       ` Guillermo Rodriguez Garcia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABDcavacZ4NS1irMFpZSvQvnomLJX1NnP2zgb+v3KDhdrU34_Q@mail.gmail.com \
    --to=guille.rodriguez@gmail.com \
    --cc=avazquez.dev@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox