Re: [ptxdist] [PATCH] imx-kobs: New package

[Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>]

Hi Alexander,

El mar., 23 oct. 2018 a las 13:00, Alexander Dahl (<ada@thorsis.com>) escribió:
>
> Hei hei,
>
> this is strange, I was just working on a new package for the very same tool.
> o.O

:)

> Am Dienstag, 23. Oktober 2018, 11:23:36 CEST schrieb Guillermo Rodríguez:
> > The imx-kobs tool is used to create and write i.MX NAND boot
> > related boot data structures to NAND flash.
> >
> > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > ---
> >  rules/imx-kobs.in   |  8 ++++++++
> >  rules/imx-kobs.make | 53
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61
> > insertions(+)
> >  create mode 100644 rules/imx-kobs.in
> >  create mode 100644 rules/imx-kobs.make
> >
> > diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
> > new file mode 100644
> > index 0000000..e00ca24
> > --- /dev/null
> > +++ b/rules/imx-kobs.in
> > @@ -0,0 +1,8 @@
> > +## SECTION=shell_and_console
> > +
> > +config IMX_KOBS
> > +     tristate
> > +     prompt "imx-kobs"
> > +     help
> > +       The imx-kobs tool is used to create and write i.MX NAND boot
> > +       related boot data structures to NAND flash.
> > diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
> > new file mode 100644
> > index 0000000..49380c2
> > --- /dev/null
> > +++ b/rules/imx-kobs.make
> > @@ -0,0 +1,53 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
> > +
> > +#
> > +# Paths and names
> > +#
> > +IMX_KOBS_VERSION     := 5.5
> > +IMX_KOBS_SUFFIX              := tar.gz
> > +IMX_KOBS_MD5         := 48ed9e69e9527d2e98b5cfcbf133d75b
> > +IMX_KOBS             := imx-kobs-$(IMX_KOBS_VERSION)
> > +IMX_KOBS_URL         :=
> > http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFI
>
> How did you find this? I would have taken the tool from GitHub:

I have to admit I am not sure anymore where I found this. When
cleaning up the .make file I considered switching to github, but at
the end I chose not to do it as it had no tags and I thought that this
would be cleaner than referencing a specific commit by its hash.

> https://github.com/NXPmicro/imx-kobs
>
> That one is without tags however.
>
> > X) +IMX_KOBS_DIR              := $(BUILDDIR)/$(IMX_KOBS)
> > +IMX_KOBS_SOURCE              := $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> > +IMX_KOBS_LICENSE     := GPLv2
>
> GPL-2.0-or-later

OK.

> What about IMX_KOBS_LICENSE_FILES  := file://COPYING;md5=…

Never did this before, I thought it was only necessary for
not-well-known licenses. Should I add it?

Thanks,

Guillermo

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de