* [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes @ 2019-08-05 8:18 Guillermo Rodríguez 2019-08-07 12:25 ` Michael Olbrich 0 siblings, 1 reply; 5+ messages in thread From: Guillermo Rodríguez @ 2019-08-05 8:18 UTC (permalink / raw) To: ptxdist; +Cc: Guillermo Rodríguez Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com> --- rules/fbset.in | 14 ++++++++++++-- rules/fbset.make | 4 +++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/rules/fbset.in b/rules/fbset.in index c2122c51b..64dd9ec55 100644 --- a/rules/fbset.in +++ b/rules/fbset.in @@ -1,11 +1,21 @@ ## SECTION=multimedia_framebuffer -config FBSET +menuconfig FBSET tristate - prompt "fbset" + prompt "fbset " select HOST_FLEX help fbset is a system utility to show or change the settings of the frame buffer device. The frame buffer device pro- vides a simple and unique interface to access different kinds of graphic displays. + +if FBSET + +config FBSET_FBMODES + bool + prompt "install /etc/fb.modes" + help + Install /etc/fb.modes file. + +endif diff --git a/rules/fbset.make b/rules/fbset.make index 0d34d8959..955480b21 100644 --- a/rules/fbset.make +++ b/rules/fbset.make @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall: @$(call install_fixup, fbset,DESCRIPTION,missing) @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset) - +ifdef PTXCONF_FBSET_FBMODES + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes) +endif @$(call install_finish, fbset) @$(call touch) -- 2.21.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes 2019-08-05 8:18 [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes Guillermo Rodríguez @ 2019-08-07 12:25 ` Michael Olbrich 2019-08-07 14:22 ` Guillermo Rodriguez Garcia 0 siblings, 1 reply; 5+ messages in thread From: Michael Olbrich @ 2019-08-07 12:25 UTC (permalink / raw) To: ptxdist On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guillermo Rodríguez wrote: > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com> > --- > rules/fbset.in | 14 ++++++++++++-- > rules/fbset.make | 4 +++- > 2 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/rules/fbset.in b/rules/fbset.in > index c2122c51b..64dd9ec55 100644 > --- a/rules/fbset.in > +++ b/rules/fbset.in > @@ -1,11 +1,21 @@ > ## SECTION=multimedia_framebuffer > > -config FBSET > +menuconfig FBSET > tristate > - prompt "fbset" > + prompt "fbset " > select HOST_FLEX > help > fbset is a system utility to show or change the settings > of the frame buffer device. The frame buffer device pro- > vides a simple and unique interface to access different > kinds of graphic displays. > + > +if FBSET > + > +config FBSET_FBMODES > + bool > + prompt "install /etc/fb.modes" > + help > + Install /etc/fb.modes file. > + > +endif > diff --git a/rules/fbset.make b/rules/fbset.make > index 0d34d8959..955480b21 100644 > --- a/rules/fbset.make > +++ b/rules/fbset.make > @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall: > @$(call install_fixup, fbset,DESCRIPTION,missing) > > @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset) > - > +ifdef PTXCONF_FBSET_FBMODES > + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes) > +endif Hmmm, I don't like options that are broken by default. Please add a default file in projectroot/. Michael > @$(call install_finish, fbset) > > @$(call touch) > -- > 2.21.0 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes 2019-08-07 12:25 ` Michael Olbrich @ 2019-08-07 14:22 ` Guillermo Rodriguez Garcia 2019-08-07 15:05 ` Michael Olbrich 0 siblings, 1 reply; 5+ messages in thread From: Guillermo Rodriguez Garcia @ 2019-08-07 14:22 UTC (permalink / raw) To: ptxdist [-- Attachment #1.1: Type: text/plain, Size: 2177 bytes --] Hi, El mié., 7 ago. 2019 a las 14:26, Michael Olbrich (<m.olbrich@pengutronix.de>) escribió: > On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guillermo Rodríguez wrote: > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com> > > --- > > rules/fbset.in | 14 ++++++++++++-- > > rules/fbset.make | 4 +++- > > 2 files changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/rules/fbset.in b/rules/fbset.in > > index c2122c51b..64dd9ec55 100644 > > --- a/rules/fbset.in > > +++ b/rules/fbset.in > > @@ -1,11 +1,21 @@ > > ## SECTION=multimedia_framebuffer > > > > -config FBSET > > +menuconfig FBSET > > tristate > > - prompt "fbset" > > + prompt "fbset " > > select HOST_FLEX > > help > > fbset is a system utility to show or change the settings > > of the frame buffer device. The frame buffer device pro- > > vides a simple and unique interface to access different > > kinds of graphic displays. > > + > > +if FBSET > > + > > +config FBSET_FBMODES > > + bool > > + prompt "install /etc/fb.modes" > > + help > > + Install /etc/fb.modes file. > > + > > +endif > > diff --git a/rules/fbset.make b/rules/fbset.make > > index 0d34d8959..955480b21 100644 > > --- a/rules/fbset.make > > +++ b/rules/fbset.make > > @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall: > > @$(call install_fixup, fbset,DESCRIPTION,missing) > > > > @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset) > > - > > +ifdef PTXCONF_FBSET_FBMODES > > + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes) > > +endif > > Hmmm, I don't like options that are broken by default. > OK, although this is disabled by default. I assume that users that enable it have a valid fb.modes file that they want to include.. > Please add a default file in projectroot/. > fb modes (timings specifically) are hardware-specific. Is it OK if I add a default file with no modes defined? (I can e.g. add a comment saying that it is a placeholder) Guillermo Rodriguez Garcia guille.rodriguez@gmail.com [-- Attachment #1.2: Type: text/html, Size: 3535 bytes --] [-- Attachment #2: Type: text/plain, Size: 92 bytes --] _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes 2019-08-07 14:22 ` Guillermo Rodriguez Garcia @ 2019-08-07 15:05 ` Michael Olbrich 2019-08-08 16:03 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez 0 siblings, 1 reply; 5+ messages in thread From: Michael Olbrich @ 2019-08-07 15:05 UTC (permalink / raw) To: ptxdist On Wed, Aug 07, 2019 at 04:22:03PM +0200, Guillermo Rodriguez Garcia wrote: > El mié., 7 ago. 2019 a las 14:26, Michael Olbrich (<m.olbrich@pengutronix.de>) > escribió: > > On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guillermo Rodríguez wrote: > > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com> > > > --- > > > rules/fbset.in | 14 ++++++++++++-- > > > rules/fbset.make | 4 +++- > > > 2 files changed, 15 insertions(+), 3 deletions(-) > > > > > > diff --git a/rules/fbset.in b/rules/fbset.in > > > index c2122c51b..64dd9ec55 100644 > > > --- a/rules/fbset.in > > > +++ b/rules/fbset.in > > > @@ -1,11 +1,21 @@ > > > ## SECTION=multimedia_framebuffer > > > > > > -config FBSET > > > +menuconfig FBSET > > > tristate > > > - prompt "fbset" > > > + prompt "fbset " > > > select HOST_FLEX > > > help > > > fbset is a system utility to show or change the settings > > > of the frame buffer device. The frame buffer device pro- > > > vides a simple and unique interface to access different > > > kinds of graphic displays. > > > + > > > +if FBSET > > > + > > > +config FBSET_FBMODES > > > + bool > > > + prompt "install /etc/fb.modes" > > > + help > > > + Install /etc/fb.modes file. > > > + > > > +endif > > > diff --git a/rules/fbset.make b/rules/fbset.make > > > index 0d34d8959..955480b21 100644 > > > --- a/rules/fbset.make > > > +++ b/rules/fbset.make > > > @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall: > > > @$(call install_fixup, fbset,DESCRIPTION,missing) > > > > > > @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset) > > > - > > > +ifdef PTXCONF_FBSET_FBMODES > > > + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes) > > > +endif > > > > Hmmm, I don't like options that are broken by default. > > > > OK, although this is disabled by default. I assume that users that enable > it have a valid fb.modes file that they want to include.. I do some "enable everything" testing and I prefer to avoid exceptions. > > Please add a default file in projectroot/. > > > > fb modes (timings specifically) are hardware-specific. Is it OK if I add a > default file with no modes defined? (I can e.g. add a comment saying that > it is a placeholder) If that has the same effect as no config, then it's perfect. Of if it fails with some meaningful error at runtime it's also ok. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* [ptxdist] [PATCH v2] Add option to install /etc/fb.modes 2019-08-07 15:05 ` Michael Olbrich @ 2019-08-08 16:03 ` Guillermo Rodríguez 0 siblings, 0 replies; 5+ messages in thread From: Guillermo Rodríguez @ 2019-08-08 16:03 UTC (permalink / raw) To: ptxdist; +Cc: Guillermo Rodríguez Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com> --- Changes since v1: * Added sample etc/fb.modes file projectroot/etc/fb.modes | 12 ++++++++++++ rules/fbset.in | 14 ++++++++++++-- rules/fbset.make | 4 +++- 3 files changed, 27 insertions(+), 3 deletions(-) create mode 100644 projectroot/etc/fb.modes diff --git a/projectroot/etc/fb.modes b/projectroot/etc/fb.modes new file mode 100644 index 000000000..54da1b169 --- /dev/null +++ b/projectroot/etc/fb.modes @@ -0,0 +1,12 @@ +# +# Contains video mode descriptions +# See the manual pages for fbset: fbset(8), fb.modes(5) +# + +# mode "<name>" +# geometry <xres> <yres> <vxres> <vyres> <depth> +# timings <pixclock> <left> <right> <upper> <lower> <hslen> <vslen> +# option <value> +# option <value> +# ... +# endmode diff --git a/rules/fbset.in b/rules/fbset.in index c2122c51b..64dd9ec55 100644 --- a/rules/fbset.in +++ b/rules/fbset.in @@ -1,11 +1,21 @@ ## SECTION=multimedia_framebuffer -config FBSET +menuconfig FBSET tristate - prompt "fbset" + prompt "fbset " select HOST_FLEX help fbset is a system utility to show or change the settings of the frame buffer device. The frame buffer device pro- vides a simple and unique interface to access different kinds of graphic displays. + +if FBSET + +config FBSET_FBMODES + bool + prompt "install /etc/fb.modes" + help + Install /etc/fb.modes file. + +endif diff --git a/rules/fbset.make b/rules/fbset.make index 0d34d8959..955480b21 100644 --- a/rules/fbset.make +++ b/rules/fbset.make @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall: @$(call install_fixup, fbset,DESCRIPTION,missing) @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset) - +ifdef PTXCONF_FBSET_FBMODES + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes) +endif @$(call install_finish, fbset) @$(call touch) -- 2.21.0 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-08 16:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-08-05 8:18 [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes Guillermo Rodríguez 2019-08-07 12:25 ` Michael Olbrich 2019-08-07 14:22 ` Guillermo Rodriguez Garcia 2019-08-07 15:05 ` Michael Olbrich 2019-08-08 16:03 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox