From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1hvMpW-0000zB-0k for ptxdist@pengutronix.de; Wed, 07 Aug 2019 16:22:18 +0200 Received: by mail-ed1-x544.google.com with SMTP id k8so86408751edr.11 for ; Wed, 07 Aug 2019 07:22:17 -0700 (PDT) MIME-Version: 1.0 References: <20190805081842.24530-1-guille.rodriguez@gmail.com> <20190807122543.ze62u4w6ovrnfwar@pengutronix.de> In-Reply-To: <20190807122543.ze62u4w6ovrnfwar@pengutronix.de> From: Guillermo Rodriguez Garcia Date: Wed, 7 Aug 2019 16:22:03 +0200 Message-ID: Subject: Re: [ptxdist] [PATCH] fbset: Add option to install /etc/fb.modes List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0111985668==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de --===============0111985668== Content-Type: multipart/alternative; boundary="00000000000011e3cc058f87ab73" --00000000000011e3cc058f87ab73 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, El mi=C3=A9., 7 ago. 2019 a las 14:26, Michael Olbrich () escribi=C3=B3: > On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guillermo Rodr=C3=ADguez wrote: > > Signed-off-by: Guillermo Rodriguez > > --- > > rules/fbset.in | 14 ++++++++++++-- > > rules/fbset.make | 4 +++- > > 2 files changed, 15 insertions(+), 3 deletions(-) > > > > diff --git a/rules/fbset.in b/rules/fbset.in > > index c2122c51b..64dd9ec55 100644 > > --- a/rules/fbset.in > > +++ b/rules/fbset.in > > @@ -1,11 +1,21 @@ > > ## SECTION=3Dmultimedia_framebuffer > > > > -config FBSET > > +menuconfig FBSET > > tristate > > - prompt "fbset" > > + prompt "fbset " > > select HOST_FLEX > > help > > fbset is a system utility to show or change the settings > > of the frame buffer device. The frame buffer device pro- > > vides a simple and unique interface to access different > > kinds of graphic displays. > > + > > +if FBSET > > + > > +config FBSET_FBMODES > > + bool > > + prompt "install /etc/fb.modes" > > + help > > + Install /etc/fb.modes file. > > + > > +endif > > diff --git a/rules/fbset.make b/rules/fbset.make > > index 0d34d8959..955480b21 100644 > > --- a/rules/fbset.make > > +++ b/rules/fbset.make > > @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall: > > @$(call install_fixup, fbset,DESCRIPTION,missing) > > > > @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset) > > - > > +ifdef PTXCONF_FBSET_FBMODES > > + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes) > > +endif > > Hmmm, I don't like options that are broken by default. > OK, although this is disabled by default. I assume that users that enable it have a valid fb.modes file that they want to include.. > Please add a default file in projectroot/. > fb modes (timings specifically) are hardware-specific. Is it OK if I add a default file with no modes defined? (I can e.g. add a comment saying that it is a placeholder) Guillermo Rodriguez Garcia guille.rodriguez@gmail.com --00000000000011e3cc058f87ab73 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

El mi=C3=A9., 7 ago. 2019 a las 14:26, Michael Olbrich (<m.olbrich@pengutronix.de>) = escribi=C3=B3:
On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guiller= mo Rodr=C3=ADguez wrote:
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>=C2=A0 rules/fbset.in=C2=A0 =C2=A0| 14 ++++++++++++--
>=C2=A0 rules/fbset.make |=C2=A0 4 +++-
>=C2=A0 2 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/rules/fbset.in b/rules/fbset.in
> index c2122c51b..64dd9ec55 100644
> --- a/rules/fbset.in
> +++ b/rules/fbset.in
> @@ -1,11 +1,21 @@
>=C2=A0 ## SECTION=3Dmultimedia_framebuffer
>=C2=A0
> -config FBSET
> +menuconfig FBSET
>=C2=A0 =C2=A0 =C2=A0 =C2=A0tristate
> -=C2=A0 =C2=A0 =C2=A0prompt "fbset"
> +=C2=A0 =C2=A0 =C2=A0prompt "fbset=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0select HOST_FLEX
>=C2=A0 =C2=A0 =C2=A0 =C2=A0help
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fbset is a system utility to show or = change the settings
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0of the frame buffer device. The frame= buffer device pro-
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vides a simple and unique interface t= o access different
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0kinds of graphic displays.
> +
> +if FBSET
> +
> +config FBSET_FBMODES
> +=C2=A0 =C2=A0 =C2=A0bool
> +=C2=A0 =C2=A0 =C2=A0prompt "install /etc/fb.modes"
> +=C2=A0 =C2=A0 =C2=A0help
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0Install /etc/fb.modes file.
> +
> +endif
> diff --git a/rules/fbset.make b/rules/fbset.make
> index 0d34d8959..955480b21 100644
> --- a/rules/fbset.make
> +++ b/rules/fbset.make
> @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0@$(call install_fixup, fbset,DESCRIPTION,mis= sing)
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0@$(call install_copy, fbset, 0, 0, 0755, -, = /usr/sbin/fbset)
> -
> +ifdef PTXCONF_FBSET_FBMODES
> +=C2=A0 =C2=A0 =C2=A0@$(call install_alternative, fbset, 0, 0, 0644, /= etc/fb.modes)
> +endif

Hmmm, I don't like options that are broken by default.
=

OK, although this is disabled by default. I assume that= users that enable it have a valid fb.modes file that they want to include.= .
=C2=A0
Please add a default file in projectroot/.

<= div>fb modes (timings specifically) are hardware-specific. Is it OK if I ad= d a default file with no modes defined? (I can e.g. add a comment saying th= at it is a placeholder)

Guillermo Rodriguez Garcia=
guille.rodriguez@gmail.com<= /a>
--00000000000011e3cc058f87ab73-- --===============0111985668== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de --===============0111985668==--