On Mon, Aug 05, 2019 at 10:18:42AM +0200, Guillermo Rodríguez wrote:
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
> rules/fbset.in | 14 ++++++++++++--
> rules/fbset.make | 4 +++-
> 2 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/rules/fbset.in b/rules/fbset.in
> index c2122c51b..64dd9ec55 100644
> --- a/rules/fbset.in
> +++ b/rules/fbset.in
> @@ -1,11 +1,21 @@
> ## SECTION=multimedia_framebuffer
>
> -config FBSET
> +menuconfig FBSET
> tristate
> - prompt "fbset"
> + prompt "fbset "
> select HOST_FLEX
> help
> fbset is a system utility to show or change the settings
> of the frame buffer device. The frame buffer device pro-
> vides a simple and unique interface to access different
> kinds of graphic displays.
> +
> +if FBSET
> +
> +config FBSET_FBMODES
> + bool
> + prompt "install /etc/fb.modes"
> + help
> + Install /etc/fb.modes file.
> +
> +endif
> diff --git a/rules/fbset.make b/rules/fbset.make
> index 0d34d8959..955480b21 100644
> --- a/rules/fbset.make
> +++ b/rules/fbset.make
> @@ -45,7 +45,9 @@ $(STATEDIR)/fbset.targetinstall:
> @$(call install_fixup, fbset,DESCRIPTION,missing)
>
> @$(call install_copy, fbset, 0, 0, 0755, -, /usr/sbin/fbset)
> -
> +ifdef PTXCONF_FBSET_FBMODES
> + @$(call install_alternative, fbset, 0, 0, 0644, /etc/fb.modes)
> +endif
Hmmm, I don't like options that are broken by default.
OK, although this is disabled by default. I assume that users that enable it have a valid fb.modes file that they want to include..
Please add a default file in projectroot/.
fb modes (timings specifically) are hardware-specific. Is it OK if I add a default file with no modes defined? (I can e.g. add a comment saying that it is a placeholder)
Guillermo Rodriguez Garcia