From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
MIME-Version: 1.0
In-Reply-To: <CABDcavZA5Wp6J0UoyraN1esjWMnadUTYXmuWib5FdK2gwLajsA@mail.gmail.com>
References: <CACVyVz-4dbq7HpFDRqsDrNzYUib4-bap=Dyx1mcTk7Qh_Hr=sA@mail.gmail.com>
	<CACVyVz_ybnf47sT+1_DQp=Hw2kvncuTnYMoUfpdk4h2-+qpkHg@mail.gmail.com>
	<CABDcava90YefdNsp1DLWvehiQDD55x5=jWpyR2hoZB-rM_gRyQ@mail.gmail.com>
	<201405130949.19849.jbe@pengutronix.de>
	<CABDcavZA5Wp6J0UoyraN1esjWMnadUTYXmuWib5FdK2gwLajsA@mail.gmail.com>
Date: Tue, 13 May 2014 14:08:33 +0200
Message-ID: <CABDcavZbBqCPY-pACh8PH=AFLZHThajcPbyO0cmFNOs8DDwRqw@mail.gmail.com>
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
Subject: Re: [ptxdist] [oselas]  ptxdist on a x86 target, grub problem ?
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: Juergen Borleis <jbe@pengutronix.de>
Cc: oselas@community.pengutronix.de, Stella GZ <gzestela@gmail.com>, ptxdist@pengutronix.de

2014-05-13 11:41 GMT+02:00 Guillermo Rodriguez Garcia
<guille.rodriguez@gmail.com>:
> Hi Juergen,
>
> 2014-05-13 9:49 GMT+02:00 Juergen Borleis <jbe@pengutronix.de>:
>> Hi Guillermo,
>>
>> On Monday 12 May 2014 20:14:08 Guillermo Rodriguez Garcia wrote:
>>> [...]
>>> Ptxdist maintainers: Is there a reason for the separate menu.lst.i586
>>> file? Except for the issue described above it seems to be almost identical to
>>> the generic menu.lst file in ptxdist.
>>
>> Sometimes these kind of files where required because at the time of their
>> addition PTXdist didn't come with one. And later versions of PTXdist support
>> these files and we forget to remove the local file from the BSP.
>>
>> If you think this file is needless now (and you have tested it), you are
>> welcome to send a patch to remove it from the repo.
>
> I would say it should be either removed or fixed. What do you prefer?

After having a second look: I think the right thing to do would be to remove
this file, however this doesn't work as expected. By default, grub.in defines
a hardcoded path for the GRUB_MENU_LIST option:
${PTXDIST_WORKSPACE}/projectroot/boot/grub/menu.lst

So if the file from projectroot/... is simply removed, the menu.lst from
generic/boot/grub/ is NOT used.

I think this was not the intention (looks like the generic file should be used
if no project specific file is available) but I am not sure how this should be
fixed.

So perhaps the best way is just to patch the local menu.lst file in the
Generic BSP.

-- 
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

-- 
ptxdist mailing list
ptxdist@pengutronix.de