From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: oselas@community.pengutronix.de, Stella GZ <gzestela@gmail.com>,
ptxdist@pengutronix.de
Subject: Re: [ptxdist] [oselas] ptxdist on a x86 target, grub problem ?
Date: Tue, 13 May 2014 14:08:33 +0200 [thread overview]
Message-ID: <CABDcavZbBqCPY-pACh8PH=AFLZHThajcPbyO0cmFNOs8DDwRqw@mail.gmail.com> (raw)
In-Reply-To: <CABDcavZA5Wp6J0UoyraN1esjWMnadUTYXmuWib5FdK2gwLajsA@mail.gmail.com>
2014-05-13 11:41 GMT+02:00 Guillermo Rodriguez Garcia
<guille.rodriguez@gmail.com>:
> Hi Juergen,
>
> 2014-05-13 9:49 GMT+02:00 Juergen Borleis <jbe@pengutronix.de>:
>> Hi Guillermo,
>>
>> On Monday 12 May 2014 20:14:08 Guillermo Rodriguez Garcia wrote:
>>> [...]
>>> Ptxdist maintainers: Is there a reason for the separate menu.lst.i586
>>> file? Except for the issue described above it seems to be almost identical to
>>> the generic menu.lst file in ptxdist.
>>
>> Sometimes these kind of files where required because at the time of their
>> addition PTXdist didn't come with one. And later versions of PTXdist support
>> these files and we forget to remove the local file from the BSP.
>>
>> If you think this file is needless now (and you have tested it), you are
>> welcome to send a patch to remove it from the repo.
>
> I would say it should be either removed or fixed. What do you prefer?
After having a second look: I think the right thing to do would be to remove
this file, however this doesn't work as expected. By default, grub.in defines
a hardcoded path for the GRUB_MENU_LIST option:
${PTXDIST_WORKSPACE}/projectroot/boot/grub/menu.lst
So if the file from projectroot/... is simply removed, the menu.lst from
generic/boot/grub/ is NOT used.
I think this was not the intention (looks like the generic file should be used
if no project specific file is available) but I am not sure how this should be
fixed.
So perhaps the best way is just to patch the local menu.lst file in the
Generic BSP.
--
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2014-05-13 12:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 12:12 [ptxdist] " Stella GZ
2014-05-12 12:20 ` Juergen Borleis
[not found] ` <CACVyVz-AoZJ-=rnv0fjbFKPMtDVZcC5kpbgV0wWKUJ=T+Dz29Q@mail.gmail.com>
2014-05-12 12:34 ` Juergen Borleis
2014-05-12 14:55 ` Stella GZ
2014-05-12 15:57 ` Stella GZ
2014-05-12 18:14 ` [ptxdist] [oselas] " Guillermo Rodriguez Garcia
2014-05-13 7:49 ` Juergen Borleis
2014-05-13 9:41 ` Guillermo Rodriguez Garcia
2014-05-13 12:08 ` Guillermo Rodriguez Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABDcavZbBqCPY-pACh8PH=AFLZHThajcPbyO0cmFNOs8DDwRqw@mail.gmail.com' \
--to=guille.rodriguez@gmail.com \
--cc=gzestela@gmail.com \
--cc=jbe@pengutronix.de \
--cc=oselas@community.pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox