mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de, AVazquez <avazquez.dev@gmail.com>,
	Sascha Hauer <sha@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v2] ptxd_make_fit_image: Add support for kernel load/entry addresses
Date: Fri, 13 Nov 2020 09:54:38 +0100	[thread overview]
Message-ID: <CABDcavZYM4nUyc8e7MhrGroOQZGEgTEeZ2SdnoqYHZoOUzP1iw@mail.gmail.com> (raw)
In-Reply-To: <20201113084647.GC3748985@dude03.red.stw.pengutronix.de>

Hi Michael,

El vie., 13 nov. 2020 a las 9:46, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> On Wed, Nov 11, 2020 at 04:23:39PM +0100, avazquez.dev@gmail.com wrote:
> > From: AVazquez <avazquez.dev@gmail.com>
> >
> > Make it possible to specify load/entry addresses for the kernel.
> > These are required by the FIT image specification, but in some cases
> > users may not want to include them, so they are made optional.
> >
> > Also add mandatory "os" property for kernel and ramdisk.
> >
> > Signed-off-by: AVazquez <avazquez.dev@gmail.com>
> > ---
> > Changes since v1:
> > - load/entry addresses made optional
> >
> >  platforms/kernel-fit.in            |  8 ++++++++
> >  scripts/lib/ptxd_make_fit_image.sh | 14 ++++++++++++++
> >  2 files changed, 22 insertions(+)
> >
> > diff --git a/platforms/kernel-fit.in b/platforms/kernel-fit.in
> > index 8cbc1a8..b5f9da6 100644
> > --- a/platforms/kernel-fit.in
> > +++ b/platforms/kernel-fit.in
> > @@ -17,6 +17,14 @@ menuconfig KERNEL_FIT
> >
> >  if KERNEL_FIT
> >
> > +config KERNEL_FIT_LOAD
> > +     string
> > +     prompt "Kernel load address (optional)"
>
> I'd like some help text here to clarify when this is needed. From what I
> understand from the discussion, u-boots requires this, right?
> But barebox does not? Never, or does it depend on the kernel image type?

According to the FIT image specification, the "load" and "entry"
properties are mandatory for the "kernel" node. See:
https://gitlab.denx.de/u-boot/u-boot/-/blob/master/doc/uImage.FIT/source_file_format.txt#L181
So for a valid FIT image these properties should always be present.
However according to Sascha, Barebox does not enforce this (and
actually ignores the properties even if they are present?).
U-boot certainly requires them.

Guillermo

>
> Sascha, can you help here?
>
> > +
> > +config KERNEL_FIT_ENTRY
> > +     string
> > +     prompt "Kernel entry address (optional)"
>
> The same here.
>
> > +
> >  config KERNEL_FIT_SIGNED
> >       bool
> >       prompt "sign FIT image"
> > diff --git a/scripts/lib/ptxd_make_fit_image.sh b/scripts/lib/ptxd_make_fit_image.sh
> > index 9754d1e..1edf5c5 100644
> > --- a/scripts/lib/ptxd_make_fit_image.sh
> > +++ b/scripts/lib/ptxd_make_fit_image.sh
> > @@ -21,7 +21,20 @@ ptxd_make_image_fit_its() {
> >                       data = /incbin/("${image_kernel}");
> >                       type = "kernel";
> >                       arch = "$(ptxd_get_ptxconf PTXCONF_ARCH_STRING)";
> > +                     os = "linux";
>
> Sascha, setting this is ok for barebox, right?
>
> >                       compression = "none";
> > +EOF
> > +                     if [ -n "$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_LOAD)" ]; then
> > +                     cat << EOF
>
> The code should be indented to align with the code above.
>
>     if [ ... ]; then
>         cat << EOF
>
> I think.
>
> > +                     load = <$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_LOAD)>;
> > +EOF
> > +                     fi
> > +                     if [ -n "$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_ENTRY)" ]; then
> > +                     cat << EOF
>
> same here.
>
> Michael
>
> > +                     entry = <$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_ENTRY)>;
> > +EOF
> > +                     fi
> > +                     cat << EOF
> >                       hash-1 {
> >                               algo = "sha256";
> >                       };
> > @@ -33,6 +46,7 @@ EOF
> >                       description = "initramfs";
> >                       data = /incbin/("${image_initramfs}");
> >                       type = "ramdisk";
> > +                     os = "linux";
> >                       compression = "none";
> >                       hash-1 {
> >                               algo = "sha256";
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> >
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de



-- 
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-11-13  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 15:23 avazquez.dev
2020-11-13  8:46 ` Michael Olbrich
2020-11-13  8:54   ` Guillermo Rodriguez Garcia [this message]
2020-11-13  8:57   ` Sascha Hauer
2020-11-13 15:02   ` Roland Hieber
2020-11-16  8:30   ` Alex Vazquez
2020-11-16  8:35     ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABDcavZYM4nUyc8e7MhrGroOQZGEgTEeZ2SdnoqYHZoOUzP1iw@mail.gmail.com \
    --to=guille.rodriguez@gmail.com \
    --cc=avazquez.dev@gmail.com \
    --cc=ptxdist@pengutronix.de \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox