From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <guille.rodriguez@gmail.com>) id 1XzSSC-00005U-DI
	for ptxdist@pengutronix.de; Fri, 12 Dec 2014 16:48:28 +0100
Received: by mail-wi0-f179.google.com with SMTP id ex7so3008252wid.0
	for <ptxdist@pengutronix.de>; Fri, 12 Dec 2014 07:48:22 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20141212102258.GH31594@pengutronix.de>
References: <CABDcavbkxDmsKJnM7TcBJr3LxhrmJgAVtP1UX1TWLibg8ifc8A@mail.gmail.com>
	<201412111146.47136.jbe@pengutronix.de>
	<CABDcavYpf6NtKus+Z9-+RRpmTfVzvCk=FZ6RUa_Mx-VyGe4b6A@mail.gmail.com>
	<20141212102258.GH31594@pengutronix.de>
Date: Fri, 12 Dec 2014 16:48:22 +0100
Message-ID: <CABDcavZY6vOxLHYuSvh0mL-v=r2FBVYEAGrQO6DuW0TphhugBg@mail.gmail.com>
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
Subject: Re: [ptxdist] Hardcoded path in pkg-config file
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>

Hi Michael,

2014-12-12 11:22 GMT+01:00 Michael Olbrich <m.olbrich@pengutronix.de>:
> Hi,
>
> On Thu, Dec 11, 2014 at 12:12:40PM +0100, Guillermo Rodriguez Garcia wrote:
>> 2014-12-11 11:46 GMT+01:00 Juergen Borleis <jbe@pengutronix.de>:
>> > Hi Guillermo,
>> >
>> > On Wednesday 10 December 2014 17:14:06 Guillermo Rodriguez Garcia wrote:
>> >> I am trying to port a package to ptxdist (libzip). This package
>> >> creates a pkg-config .pc file that contains some hardcoded paths.
>> >> During the install stage, it looks like ptxdist already does some
>> >> magic to "fix" the hardcoded paths (where is this done?), however not
>> >> all paths are fixed.
>> >>
>> >> Here's the .pc file that gets copied to sysroot-target:
>> >>
>> >> prefix=${pcfiledir}/../..
>> >> exec_prefix=${prefix}
>> >> libdir=${exec_prefix}/lib
>> >> includedir=${prefix}/include
>> >> libincludedir=/usr/lib/libzip/include
>> >> ^^^^^^^^^^^
>> >> [...]
>> >
>> > What is the difference between 'includedir' and 'libincludedir'?
>> > What kind of files does the install stage install to these locations?
>>
>> Apparently these are just two locations for header files. Here's the
>> complete .pc.in file:
>
> Yes, some packages have (generated) headers that are platform specific.
> Those are installed separately to handle multiarch correctly.
>
>> ===
>> prefix=@prefix@
>> exec_prefix=@exec_prefix@
>> libdir=@libdir@
>> includedir=@includedir@
>> libincludedir=@libdir@/@PACKAGE@/include
>
> Patch this to change this to:
>
> libincludedir=${libdir}/@PACKAGE@/include

Yes, thank you. At the end I followed a similar approach. But instead
of patching the sources, I am patching the generated .pc file in the
install.pack stage. I'll be submitting a patch for this in minutes, so
you can hopefully have a look and let me know if this is OK.

Thanks,

Guillermo

-- 
ptxdist mailing list
ptxdist@pengutronix.de