mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] u-boot: Add support for custom make options
Date: Fri, 14 Feb 2020 12:13:31 +0100	[thread overview]
Message-ID: <CABDcavYw+d_cqCZWgtOJ7=QfMGi7=Uxbip5rDOfy3xisHsEtWQ@mail.gmail.com> (raw)
In-Reply-To: <20200214110744.17260-1-guille.rodriguez@gmail.com>

Hi all,

A little explanation on this.

I need to pass DEVICE_TREE=xxx to uboot as this is the "official" way
to build u-boot for the stm32mp1 platform with a device tree other
than the board's default. I started preparing a patch to allow setting
a DEVICE_TREE value specifically, but there are other ways to do the
same, e.g. EXT_DTB to specify a precompiled device tree instead. So I
though perhaps a generic mechanism would be more useful. I also had a
look at buildroot and a similar (generic) mechanism exists as well, so
I ended up doing it like that.

Comments welcome.

Guillermo

El vie., 14 feb. 2020 a las 12:07, Guillermo Rodríguez
(<guille.rodriguez@gmail.com>) escribió:
>
> Add a generic mechanism to allow passing custom make options to
> U-boot. This can be used for example to pass a DEVICE_TREE= value.
>
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  platforms/u-boot.in | 7 +++++++
>  rules/u-boot.make   | 3 ++-
>  2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index 50fb008a3..491faed60 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -71,6 +71,13 @@ config U_BOOT_CONFIG
>
>  endif
>
> +config U_BOOT_CUSTOM_MAKE_OPTS
> +       prompt "Custom make options"
> +       string
> +       help
> +         List of custom make options passed at build time. Can be
> +         used for example to pass a DEVICE_TREE= value.
> +
>  choice
>         prompt "Generate environment image"
>         default U_BOOT_ENV_IMAGE_NONE
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index 0c6bccc71..e386dc4d2 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -55,7 +55,8 @@ U_BOOT_WRAPPER_BLACKLIST := \
>  U_BOOT_CONF_OPT                := \
>         -C $(U_BOOT_DIR) \
>         O=$(U_BOOT_BUILD_DIR) \
> -       V=$(PTXDIST_VERBOSE)
> +       V=$(PTXDIST_VERBOSE) \
> +       $(call remove_quotes,$(PTXCONF_U_BOOT_CUSTOM_MAKE_OPTS))
>
>  U_BOOT_MAKE_ENV                := \
>         CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \
> --
> 2.21.0
>


-- 
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-02-14 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 11:07 Guillermo Rodríguez
2020-02-14 11:13 ` Guillermo Rodriguez Garcia [this message]
2020-02-15  9:07   ` Michael Olbrich
2020-02-17  8:17     ` [ptxdist] [PATCH v2] " Guillermo Rodríguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABDcavYw+d_cqCZWgtOJ7=QfMGi7=Uxbip5rDOfy3xisHsEtWQ@mail.gmail.com' \
    --to=guille.rodriguez@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox