From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1Y9Xni-0000Fx-QZ for ptxdist@pengutronix.de; Fri, 09 Jan 2015 12:32:23 +0100 Received: by mail-we0-f175.google.com with SMTP id k11so7436849wes.6 for ; Fri, 09 Jan 2015 03:32:17 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <201412111146.47136.jbe@pengutronix.de> <20141212102258.GH31594@pengutronix.de> Date: Fri, 9 Jan 2015 12:32:16 +0100 Message-ID: From: Guillermo Rodriguez Garcia Subject: Re: [ptxdist] Hardcoded path in pkg-config file Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0012919993==" Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: "ptxdist@pengutronix.de" --===============0012919993== Content-Type: multipart/alternative; boundary=047d7bfcef3a46e175050c368237 --047d7bfcef3a46e175050c368237 Content-Type: text/plain; charset=UTF-8 Hi Michael, all, After this discussion I submitted patches for two new packages, libzip and fuse-zip. Have you had the chance to look at them? Any feedback is welcome. Thank you, Guillermo 2014-12-12 16:48 GMT+01:00 Guillermo Rodriguez Garcia < guille.rodriguez@gmail.com>: > Hi Michael, > > 2014-12-12 11:22 GMT+01:00 Michael Olbrich : > > Hi, > > > > On Thu, Dec 11, 2014 at 12:12:40PM +0100, Guillermo Rodriguez Garcia > wrote: > >> 2014-12-11 11:46 GMT+01:00 Juergen Borleis : > >> > Hi Guillermo, > >> > > >> > On Wednesday 10 December 2014 17:14:06 Guillermo Rodriguez Garcia > wrote: > >> >> I am trying to port a package to ptxdist (libzip). This package > >> >> creates a pkg-config .pc file that contains some hardcoded paths. > >> >> During the install stage, it looks like ptxdist already does some > >> >> magic to "fix" the hardcoded paths (where is this done?), however not > >> >> all paths are fixed. > >> >> > >> >> Here's the .pc file that gets copied to sysroot-target: > >> >> > >> >> prefix=${pcfiledir}/../.. > >> >> exec_prefix=${prefix} > >> >> libdir=${exec_prefix}/lib > >> >> includedir=${prefix}/include > >> >> libincludedir=/usr/lib/libzip/include > >> >> ^^^^^^^^^^^ > >> >> [...] > >> > > >> > What is the difference between 'includedir' and 'libincludedir'? > >> > What kind of files does the install stage install to these locations? > >> > >> Apparently these are just two locations for header files. Here's the > >> complete .pc.in file: > > > > Yes, some packages have (generated) headers that are platform specific. > > Those are installed separately to handle multiarch correctly. > > > >> === > >> prefix=@prefix@ > >> exec_prefix=@exec_prefix@ > >> libdir=@libdir@ > >> includedir=@includedir@ > >> libincludedir=@libdir@/@PACKAGE@/include > > > > Patch this to change this to: > > > > libincludedir=${libdir}/@PACKAGE@/include > > Yes, thank you. At the end I followed a similar approach. But instead > of patching the sources, I am patching the generated .pc file in the > install.pack stage. I'll be submitting a patch for this in minutes, so > you can hopefully have a look and let me know if this is OK. > > Thanks, > > Guillermo > -- Guillermo Rodriguez Garcia guille.rodriguez@gmail.com --047d7bfcef3a46e175050c368237 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Michael, all,

After this discussion I sub= mitted patches for two new packages, libzip and fuse-zip. Have you had the = chance to look at them? Any feedback is welcome.

Thank = you,

Guillermo
2014-12-12 16:48 GMT+01:00 Guillermo Rodriguez= Garcia <guille.rodriguez@gmail.com>:
Hi Michael,

2014-12-12 11:22 GMT+01:00 Michael Olbrich <m.olbrich@pengutronix.de>:
> Hi,
>
> On Thu, Dec 11, 2014 at 12:12:40PM +0100, Guillermo Rodriguez Garcia w= rote:
>> 2014-12-11 11:46 GMT+01:00 Juergen Borleis <jbe@pengutronix.de>:
>> > Hi Guillermo,
>> >
>> > On Wednesday 10 December 2014 17:14:06 Guillermo Rodriguez Ga= rcia wrote:
>> >> I am trying to port a package to ptxdist (libzip). This p= ackage
>> >> creates a pkg-config .pc file that contains some hardcode= d paths.
>> >> During the install stage, it looks like ptxdist already d= oes some
>> >> magic to "fix" the hardcoded paths (where is th= is done?), however not
>> >> all paths are fixed.
>> >>
>> >> Here's the .pc file that gets copied to sysroot-targe= t:
>> >>
>> >> prefix=3D${pcfiledir}/../..
>> >> exec_prefix=3D${prefix}
>> >> libdir=3D${exec_prefix}/lib
>> >> includedir=3D${prefix}/include
>> >> libincludedir=3D/usr/lib/libzip/include
>> >> ^^^^^^^^^^^
>> >> [...]
>> >
>> > What is the difference between 'includedir' and '= libincludedir'?
>> > What kind of files does the install stage install to these lo= cations?
>>
>> Apparently these are just two locations for header files. Here'= ;s the
>> complete .pc.in fil= e:
>
> Yes, some packages have (generated) headers that are platform specific= .
> Those are installed separately to handle multiarch correctly.
>
>> =3D=3D=3D
>> prefix=3D@prefix@
>> exec_prefix=3D@exec_prefix@
>> libdir=3D@libdir@
>> includedir=3D@includedir@
>> libincludedir=3D@libdir@/@PACKAGE@/include
>
> Patch this to change this to:
>
> libincludedir=3D${libdir}/@PACKAGE@/include

Yes, thank you. At the end I followed a similar approach. But i= nstead
of patching the sources, I am patching the generated .pc file in the
install.pack stage. I'll be submitting a patch for this in minutes, so<= br> you can hopefully have a look and let me know if this is OK.

Thanks,

Guillermo



--
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com
--047d7bfcef3a46e175050c368237-- --===============0012919993== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ptxdist mailing list ptxdist@pengutronix.de --===============0012919993==--