From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1gNoY5-0000g4-PS for ptxdist@pengutronix.de; Sat, 17 Nov 2018 01:33:22 +0100 Received: by mail-wm1-x344.google.com with SMTP id r11-v6so226619wmb.2 for ; Fri, 16 Nov 2018 16:33:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20181116170101.zauvjheidv4swnli@pengutronix.de> References: <1542367218-2735-1-git-send-email-guille.rodriguez@gmail.com> <20181116170101.zauvjheidv4swnli@pengutronix.de> From: Guillermo Rodriguez Garcia Date: Sat, 17 Nov 2018 01:33:19 +0100 Message-ID: Subject: Re: [ptxdist] [PATCH] classpath: Fix for building with OpenJDK-1.8 (again) List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0994438890==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: "ptxdist@pengutronix.de" --===============0994438890== Content-Type: multipart/alternative; boundary="0000000000004424a6057ad16e0d" --0000000000004424a6057ad16e0d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El viernes, 16 de noviembre de 2018, Michael Olbrich < m.olbrich@pengutronix.de> escribi=C3=B3: > On Fri, Nov 16, 2018 at 12:20:18PM +0100, Guillermo Rodr=C3=ADguez wrote: > > Commit bbc978e623cafc added a patch intended to fix building > > with OpenJDK 1.8, however that commit was not complete. It is > > necessary to run autogen.sh so that the configure script is > > regenerated and the patched m4 macros are used. > > > > Signed-off-by: Guillermo Rodriguez > > Unfortunately it's not that simple. The */Makefile.am also need the > 1.5 -> 1.6 change. I tried that an then I get lots of errors like this: > > warning: as of release 9, '_' is a keyword, and may not be used as an > identifier Uhm, those are not errors, they are warnings (as long as we specify -target < 9, which is the case here). Anyway from these messages it looks like you are building with OpenJDK9? That is not supposed to work; the intent of the patch was to allow building with OpenJDK8... can you check the version of javac? Guillermo > > Michael > > > --- > > patches/classpath-0.99/autogen.sh | 2 ++ > > rules/classpath.in | 1 + > > 2 files changed, 3 insertions(+) > > create mode 100755 patches/classpath-0.99/autogen.sh > > > > diff --git a/patches/classpath-0.99/autogen.sh b/patches/classpath-0.99= / > autogen.sh > > new file mode 100755 > > index 0000000..9ca025f > > --- /dev/null > > +++ b/patches/classpath-0.99/autogen.sh > > @@ -0,0 +1,2 @@ > > +#!/bin/bash > > +exec ./autogen.sh > > diff --git a/rules/classpath.in b/rules/classpath.in > > index 16017b2..271a917 100644 > > --- a/rules/classpath.in > > +++ b/rules/classpath.in > > @@ -5,6 +5,7 @@ config CLASSPATH > > prompt "classpath" > > select GCCLIBS_GCC_S > > select HOST_SYSTEM_JDK > > + select HOST_GETTEXT > > help > > GNU Classpath, Essential Libraries for Java, is a GNU project t= o > create > > free core class libraries for use with virtual machines and > compilers > > -- > > 1.9.1 > > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > -- > Pengutronix e.K. | = | > Industrial Linux Solutions | http://www.pengutronix.de/ = | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 = | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de --=20 Guillermo Rodriguez Garcia guille.rodriguez@gmail.com --0000000000004424a6057ad16e0d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

El viernes, 16 de noviembre de 2018, Michael Olbrich <m.olbrich@pengutronix.de> escribi= =C3=B3:
On Fri, Nov 16, 2018 at 12:20:18P= M +0100, Guillermo Rodr=C3=ADguez wrote:
> Commit bbc978e623cafc added a patch intended to fix building
> with OpenJDK 1.8, however that commit was not complete. It is
> necessary to run autogen.sh so that the configure script is
> regenerated and the patched m4 macros are used.
>
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>

Unfortunately it's not that simple. The */Makefile.am also need the
1.5 -> 1.6 change. I tried that an then I get lots of errors like this:<= br>
warning: as of release 9, '_' is a keyword, and may not be used as = an
identifier

Uhm, those are not errors, they = are warnings (as long as we specify -target < 9, which is the case here)= . Anyway from these messages it looks like you are building with OpenJDK9? = That is not supposed to work; the intent of the patch was to allow building= with OpenJDK8... can you check the version of javac?

<= div>Guillermo

=C2=A0

Michael

> ---
>=C2=A0 patches/classpath-0.99/autogen.sh | 2 ++
>=C2=A0 rules/classpat= h.in=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 1 +
>=C2=A0 2 files changed, 3 insertions(+)
>=C2=A0 create mode 100755 patches/classpath-0.99/autogen.sh
>
> diff --git a/patches/classpath-0.99/autogen.sh b/patches/classpat= h-0.99/autogen.sh
> new file mode 100755
> index 0000000..9ca025f
> --- /dev/null
> +++ b/patches/classpath-0.99/autogen.sh
> @@ -0,0 +1,2 @@
> +#!/bin/bash
> +exec ./autogen.sh
> diff --git a/rules/c= lasspath.in b/rules/c= lasspath.in
> index 16017b2..271a917 100644
> --- a/rules/classpat= h.in
> +++ b/rules/classpat= h.in
> @@ -5,6 +5,7 @@ config CLASSPATH
>=C2=A0 =C2=A0 =C2=A0 =C2=A0prompt "classpath"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0select GCCLIBS_GCC_S
>=C2=A0 =C2=A0 =C2=A0 =C2=A0select HOST_SYSTEM_JDK
> +=C2=A0 =C2=A0 =C2=A0select HOST_GETTEXT
>=C2=A0 =C2=A0 =C2=A0 =C2=A0help
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GNU Classpath, Essential Libraries fo= r Java, is a GNU project to create
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free core class libraries for use wit= h virtual machines and compilers
> --
> 1.9.1
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|
Industrial Linux Solutions=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| htt= p://www.pengutronix.de/=C2=A0 |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0=C2=A0= =C2=A0 |
Amtsgericht Hildesheim, HRA 2686=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = Fax:=C2=A0 =C2=A0+49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

--
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com
--0000000000004424a6057ad16e0d-- --===============0994438890== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============0994438890==--