mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] classpath: Fix for building with OpenJDK-1.8 (again)
Date: Sat, 17 Nov 2018 01:33:19 +0100	[thread overview]
Message-ID: <CABDcavYb7KkMPNzq2Z4P3NDHzPmPp8m6Cs=V4YbNWyh5A5Rscg@mail.gmail.com> (raw)
In-Reply-To: <20181116170101.zauvjheidv4swnli@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 2700 bytes --]

El viernes, 16 de noviembre de 2018, Michael Olbrich <
m.olbrich@pengutronix.de> escribió:

> On Fri, Nov 16, 2018 at 12:20:18PM +0100, Guillermo Rodríguez wrote:
> > Commit bbc978e623cafc added a patch intended to fix building
> > with OpenJDK 1.8, however that commit was not complete. It is
> > necessary to run autogen.sh so that the configure script is
> > regenerated and the patched m4 macros are used.
> >
> > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
>
> Unfortunately it's not that simple. The */Makefile.am also need the
> 1.5 -> 1.6 change. I tried that an then I get lots of errors like this:
>
> warning: as of release 9, '_' is a keyword, and may not be used as an
> identifier


Uhm, those are not errors, they are warnings (as long as we specify -target
< 9, which is the case here). Anyway from these messages it looks like you
are building with OpenJDK9? That is not supposed to work; the intent of the
patch was to allow building with OpenJDK8... can you check the version of
javac?

Guillermo



>
> Michael
>
> > ---
> >  patches/classpath-0.99/autogen.sh | 2 ++
> >  rules/classpath.in                | 1 +
> >  2 files changed, 3 insertions(+)
> >  create mode 100755 patches/classpath-0.99/autogen.sh
> >
> > diff --git a/patches/classpath-0.99/autogen.sh b/patches/classpath-0.99/
> autogen.sh
> > new file mode 100755
> > index 0000000..9ca025f
> > --- /dev/null
> > +++ b/patches/classpath-0.99/autogen.sh
> > @@ -0,0 +1,2 @@
> > +#!/bin/bash
> > +exec ./autogen.sh
> > diff --git a/rules/classpath.in b/rules/classpath.in
> > index 16017b2..271a917 100644
> > --- a/rules/classpath.in
> > +++ b/rules/classpath.in
> > @@ -5,6 +5,7 @@ config CLASSPATH
> >       prompt "classpath"
> >       select GCCLIBS_GCC_S
> >       select HOST_SYSTEM_JDK
> > +     select HOST_GETTEXT
> >       help
> >         GNU Classpath, Essential Libraries for Java, is a GNU project to
> create
> >         free core class libraries for use with virtual machines and
> compilers
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de



-- 
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

[-- Attachment #1.2: Type: text/html, Size: 3935 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-11-17  0:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 11:20 Guillermo Rodríguez
2018-11-16 17:01 ` Michael Olbrich
2018-11-17  0:33   ` Guillermo Rodriguez Garcia [this message]
2018-11-17 13:49     ` Michael Olbrich
2018-11-19  9:30       ` Guillermo Rodriguez Garcia
2018-11-22  5:57         ` Michael Olbrich
2018-11-20 15:51 ` [ptxdist] [PATCH v2 1/2] " Guillermo Rodríguez
2018-11-20 15:51   ` [ptxdist] [PATCH v2 2/2] classpath: Fix building when default locale is not UTF-8 Guillermo Rodríguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABDcavYb7KkMPNzq2Z4P3NDHzPmPp8m6Cs=V4YbNWyh5A5Rscg@mail.gmail.com' \
    --to=guille.rodriguez@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox