mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] classpath: Fix building with OpenJDK 1.8
Date: Fri, 16 Nov 2018 12:18:45 +0100	[thread overview]
Message-ID: <CABDcavYKTyD6BYvk9TnjAMyDXM5JyFLFK8bkX1fGJovTT1oYZA@mail.gmail.com> (raw)
In-Reply-To: <20181116080746.6canaq6qwv6erbh3@pengutronix.de>

Hi Michael,

El vie., 16 nov. 2018 a las 9:08, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> Hi,
> On Thu, Nov 08, 2018 at 05:26:11PM +0100, Guillermo Rodriguez Garcia wrote:
> > Any feedback on this one ?
>
> I was just waiting to get the release out of the door. I've applied this
> now. It build on must of my test setups, so it gets enough test coverage to
> notice if the build fails.
> Note that on my Debian testing machine, configure fails with:
>
> configure:24594: checking if /usr/lib/jvm/default-java/bin/javac works
> configure:24619: /usr/lib/jvm/default-java/bin/javac  -source 1.5 -target 1.5 Object.java
> warning: [options] bootstrap class path not set in conjunction with -source 5
> error: Source option 5 is no longer supported. Use 6 or later.
> error: Target option 1.5 is no longer supported. Use 1.6 or later.

OK it seems that my patch was not complete. With my changes properly
applied, the m4 macros should be using 1.6 and not 1.5.
autogen.sh must be run so that the configure script is regenerated. I
missed this when I submitted the patch. Sorry for that.

I am sending a new patch to fix this.

Best,

Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2018-11-16 11:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 15:12 Guillermo Rodríguez
2018-11-08 16:26 ` Guillermo Rodriguez Garcia
2018-11-16  8:07   ` Michael Olbrich
2018-11-16 11:18     ` Guillermo Rodriguez Garcia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABDcavYKTyD6BYvk9TnjAMyDXM5JyFLFK8bkX1fGJovTT1oYZA@mail.gmail.com \
    --to=guille.rodriguez@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox