mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] tf-a: new package for ARM trusted firmware A
Date: Tue, 18 Feb 2020 10:02:57 +0100	[thread overview]
Message-ID: <CABDcavY3VX1G-QiC1Pp1GVKKK+NC6mscA9P+Yp+y0P8pWq9z9A@mail.gmail.com> (raw)
In-Reply-To: <20200218073523.4pyo2e3b5sugb6wr@pengutronix.de>

El mar., 18 feb. 2020 a las 8:36, Michael Olbrich
(<m.olbrich@pengutronix.de>) escribió:
>
> On Mon, Feb 17, 2020 at 05:33:57PM +0100, Guillermo Rodriguez Garcia wrote:
> > El lun., 17 feb. 2020 a las 17:26, Michael Tretter
> > (<m.tretter@pengutronix.de>) escribió:
> > >
> > > On Wed, 12 Feb 2020 17:40:33 +0100, Ahmad Fatoum wrote:
> > > > Trusted Firmware-A (TF-A) is a reference implementation of secure world
> > > > software for Arm A-Profile architectures (Armv8-A and Armv7-A).
> > >
> > > I successfully built the TF-A BL31 for the ZynqMP using this rule.
> > >
> > > However, I saw that the TF-A build uses the current git commitish for
> > > BUILD_STRING, which will be written into the binary. If I build the
> > > TF-A with this rule, this ends up to be the commitish of the BSP. I'm
> > > not sure if I actually want this, but I don't know what to put there
> > > instead.
> >
> > Since we finally agreed to keep TF_A_EXTRA_ARGS in the final TF-A rule
> > files, you can actually set BUILD_STRING to anything you want. Just
> > include BUILD_STRING=whatever in the TF_A_EXTRA_ARGS parameter.
>
> There should always be a default BUILD_STRING that does not depend on the
> BSP commit-ish. $(TF_A_VERSION) probably.

OK, then we could add this to the .make file:

TF_A_MAKE_OPT        := \
    CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \
    HOSTCC=$(HOSTCC) \
    PLAT=$(PTXCONF_TF_A_PLATFORM) \
    ARCH=$(PTXCONF_TF_A_ARCH_STRING) \
    ARM_ARCH_MAJOR=$(PTXCONF_TF_A_ARM_ARCH_MAJOR) \
    BUILD_STRING=$(PTXCONF_TF_A_VERSION) \
    $(call remove_quotes,$(PTXCONF_TF_A_EXTRA_ARGS)) \
    all

BUILD_STRING can still be overriden in TF_A_EXTRA_ARGS if needed.

Guillermo

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-02-18  9:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 16:40 Ahmad Fatoum
2020-02-13 12:59 ` Guillermo Rodriguez Garcia
2020-02-13 13:30   ` Ahmad Fatoum
2020-02-13 14:25     ` Guillermo Rodriguez Garcia
2020-02-13 14:28       ` Ahmad Fatoum
2020-02-13 14:32         ` Ahmad Fatoum
2020-02-13 14:35           ` Guillermo Rodriguez Garcia
2020-02-13 14:44             ` Ahmad Fatoum
2020-02-13 14:49               ` Ahmad Fatoum
2020-02-13 15:05               ` Guillermo Rodriguez Garcia
2020-02-13 15:08                 ` Ahmad Fatoum
2020-02-13 15:24                   ` Guillermo Rodriguez Garcia
2020-02-13 15:27                     ` Ahmad Fatoum
2020-02-13 15:33                       ` Guillermo Rodriguez Garcia
2020-02-14 10:57                         ` Alex Vazquez
2020-02-14 13:19 ` Michael Olbrich
2020-02-19 10:10   ` Ahmad Fatoum
2020-02-17 16:25 ` Michael Tretter
2020-02-17 16:33   ` Guillermo Rodriguez Garcia
2020-02-18  7:35     ` Michael Olbrich
2020-02-18  9:02       ` Guillermo Rodriguez Garcia [this message]
2020-02-19  7:48         ` Michael Tretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABDcavY3VX1G-QiC1Pp1GVKKK+NC6mscA9P+Yp+y0P8pWq9z9A@mail.gmail.com \
    --to=guille.rodriguez@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox