El jue., 14 nov. 2019 a las 12:18, Roland Hieber (<rhi@pengutronix.de>) escribió:
On Thu, Nov 14, 2019 at 11:07:16AM +0100, Guillermo Rodriguez Garcia wrote:
> El jue., 14 nov. 2019 a las 10:56, Roland Hieber (<rhi@pengutronix.de>)
> escribió:
>
> > > > numpy/core/src/multiarray/dragon4.c seems to be a license found nowhere
> > > > else, so I would also add "AND UNKNOWN" to PYTHON3_NUMPY_LICENSE and
> > add
> > > > its verbatim license text with startline and endline parameters in
> > > > PYTHON3_NUMPY_LICENSE_FILES. PTXdist extracts all those license
> > > > texts mentioned in that variable and adds them to the license report,
> > > > so it doesn't get lost too :)
> >
>
> On re-reading this: The license in dragon4.c is just MIT. So while it is OK
> to add it to LICENSE_FILES I think we should not add the "AND unknown" bit.

Oh. I just blindly believed LICENSE.txt. But now that you say it, my
license matcher identifies it as "Zlib", not as "MIT".

Uhm, doesn't look like Zlib to me; here's the license text extracted from dragon4.c:

/*
 * Copyright (c) 2014 Ryan Juckett
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to
 * deal in the Software without restriction, including without limitation the
 * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
 * sell copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 */

And here are the MIT and Zlib licenses:


I would say that the license is indeed MIT, which is what LICENSE.txt says:

Name: dragon4
Files: numpy/core/src/multiarray/dragon4.c
License: MIT
  For license text, see numpy/core/src/multiarray/dragon4.c


BR,
 
Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com