From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j8nMe-0007Kg-CO for ptxdist@pengutronix.de; Mon, 02 Mar 2020 16:52:17 +0100 Received: by mail-oi1-x243.google.com with SMTP id b18so10771261oie.2 for ; Mon, 02 Mar 2020 07:52:16 -0800 (PST) MIME-Version: 1.0 References: <20200226174555.GA23059@pengutronix.de> In-Reply-To: <20200226174555.GA23059@pengutronix.de> From: Sandy Patterson Date: Mon, 2 Mar 2020 10:52:03 -0500 Message-ID: Subject: Re: [ptxdist] [PATCH] kernel-headers: build out-of-tree List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0155263871==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de, Michael Olbrich --===============0155263871== Content-Type: multipart/alternative; boundary="000000000000c866da059fe12bd9" --000000000000c866da059fe12bd9 Content-Type: text/plain; charset="UTF-8" Sure thing, V2 coming, thanks for the pointers. On Wed, Feb 26, 2020 at 12:46 PM Michael Olbrich wrote: > On Tue, Feb 25, 2020 at 10:20:34AM -0500, Sandy Patterson wrote: > > I am not sure if the following patch is what was intended with the change > > to OOT=KEEP change for kernel. We have a folder within our BSP with a > > kernel tree and we symlink to that folder using local_src/kernel. > > and local_src/kernel-header.. > > > > We use an external kernel source tree and kernel headers from the same > > folder. It seems with our kernel at least building the kernel-headers in > > tree causes the out-of-tree kernel to fail to build. > > It's a valid use-case. Can you make the commit message a bit more generic > (no 'we' or 'I' but a general description of the use-case). > > Also, the signed-of-by is missing. > > And something (probably your mail program) broke the patch. There are a lot > of descriptions online, on how to send patches with various mail programs. > If that doesn't work then a patch as attachment is ok as well. > > Michael > > > --- > > rules/kernel-header.make | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/rules/kernel-header.make b/rules/kernel-header.make > > index c173eb74b..6f540409f 100644 > > --- a/rules/kernel-header.make > > +++ b/rules/kernel-header.make > > @@ -25,8 +25,10 @@ KERNEL_HEADER_URL := > > https://git.kernel.org/torvalds/t/$(KERNEL_HEADER).$(KERNE > > endif > > KERNEL_HEADER_SOURCE := > > $(SRCDIR)/linux-$(KERNEL_HEADER_VERSION).$(KERNEL_HEADER_SUFFIX) > > KERNEL_HEADER_DIR := $(BUILDDIR)/kernel-header-$(KERNEL_HEADER_VERSION) > > +KERNEL_HEADER_BUILD_DIR := $(KERNEL_HEADER_DIR)-build > > KERNEL_HEADER_PKGDIR := $(PKGDIR)/kernel-header-$(KERNEL_HEADER_VERSION) > > KERNEL_HEADER_LICENSE := GPL-2.0-only > > +KERNEL_HEADER_BUILD_OOT := KEEP > > > > # > > > ---------------------------------------------------------------------------- > > # Prepare > > @@ -37,6 +39,7 @@ KERNEL_HEADER_PATH := PATH=$(CROSS_PATH) > > KERNEL_HEADER_CONF_TOOL := NO > > KERNEL_HEADER_MAKE_OPT := \ > > V=$(PTXDIST_VERBOSE) \ > > + O=$(KERNEL_HEADER_BUILD_DIR) \ > > HOSTCC=$(HOSTCC) \ > > ARCH=$(GENERIC_KERNEL_ARCH) \ > > CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX) > > -- > > 2.20.1 > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > --000000000000c866da059fe12bd9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure thing, V2 coming, thanks for the pointers.

<= div class=3D"gmail_quote">
On Wed, Feb= 26, 2020 at 12:46 PM Michael Olbrich <m.olbrich@pengutronix.de> wrote:
On Tue, Feb 25, 2020 at 10:20:34AM -0500= , Sandy Patterson wrote:
> I am not sure if the following patch is what was intended with the cha= nge
> to OOT=3DKEEP change for kernel. We have a folder within our BSP with = a
> kernel tree and we symlink to that folder using local_src/kernel.
> <platformname> and local_src/kernel-header.<platformname>.=
>
> We use an external kernel source tree and kernel headers from the same=
> folder. It seems with our kernel at least building the kernel-headers = in
> tree causes the out-of-tree kernel to fail to build.

It's a valid use-case. Can you make the commit message a bit more gener= ic
(no 'we' or 'I' but a general description of the use-case).=

Also, the signed-of-by is missing.

And something (probably your mail program) broke the patch. There are a lot=
of descriptions online, on how to send patches with various mail programs.<= br> If that doesn't work then a patch as attachment is ok as well.

Michael

> ---
>=C2=A0 rules/kernel-header.make | 3 +++
>=C2=A0 1 file changed, 3 insertions(+)
>
> diff --git a/rules/kernel-header.make b/rules/kernel-header.make
> index c173eb74b..6f540409f 100644
> --- a/rules/kernel-header.make
> +++ b/rules/kernel-header.make
> @@ -25,8 +25,10 @@ KERNEL_HEADER_URL :=3D
> https://git.kernel.org/torvalds/t/$(K= ERNEL_HEADER).$(KERNE
>=C2=A0 endif
>=C2=A0 KERNEL_HEADER_SOURCE :=3D
> $(SRCDIR)/linux-$(KERNEL_HEADER_VERSION).$(KERNEL_HEADER_SUFFIX)
>=C2=A0 KERNEL_HEADER_DIR :=3D $(BUILDDIR)/kernel-header-$(KERNEL_HEADER= _VERSION)
> +KERNEL_HEADER_BUILD_DIR :=3D $(KERNEL_HEADER_DIR)-build
>=C2=A0 KERNEL_HEADER_PKGDIR :=3D $(PKGDIR)/kernel-header-$(KERNEL_HEADE= R_VERSION)
>=C2=A0 KERNEL_HEADER_LICENSE :=3D GPL-2.0-only
> +KERNEL_HEADER_BUILD_OOT :=3D KEEP
>
>=C2=A0 #
> ----------------------------------------------------------------------= ------
>=C2=A0 # Prepare
> @@ -37,6 +39,7 @@ KERNEL_HEADER_PATH :=3D PATH=3D$(CROSS_PATH)
>=C2=A0 KERNEL_HEADER_CONF_TOOL :=3D NO
>=C2=A0 KERNEL_HEADER_MAKE_OPT :=3D \
>=C2=A0 =C2=A0V=3D$(PTXDIST_VERBOSE) \
> + O=3D$(KERNEL_HEADER_BUILD_DIR) \
>=C2=A0 =C2=A0HOSTCC=3D$(HOSTCC) \
>=C2=A0 =C2=A0ARCH=3D$(GENERIC_KERNEL_ARCH) \
>=C2=A0 =C2=A0CROSS_COMPILE=3D$(PTXCONF_COMPILER_PREFIX)
> --
> 2.20.1

> _______________________________________________
> ptxdist mailing list
> ptxdist@pe= ngutronix.de


--
Pengutronix e.K.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|
Steuerwalder Str. 21=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0| http://www.pengutronix.de/=C2=A0 |
31137 Hildesheim, Germany=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 | Phone: +49-5121-206917-0=C2=A0 =C2=A0 |
Amtsgericht Hildesheim, HRA 2686=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = Fax:=C2=A0 =C2=A0+49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutr= onix.de
--000000000000c866da059fe12bd9-- --===============0155263871== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de --===============0155263871==--