mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Richard OGrady <Rich_Ogrady@grayhill.com>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] pkg-config-wrapper
Date: Mon, 10 Oct 2022 14:11:43 +0000	[thread overview]
Message-ID: <BYAPR14MB3078483CBD9C807ED516F7BBF0209@BYAPR14MB3078.namprd14.prod.outlook.com> (raw)
In-Reply-To: <20221007152838.GK26936@pengutronix.de>



> -----Original Message-----
> From: Michael Olbrich <m.olbrich@pengutronix.de>
> Sent: Friday, October 7, 2022 10:29 AM
> To: Richard OGrady <Rich_Ogrady@grayhill.com>
> Cc: ptxdist@pengutronix.de
> Subject: Re: [ptxdist] pkg-config-wrapper
> 
> On Fri, Oct 07, 2022 at 02:43:51PM +0000, Richard OGrady wrote:
> > > On Wed, Oct 05, 2022 at 08:44:44PM +0000, Richard OGrady wrote:
> > > > Debugging a prepare stage issue so trying to understand this chunk of code in pkg-config-wrapper.
> > > >
> > > > for pkg in ${pkgs}; do
> > > >    if [[ ! " ${whitelist} " =~ " ${pkg} " && ! "${pkg}" =~ '-uninstalled' ]]; then
> > > >       echo "$(basename ${0}): warning: blocking '${pkg}': not
> > > > selected by
> > > '${PKGCONFIG_WHITELIST_SRC}'" >&${ERROR_FD}
> > > >       exit 1
> > > >   fi
> > > > done
> > > >
> > > > Where does ${whitelist} come from?  Have tried to trace this back
> > > > and best guess is it may come
> > > from ../state/${PKGCONFIG_WHITELIST_SRC}. pkgconfig .
> > > >
> > > > If this is the case, perhaps pkg-config-wrapper can't be used
> > > > during prepare as the .pkgconfig file isn't there yet?
> > >
> > > ${whitelist} is defined as PKGCONFIG_WHITELIST_HOST or
> > > PKGCONFIG_WHITELIST_TARGET depending on whether the host or cross
> > > pkgconfig is called. For example PKGCONFIG_WHITELIST_HOST is used by when the Linux kernel looks for openssl to build a host tool.
> > >
> > > These variables are filled by the .pkgconfig files from all packages
> > > that are selected in the .in file. So those are already available during the prepare stage.
> >
> > I think this is where I am having a problem.  My file
> > gstreamer2-imx.in
> > select(s) the dependency libimxdmabuffer.  My file libimxdmabuffer.in
> > only select(s) the dependency HOST_SYSTEM_PYTHON3 and its pkgconfig
> > file is empty as expected.  So the dependency libimxdmabuffer isn't in
> > PKGCONFIG_WHITELIST_TARGET when gstreamer2-imx is prepared and the
> > pkg-config-wrapper blocks it.
> >
> > From your description it seems that primary dependencies (like
> > libimxdmabuffer) are not in PKGCONFIG_WHITELIST_TARGET.  Is that the
> > case? I would think this is a common scenario so I must still be
> > missing something.
> 
> When you build gstreamer2-imx, then libimxdmabuffer should be in PKGCONFIG_WHITELIST_TARGET.
> But please note, that PKGCONFIG_WHITELIST_TARGET does not contain the ptxdist package names but
> the .pc file names without the .pc suffix.
> And the .pkgconfig of libimxdmabuffer should contain something. Is the file empty or is it not
> generated at all? What's the output of:
> 
> find platform-<your-platform>/packages/libimxdmabuffer-<version>/ -name *.pc
> 
> Replace the path with the directory that is filled by libimxdmabuffer.
> 
> Michael
> 
That is the problem.  The .pc file did not exist.  That package is a waf configure/build/install.  
To fix I needed to explicitly add --destdir to the install command.  It works now.
Thank you.

Rich OGrady



      reply	other threads:[~2022-10-10 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BYAPR14MB30787CFC6DF335A2C40F501CF05B9@BYAPR14MB3078.namprd14.prod.outlook.com>
2022-10-03 20:43 ` [ptxdist] pkg-config-wrapper issue Ladislav Michl
2022-10-04 13:57   ` Richard OGrady
     [not found] ` <MN2PR14MB30871631A8122DDEA101C69BF05D9@MN2PR14MB3087.namprd14.prod.outlook.com>
2022-10-07  7:37   ` [ptxdist] pkg-config-wrapper Michael Olbrich
     [not found]     ` <BYAPR14MB307877E0F9AF8D0E8C4D545CF05F9@BYAPR14MB3078.namprd14.prod.outlook.com>
2022-10-07 15:28       ` Michael Olbrich
2022-10-10 14:11         ` Richard OGrady [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR14MB3078483CBD9C807ED516F7BBF0209@BYAPR14MB3078.namprd14.prod.outlook.com \
    --to=rich_ogrady@grayhill.com \
    --cc=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox