Re: [ptxdist] [PATCH 23/23] xorg-fonts: make all xorg-font-ttf packages tristate

["Baeuerle, Florian" <Florian.Baeuerle@allegion.com>]

Am Donnerstag, den 02.08.2018, 08:52 +0000 schrieb Baeuerle, Florian:
> Am Mittwoch, den 01.08.2018, 20:32 +0200 schrieb Florian Bäuerle:
> > [...]
> > 
> > diff --git a/rules/graphics_and_multimedia.in b/rules/graphics_and_multimedia.in
> > index 54e53ad7a..f96a381e3 100644
> > --- a/rules/graphics_and_multimedia.in
> > +++ b/rules/graphics_and_multimedia.in
> > @@ -1,7 +1,7 @@
> >  ## SECTION=graphics_and_multimedia
> >  
> >  menuconfig MENU_XORG_FONTS
> > -	bool
> > +	tristate
> 
> not so sure, this selects XORG_FONT_ALIAS and FONTCONFIG_UTILS which may not
> be required if a collection does not select any fonts...

I mean if it were bool, the above would apply.

> 
> >  	prompt "fonts                         "
> >  	select XORG_LIB_XFONT_PCF_FONTS if XORG_SERVER
> >  	default y if XORG_SERVER
> > @@ -13,7 +13,7 @@ if MENU_XORG_FONTS
> >  
> >  config XORG_FONTS
> >  	depends on MENU_XORG_FONTS
> > -	bool
> > +	tristate
> 
> same here
> 
> >  	select XORG_FONT_UTIL
> 
> XORG_FONT_UTIL btw. seems broken to me. No package is being produced and no trace
> of the package can be found on the target rootfs.
> 
> >  	select XORG_FONT_ALIAS
> >  	select HOST_XORG_APP_MKFONTDIR
> > @@ -25,7 +25,7 @@ config XORG_FONTS
> >  config XORG_FONTS_FC_CACHE
> >  	default FONTCONFIG
> >  	select FONTCONFIG_UTILS
> > -	bool
> > +	tristate
> >  
> >  config XORG_FONTS_QT4_LINKS
> >  	depends on QT4_PLATFORM_EMBEDDED
> > [...]
> > +++ b/rules/xorg-font-ttf.in
> > @@ -3,7 +3,7 @@
> >  menuconfig XORG_FONT_TTF
> >  	depends on MENU_XORG_FONTS
> >  	select XORG_LIB_XFONT_FREETYPE if XORG_LIB_XFONT
> > -	bool
> > +	tristate
> 
> unnecessary
> 
> >  	prompt "xorg true/open type fonts     "
> >  
> >  source "generated/multimedia_xorg_font_ttf.in"
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de