Re: [ptxdist] [PATCH 2/2] u-boot: Allow generation of boot script

[Alexander Dahl <ada@thorsis.com>]

Hello,

Am Freitag, 12. April 2019, 16:09:56 CEST schrieb Michael Olbrich:
> On Fri, Apr 12, 2019 at 03:17:33PM +0200, Alexander Dahl wrote:
> > Am Freitag, 12. April 2019, 09:49:18 CEST schrieb Michael Olbrich:
> > > On Thu, Apr 11, 2019 at 01:09:37PM +0200, Alexander Dahl wrote:
> > > >  #
> > > >  ---------------------------------------------------------------------
> > > >  ---
> > > >  ---->
> > > > 
> > > > +# Compile
> > > > +#
> > > > ----------------------------------------------------------------------
> > > > ---
> > > > --- +
> > > > +$(STATEDIR)/u-boot.compile:
> > > > +	@$(call targetinfo)
> > > > +	@$(call world/compile, U_BOOT)
> > > > +ifdef PTXCONF_U_BOOT_BOOT_SCRIPT
> > > > +	@$(U_BOOT_DIR)/tools/mkimage -T script -C none \
> > > > +		-d $(U_BOOT_BOOT_SCRIPT_TXT) \
> > > > +		$(U_BOOT_DIR)/uboot.scr
> > > 
> > > I don't mind the name, but you could use
> > > '$(notdir $(U_BOOT_BOOT_SCRIPT_TXT))' here and below.
> > 
> > Not sure what you mean here. 'mkimage' expects the [image data file] after
> > option '-d', which is the input file not just a name. And what is 'below'
> > supposed to mean here?
> 
> Sorry, I mixed up the variable names. I meant:
> 
> 	@$(U_BOOT_DIR)/tools/mkimage -T script -C none \
> 		-d $(U_BOOT_BOOT_SCRIPT_TXT) \
> 		$(U_BOOT_DIR)/$(notdir $(U_BOOT_BOOT_SCRIPT_BIN))
> 
> As a way to handle Denis' complaint about the same suffix for both files.
> I don't really care either way. I don't know what the naming conventions
> are for this.

Ah I had overlooked that comment. It's not that bad, this image goes to build-
target and is copied over in targetinstall as a final step. But if being 
pedantic, it should be called e.g. 'boot.scr.uimg' in build-target, too.

Okay, I will cover that in v2 next week. Thanks for your feedback.

Have a nice weekend
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de