Re: [ptxdist] [PATCH v2 0/4] ptxd_make_world_inject: Spring cleanup and optional dest dir

[Michael Riesch <michael.riesch@wolfvision.net>]

Hello Alexander,

On 5/6/24 12:50, Alexander Dahl wrote:
> Hello,
> 
> some spring cleaning and a new feature for the firmware inject
> mechanism.
> 
> When trying to re-build U-Boot as an oot build for the Karo QSBASE93
> Evalkit (for QS93 Solder-Down System-on-Module) it became apparent
> U-Boot wants some of those binary blobs in build folder instead of
> source folder.  Supporting this usecase is nice to have, because you
> won't clutter your source tree, especially when building from external
> tree after something like `ptxdist local-src u-boot ~/src/u-boot` …
> 
> Maybe we should add some documentation for this inject mechanism?
> 
> Follow-up patches for u-boot package in preparation already, but let me
> know what you think of this first.
> 
> Greets
> Alex
> 
> v2:
> - rework patch 4 introducing the new inject oot mechanism
>   (using the new <PKG>_INJECT_OOT variable now instead of a needlessly
>   flexible approach in v1)
> 
> v1: https://lore.ptxdist.org/ptxdist/20240424143109.277373-1-ada@thorsis.com/T/#t
> - initial patch stack revision (implicit)
> 
> Alexander Dahl (4):
>   ptxd_make_world_inject: Remove useless test
>   ptxd_make_world_inject: Use <PKG>_DIR directly
>   ptxd_make_world_inject: Escape inject path and files
>   ptxd_make_world_inject: Introduce new variable <PKG>_INJECT_OOT
> 
>  rules/post/ptxd_make_world_inject.make |  6 +++---
>  scripts/lib/ptxd_make_world_inject.sh  | 26 ++++++++++++++++++++++----
>  2 files changed, 25 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 5a720c419cd1fabde04e8de8d1d1367c76a2666b

nice, thanks for your patches! Again, I am not at all an expert here and
only had a brief look over them, but they LGTM. FWIW:

Acked-by: Michael Riesch <michael.riesch@wolfvision.net>

Best regards,
Michael