Re: [ptxdist] [PATCH v3] tf-a: new package for ARM trusted firmware A

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Philipp,

On 2/25/20 10:20 AM, Philipp Zabel wrote:
>> +	  Enter the TF-A git commitsh you want to build. Usally a tagged release
>                                    ^                       ^
> Some missing vowels here. Also, the git documentation uses spells it
> "commit-ish" [1], but in most places it just says "commit".

Will fix it. It is usually a tag, that's why I don't want it to say
"Enter the git commit".

> What about the other licenses listed in docs/licenses.rst, such as NCSA,
> and Zlib? Does any of this code make it into the TF-A binary?

hm. they are all compatible with BSD-3-Clause if only distributing:
BSD-3-Clause AND BSD-2-Clause AND NCSA AND Zlib

When patching some parts of the code, the patches need to be dually licensed,
thus:
BSD-3-Clause AND BSD-2-Clause AND NCSA AND Zlib AND MIT AND GPL-2.0

Is this ok?

>> +# TF_A_DEBUG=1
> 
> Is this a leftover? I see no other packages with a commented out
> FOO_DEBUG=1 line.

It affects both the DEBUG=X make parameter and the build output directory.
I didn't want to hardcode both places. Would inverted logic with TF_A_RELEASE := 1
be more acceptable?

Cheers
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de