Re: [ptxdist] [PATCH] curl: install root CA certificates option

[Bruno Thomsen <bth@kamstrup.com>]

Hi Michael

Thanks for feedback. I have created 2 new patches that address the issues you have found.

> > +$(STATEDIR)/libcurl.extract:
> > +	@$(call targetinfo)
> > +	@$(call clean, $(LIBCURL_DIR))
> > +	@$(call extract, LIBCURL, $(BUILDDIR))
> > +	@$(call patchin, LIBCURL, $(LIBCURL_DIR))
> > +ifdef PTXCONF_LIBCURL_CA_BUNDLE
> > +	@$(LIBCURL_DIR)/lib/mk-ca-bundle.pl -i -d$(MOZ_CA_TREE) -v $(LIBCURL_DIR)/ca-bundle.crt
> > +endif
>
> No, not like this. Downloading an undefined version of a file during the
> build process is not acceptable.
>
> Add a second file to download (see rules/host-tz-database.make) how to do
> this) and use a URL that does not change, maybe the last tag:
> http://hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_35_0_RELEASE/security/nss/lib/ckfw/builtins/certdata.txt

I have create a new host "certificate bundle downloader"-package (rules/host-certdata.make).

> Also, you need to 'select HOST_SYSTEM_PERL' in the .in file and running
> mk-ca-bundle.pl should be in the compile stage. Otherwise the dependencies
> are not handled correctly.

I have add dependency on HOST_SYSTEM_PERL and HOST_CERTDATA if LIBCURL_CA_BUNDLE is selected.
Moved mk-ca-bundle.pl call from extract to compile stage.

Bruno



-- 
ptxdist mailing list
ptxdist@pengutronix.de