[ptxdist] ubi utils in package mtd-utils broken

[ptxdist] ubi utils in package mtd-utils broken

[Alexander Dahl]

Hei hei, 

I was just migrating our BSP from ptxdist 2012.03.0 to 2012.04.0 and
the build fails in targetinstall stage of package mtd-utils like this:

 make: ***
[/home/adahl/Work/src/BSP/platform-at91sam9g20XXX/state/mtd-utils.targetinstall]
Error 1

 No suitable file '/usr/sbin/ubiattach' could be found in any of these
locations:

/home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach.at91sam9g20XXX

/home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach

A little look to the output of the previous stages showed: ubiattach
and all the other UBI tools are not compiled. Can anyone reproduce this?
How can it be fixed?

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] ubi utils in package mtd-utils broken

[Bernhard Walle]

Hi Alexander,

* Alexander Dahl <post@lespocky.de> [2012-04-04 18:59]:
> 
> I was just migrating our BSP from ptxdist 2012.03.0 to 2012.04.0 and
> the build fails in targetinstall stage of package mtd-utils like this:
> 
>  make: ***
> [/home/adahl/Work/src/BSP/platform-at91sam9g20XXX/state/mtd-utils.targetinstall]
> Error 1
> 
>  No suitable file '/usr/sbin/ubiattach' could be found in any of these
> locations:
> 
> /home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach.at91sam9g20XXX
> 
> /home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach

Maybe this is my fault because I sent some patches regarding mtd-utils
between 2012.03 and 2012.04. Can you provide the
ptxconfig/platformconfig?

Could it be the case that busybox ubi tools are enabled and the patch
http://git.pengutronix.de/?p=ptxdist.git;a=commitdiff;h=92f8312b8c404ce8d2e2f77ad5e09911444db6c4
broke it at your site?


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] ubi utils in package mtd-utils broken

[Bart van der Meulen]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

2012/4/4 Alexander Dahl <post@lespocky.de>:
> Hei hei,
>
> I was just migrating our BSP from ptxdist 2012.03.0 to 2012.04.0 and
> the build fails in targetinstall stage of package mtd-utils like this:
>
>  make: ***
> [/home/adahl/Work/src/BSP/platform-at91sam9g20XXX/state/mtd-utils.targetinstall]
> Error 1
>
>  No suitable file '/usr/sbin/ubiattach' could be found in any of these
> locations:
>
> /home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach.at91sam9g20XXX
>
> /home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach
>
> A little look to the output of the previous stages showed: ubiattach
> and all the other UBI tools are not compiled. Can anyone reproduce this?
> How can it be fixed?
>

I thinks it is caused by the patch
patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch,

If PTXCONF_MTD_UTILS_MKFS_UBIFS is not set then all ubi-utils are not
build, I think
that this must be PTXCONF_MTD_UTILS_UBI_UTILS.

See attached patch.


> Greets
> Alex
>
> --
> »With the first link, the chain is forged. The first speech censured,
> the first thought forbidden, the first freedom denied, chains us all
> irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
> *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de

[-- Attachment #2: 0001-mtd-utils-build-of-ubi-utils-should-depend-on-MTD_UT.patch --]
[-- Type: text/x-diff, Size: 853 bytes --]

From 064471c078fc09442422f08a45fa6e24de786461 Mon Sep 17 00:00:00 2001
From: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
Date: Thu, 5 Apr 2012 11:19:29 +0200
Subject: [PATCH] mtd-utils: build of ubi-utils should depend on MTD_UTILS_UBI_UTILS

When MTD_UTILS_UBI_UTILS is not selected then the ubi-utils don't
have to build.


Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
---
 rules/mtd-utils.make |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rules/mtd-utils.make b/rules/mtd-utils.make
index 14df787..ef0a61b 100644
--- a/rules/mtd-utils.make
+++ b/rules/mtd-utils.make
@@ -48,7 +48,7 @@ ifndef PTXCONF_MTD_UTILS_USE_LIBLZO
 MTD_UTILS_COMPILE_ENV += WITHOUT_LZO=1
 endif
 
-ifndef PTXCONF_MTD_UTILS_MKFS_UBIFS
+ifndef PTXCONF_MTD_UTILS_UBI_UTILS
 MTD_UTILS_COMPILE_ENV += WITHOUT_MKUBIFS=1
 endif
 
-- 
1.7.0.4


[-- Attachment #3: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] ubi utils in package mtd-utils broken

[Bernhard Walle]

Hi,

* Bart van der Meulen <bartvdrmeulen@gmail.com> [2012-04-05 11:20]:
> 2012/4/4 Alexander Dahl <post@lespocky.de>:
> > Hei hei,
> >
> > I was just migrating our BSP from ptxdist 2012.03.0 to 2012.04.0 and
> > the build fails in targetinstall stage of package mtd-utils like this:
> >
> >  make: ***
> > [/home/adahl/Work/src/BSP/platform-at91sam9g20XXX/state/mtd-utils.targetinstall]
> > Error 1
> >
> >  No suitable file '/usr/sbin/ubiattach' could be found in any of these
> > locations:
> >
> > /home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach.at91sam9g20XXX
> >
> > /home/adahl/Work/src/BSP/platform-at91sam9g20XXX/packages/mtd-utils-1.4.9/usr/sbin/ubiattach
> >
> > A little look to the output of the previous stages showed: ubiattach
> > and all the other UBI tools are not compiled. Can anyone reproduce this?
> > How can it be fixed?
> >
> 
> I thinks it is caused by the patch
> patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch,

Sorry, yes, my fault.

> If PTXCONF_MTD_UTILS_MKFS_UBIFS is not set then all ubi-utils are not
> build, I think
> that this must be PTXCONF_MTD_UTILS_UBI_UTILS.

While that fixes the problem, it builds too much (and we need liblzo if
any ubi tool is selected). I think the right fix is to fix the patch
that patches the Makefile, see next mail.

@Alexander: Can you try that out?


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH] mtd-utils: Fix build of UBI tools when mkfs.ubifs is not enabled

[Bernhard Walle]

From: Bernhard Walle <walle@corscience.de>

This problem has been introduced in d4ba37630767095330ddc5cdc3c154cd2e4f757d.
See http://thread.gmane.org/gmane.comp.embedded.ptxdist.devel/9087.

Reported-by: Alexander Dahl <post@lespocky.de>
Signed-off-by: Bernhard Walle <walle@corscience.de>
---
 .../mtd-utils-1.4.9/0001-make-ubifs-optional.patch |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch b/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch
index 8160648..2cbce09 100644
--- a/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch
+++ b/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch
@@ -5,20 +5,19 @@ Subject: [PATCH] make ubifs optional
 Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
 ---
  Makefile |    2 ++
- 1 files changed, 2 insertions(+), 0 deletions(-)
+ 1 file changed, 2 insertions(+)
 
 diff --git a/Makefile b/Makefile
-index 17a1216..000dc86 100644
+index 17a1216..5e1692f 100644
 --- a/Makefile
 +++ b/Makefile
-@@ -30,8 +30,10 @@ UBI_BINS = \
+@@ -30,7 +30,9 @@ UBI_BINS = \
  	ubidetach ubinize ubiformat ubirename mtdinfo ubirsvol
  
  BINS = $(MTD_BINS)
 +ifneq ($(WITHOUT_MKUBIFS), 1)
  BINS += mkfs.ubifs/mkfs.ubifs
- BINS += $(addprefix ubi-utils/,$(UBI_BINS))
 +endif
+ BINS += $(addprefix ubi-utils/,$(UBI_BINS))
  SCRIPTS = flash_eraseall
  
- TARGETS = $(BINS)
-- 
1.7.9.6


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] mtd-utils: Fix build of UBI tools when mkfs.ubifs is not enabled

[Michael Olbrich]

On Thu, Apr 05, 2012 at 12:50:09PM +0200, Bernhard Walle wrote:
> From: Bernhard Walle <walle@corscience.de>
> 
> This problem has been introduced in d4ba37630767095330ddc5cdc3c154cd2e4f757d.
> See http://thread.gmane.org/gmane.comp.embedded.ptxdist.devel/9087.

Thanks, applied.

Michael

> Reported-by: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Bernhard Walle <walle@corscience.de>
> ---
>  .../mtd-utils-1.4.9/0001-make-ubifs-optional.patch |    9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch b/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch
> index 8160648..2cbce09 100644
> --- a/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch
> +++ b/patches/mtd-utils-1.4.9/0001-make-ubifs-optional.patch
> @@ -5,20 +5,19 @@ Subject: [PATCH] make ubifs optional
>  Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
>  ---
>   Makefile |    2 ++
> - 1 files changed, 2 insertions(+), 0 deletions(-)
> + 1 file changed, 2 insertions(+)
>  
>  diff --git a/Makefile b/Makefile
> -index 17a1216..000dc86 100644
> +index 17a1216..5e1692f 100644
>  --- a/Makefile
>  +++ b/Makefile
> -@@ -30,8 +30,10 @@ UBI_BINS = \
> +@@ -30,7 +30,9 @@ UBI_BINS = \
>   	ubidetach ubinize ubiformat ubirename mtdinfo ubirsvol
>   
>   BINS = $(MTD_BINS)
>  +ifneq ($(WITHOUT_MKUBIFS), 1)
>   BINS += mkfs.ubifs/mkfs.ubifs
> - BINS += $(addprefix ubi-utils/,$(UBI_BINS))
>  +endif
> + BINS += $(addprefix ubi-utils/,$(UBI_BINS))
>   SCRIPTS = flash_eraseall
>   
> - TARGETS = $(BINS)
> -- 
> 1.7.9.6
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] ubi utils in package mtd-utils broken

[Alexander Dahl]

Am 2012-04-05 12:49, schrieb Bernhard Walle:
> @Alexander: Can you try that out?

Because of a lack of time I applied it directly on my installed
ptxdist. mtd-utils build was successful now. I will test the binaries on
the target next week.

Thanks for the quick response and have some nice free days.
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] ubi utils in package mtd-utils broken

[Alexander Dahl]

Hei hei, 

Am 2012-04-05 18:29, schrieb Alexander Dahl:
> Because of a lack of time I applied it directly on my installed
> ptxdist. mtd-utils build was successful now. I will test the binaries on
> the target next week.

I saw Michael already applied the patch, nevertheless and for the sake
of completeness: this works on our target. :-)

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] ubi utils in package mtd-utils broken

[Bernhard Walle]

* Alexander Dahl <post@lespocky.de> [2012-04-10 17:04]:
> Hei hei, 
> 
> Am 2012-04-05 18:29, schrieb Alexander Dahl:
> > Because of a lack of time I applied it directly on my installed
> > ptxdist. mtd-utils build was successful now. I will test the binaries on
> > the target next week.
> 
> I saw Michael already applied the patch, nevertheless and for the sake
> of completeness: this works on our target. :-)

Thanks for testing.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de