From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.tq-group.com ([62.157.118.193]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2Xaa-0002UG-No for ptxdist@pengutronix.de; Fri, 14 Feb 2020 10:48:49 +0100 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.117.49.26]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id AC6FE280065 for ; Fri, 14 Feb 2020 10:48:59 +0100 (CET) Message-ID: <8fc8f3dc32078fd13b9beb7738a364435c2a2cf8.camel@ew.tq-group.com> From: Matthias Schiffer Date: Fri, 14 Feb 2020 10:48:45 +0100 In-Reply-To: <20200214091248.GC7958@pengutronix.de> References: <20200213172208.22452-1-matthias.schiffer@ew.tq-group.com> <20200213172208.22452-3-matthias.schiffer@ew.tq-group.com> <20200214091248.GC7958@pengutronix.de> Mime-Version: 1.0 Subject: Re: [ptxdist] (EXT) Re: [PATCH] gettext: deterministically build with included libraries List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, 2020-02-14 at 10:12 +0100, Michael Olbrich wrote: > On Thu, Feb 13, 2020 at 06:22:05PM +0100, Matthias Schiffer wrote: > > gettext's configure will automatically used the libraries it finds, > > and > > fall back to included versions otherwise. Avoid this non- > > deterministic > > behaviour by explicitly choosing the included libraries. > > > > In particular, this issue can break parallel builds with --force > > after > > config changes due to a race condition: > > > > 1. gettext configure finds libraries from a previous build in > > sysroot, > > decides not to use the included libraries > > 2. Installed libraries gets cleaned from sysroot due to --force > > 3. gettext build fails, as it attemps to use the now removed > > libraries > > I'd prefer to select glib and libxml instead. Or are there any > reasons not > to do this? Fine with me. > > The only current user is parted. Do you know why it needs that on the > target anyways? Most packages only need gettext at runtime. Hmm, this was added with the original parted rules in 2010, and I don't see any issues without it - in fact, configure will choose gettext functions from libc even when full gettext is available. I'll send a v3 of the parted patch. > > Michael > > > Signed-off-by: Matthias Schiffer > > > > --- > > rules/gettext.make | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/rules/gettext.make b/rules/gettext.make > > index dd1d22ffb..199616c87 100644 > > --- a/rules/gettext.make > > +++ b/rules/gettext.make > > @@ -54,10 +54,16 @@ GETTEXT_AUTOCONF := \ > > --disable-acl \ > > --disable-openmp \ > > --disable-curses \ > > + --with-included-gettext \ > > + --with-included-glib \ > > + --with-included-libcroco \ > > + --with-included-libunistring \ > > + --with-included-libxml \ > > --without-emacs \ > > --without-bzip2 \ > > --without-xz > > > > + > > # ---------------------------------------------------------------- > > ------------ > > # Target-Install > > # ---------------------------------------------------------------- > > ------------ > > -- > > 2.17.1 > > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > > > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de