Re: [ptxdist] [PATCH] libptxdist: explicitly use sed to run migrate_*

[andreas@biessmann.de]

Dear Michael,

On Mon, 10 Oct 2011 18:04:56 +0200, Michael Olbrich wrote:
> this fixes migrate on systems where sed is not in /bin/ (e.g. OS X).
>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>
> Hi,
>
> what about this? It's less invasive than using autoconf.

Well, your solution fixes my problem with sed in shebang.
But how about wrong sed in path? Or some other problems mentioned
previously ([1], [2]).

I see two solutions here:
  a) fix the surrounding/environment to match always the needs of 
ptxdist
  b) fix ptxdist to use specific environment

a) seems easy to the ptxdist developers cause everyone using ptxdist 
needs
to take care about his environment. That would include setting special 
PATH,
write wrapper scripts or even forking ptxdist [1]. That could be really
frustrating and scare off some users.

b) seems easy to the users of pxdist, cause the configure/build/install
of ptxdist takes care about correct versions of tools.

I tend to vote for b) here. We do not want to scare off users but we do 
want a
reliable, repeatable build process with easy to use interface.
We even do it like this currently (e.g. 'configure --with-python=...'). 
But the
tools found by configure are not taken into account when using ptxdist 
[2].

Another solution compared to yours and my 'PATCH v2' could be some 
configuration-file
which is written in installation phase and provide the environment for 
ptxdist.
This could have another benefit, we can easily change the configuration 
for ptxdist
at run-time without modifying a lot of installed scripts. I imagine ...

---8<---
~# ptxdist PTX_PYTHON=/whereever/i/installed/my/cool/python go
--->8---

So another poll here ;). We have

  a) the full autotools pre-processing of several scripts/rules ... 
files
     ('PATCH v2' solution)
  b) some (tbd) configuration file which could be sourced by ptxdist and 
provide
     the environment for all the scripts/make-file snippets a.s.o
  c) your solution (fix for sed with wrong path in sheebang)

I would like to force a discussion now cause I have a bunch of patches 
on stack
using the same approach as a) to fix the chmod problem mentioned in [1] 
and [3]. It
would be great if we could get some conclusion soon so I could prepare 
my patchset.

There is one other point for me that would prefer the a) solution. We 
(sh|c)ould use
more of the autotools foo to have a cleaner install directory (e.g. why 
installing all
the files necessary to build the kconfig tools?).

best regards

Andreas Bießmann

[1] http://www.mail-archive.com/ptxdist@pengutronix.de/msg01899.html
[2] http://www.mail-archive.com/ptxdist@pengutronix.de/msg04264.html
[3] 
http://git.pengutronix.de/?p=mkl/ptxdist.git;a=commitdiff;h=f6479b400b402815db9c74980557a492eaf26fe3

-- 
ptxdist mailing list
ptxdist@pengutronix.de