Re: [ptxdist] [PATCH] libptxdist: explicitly use sed to run migrate_*

["Andreas Bießmann" <andreas@biessmann.de>]

Dear Bernhard,

On Fri, 14 Oct 2011 17:03:43 +0200, Bernhard Walle wrote:
> Hi,
>
> * Michael Olbrich <m.olbrich@pengutronix.de> [2011-10-14 16:04]:
>> Hmmm, I just had another idea: How about fixing the environment in 
>> ptxdist:
>>
>> mkdir <TMP_BIN>/
>> ln -s @PYTHON@ <TMP_BIN>/python
>> ln -s @SED@ <TMP_BIN>/sed
>> [...]
>> export PATH=<TMP_BIN>:$PATH
>> [...]
>>
>> just do this as early as possible in ptxdist and PATH will provide 
>> the
>> correct tools. Do you think that could work?
>
> That's what I'm doing in the Arch Linux ptxdist package [1]. Arch 
> Linux
> has /usr/bin/python pointing to /usr/bin/python3 instead of python2.
> There's a configure flag for ptxdist and Python, but that doesn't 
> work.
>
> I sent a patch [2], but even that patch doesn't fix everything 
> (there's
> still some ipkg problem). Because I was too lazy I changed it that 
> way
> (modifying PATH).
>
> I'm doing
>
> ----- 8< --------
> export PATH=$(dirname $(readlink -f "$0")):$PATH
> ----- >8 --------
>
> which inclues /usr/lib/ptxdist-2011.xx.y/bin into $PATH and that 
> works.

Seems to me the best solution for our problem. I think the current 
discussion is leading to some PTXDIST_BINDIR directory with links to the 
respective tools.

> It's not really nice, but I think it's better than patching lots of
> tools. And having scripts as executable programs is IMO still better
> than having to call the interpreter manually (which is necessary with
> your $PTXDIST_SED approach.

But how should we handle a script's sheebang? If we require the 
scripts/migrate tools to be executable scripts we need to preprocess the 
scripts to adopt the sheebang to e.g. $PTXDIST_BINDIR. I think it is 
much more portable to have the shell scripts kall the interpreter with 
the respective configuration, e.g. $PTXDIST_BINDIR/sed -f 
scripts/migrate/migrate_platform.

> Regards,
> Bernhard
>
> [1] http://aur.archlinux.org/packages.php?ID=49649
> [2] http://www.mail-archive.com/ptxdist@pengutronix.de/msg04264.html

best regards

Andreas Bießmann

-- 
ptxdist mailing list
ptxdist@pengutronix.de