From: Gavin Schenk <g.schenk@eckelmann.de>
To: Jonas Schmidt <j.schmidt@eckelmann.de>, ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 1/3] doc: fix CSS/JS files not getting picked up by sphinx 5.3.0
Date: Mon, 15 May 2023 13:18:22 +0200 [thread overview]
Message-ID: <87h6sdvo5d.fsf@NB061.eckelmann.group> (raw)
In-Reply-To: <20230515102145.ysykgww5yi2b6kha@NB345>
Hi,
> On Sat, May 06, 2023 at 10:22:21PM +0200, Roland Hieber wrote:
>> Somewhen between v3.4.3 (Debian bullseye) and v5.3.0 (Debian bookworm),
>> sphinx stopped picking up our CSS and JS files from the html_context,
>> which has the effect that the styling of the HTML documentation looks
>> very broken when built with sphinx 5.3.0.
>>
>> Instead of injecting the CSS and JS files into html_context, use the
>> dedicated variables html_css_files and html_js_files, which were
>> introduced in sphinx 1.8 (which came out in 2018). This mostly fixes the
>> layout with sphinx v5.3.0, apart from a small vertical space glitch in
>> the "View page source" link, which we will fix later.
>>
>> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> We had a simular issue and I was workting on an fix as well, but you were faster.
>
> Tested-by: Jonas Schmidt <j.schmidt@eckelmann.de>
> Acked-by: Jonas Schmidt <j.schmidt@eckelaman>
^- Typo here, shall be: Jonas Schmidt <j.schmidt@eckelmann.de>
Maybe a magic keystroke in neovim ?! :)
LG
Gavin Schenk
prev parent reply other threads:[~2023-05-15 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 20:22 Roland Hieber
2023-05-06 20:22 ` [ptxdist] [PATCH 2/3] doc: custom.css: fix indentation Roland Hieber
2023-05-11 5:55 ` [ptxdist] [APPLIED] " Michael Olbrich
2023-05-06 20:22 ` [ptxdist] [PATCH 3/3] doc: custom.css: fix "View Page Source" align with newer sphinx_rtd_theme Roland Hieber
2023-05-11 5:55 ` [ptxdist] [APPLIED] " Michael Olbrich
2023-05-11 5:55 ` [ptxdist] [APPLIED] doc: fix CSS/JS files not getting picked up by sphinx 5.3.0 Michael Olbrich
2023-05-15 10:21 ` [ptxdist] [PATCH 1/3] " Jonas Schmidt
2023-05-15 11:18 ` Gavin Schenk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6sdvo5d.fsf@NB061.eckelmann.group \
--to=g.schenk@eckelmann.de \
--cc=j.schmidt@eckelmann.de \
--cc=ptxdist@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox