Re: [ptxdist] [PATCH v2] hostapd: Add systemd service unit

[Gavin Schenk <g.schenk@eckelmann.de>]

Hey Michael,

I really appreciate the effort and time you put into this feedback, thanks.

>> My motivation for the patch was to remove local customization in the BSP.
>> Unfortunately, without the option to rename the configuration, I must continue
>> to to maintain local changes. Does this patch add value or should we discard it?
>
> It's absolutely valuable. In the general case, we can have hostapd running
> with just an kconfig option and a custom config file (and that one is
> always needed anyways).
>
> And I think even your use-case, the customization is simplified:
> You can provide your own projectroot/usr/lib/systemd/system/hostapd.service
> (which changes less often than e.g. hostapd.make) that uses your custom
> hostapd.conf and a "projectroot/etc/hostapd/hostapd.conf -> /dev/null"
> symlink.
> That's much simpler dann a modified hostapd.make or your own rule to
> install the files.
>
> Michael
> PS: I understand why you would like to have a custom path upstream, but the
> reality is, that everybody has a different config file that needs to be
> loaded from a custom location and allowing that in general is a
> maintenance nightmare for upstream PTXdist.

Understand, full ACK!

gsc