From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.modulmatic.eu ([195.243.134.34] helo=fw.neuberger.net) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1TIaZu-00054i-RQ for ptxdist@pengutronix.de; Mon, 01 Oct 2012 09:38:12 +0200 Received: from exchange.neuberger.local ([10.46.24.202]:2562) by fw.neuberger.net with esmtp (Exim 4.76) (envelope-from ) id 1TIaZm-0001t8-0I for ptxdist@pengutronix.de; Mon, 01 Oct 2012 09:38:02 +0200 Content-class: urn:content-classes:message MIME-Version: 1.0 Date: Mon, 1 Oct 2012 09:39:14 +0200 Message-ID: <84D7328F545A4040B6CE2CB7BE091E937AAA93@exchange.Neuberger.local> In-Reply-To: <20120930130151.GB19651@pengutronix.de> References: <84D7328F545A4040B6CE2CB7BE091E937AA738@exchange.Neuberger.local> <20120930130151.GB19651@pengutronix.de> From: "Wagner Martin" Subject: Re: [ptxdist] [PATCH] schedtool: add package Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hi, As this is my first try porting a package into PTXdist, I think it's best t= o fix my own mistakes :-). > On Wed, Sep 26, 2012 at 03:56:50PM +0200, Wolf Erik wrote: > > i try to send my first (small) patch, i hope it works. = > > = > > How can I create patches like the format from wolfram sangs last = > > patch? I was only able to do it in the fomat below... :( > = > This is done with "git send-email". > = > > >From 2bb361c3519c3c2c0f69848f4020f6c5f83791d8 Wed, 26 Sep 2012 = > > >15:48:46 +0200 > > From: Erik Wolf > > Date: Wed, 26 Sep 2012 15:48:05 +0200 > > Subject: [PATCH] schedtool: add package > = > Don't forget your "Signed-off-by:" > = > > diff --git a/rules/schedtool.in b/rules/schedtool.in new file mode = > > 100644 index 0000000..0a814f5 > > --- /dev/null > > +++ b/rules/schedtool.in > > @@ -0,0 +1,7 @@ > > +## SECTION=3Dshell_and_console > > + > > +config SCHEDTOOL > > + tristate > > + prompt "schedtool" > > + help > > + schedtool can be used to query or alter a process' scheduling = > > +policy under linux > > diff --git a/rules/schedtool.make b/rules/schedtool.make = > new file mode = > > 100644 index 0000000..afc802f > > --- /dev/null > > +++ b/rules/schedtool.make > > @@ -0,0 +1,59 @@ > > +# -*-makefile-*- > > +# > > +# Copyright (C) 2012 by Martin Wagner = > # = > > +# See CREDITS for details about who has contributed to = > this project. > > +# > > +# For further information about the PTXdist project and license = > > +conditions # see the README file. > > +# > > + > > +# > > +# We provide this package > > +# > > +PACKAGES-$(PTXCONF_SCHEDTOOL) +=3D schedtool > > + > > +# > > +# Paths and names > > +# > > +SCHEDTOOL_VERSION :=3D 1.3.0 > > +SCHEDTOOL_MD5 :=3D 0d968f05d3ad7675f1f33ef1f6d0a3fb > > +SCHEDTOOL :=3D schedtool-$(SCHEDTOOL_VERSION) > > +SCHEDTOOL_SUFFIX :=3D tar.bz2 > > +SCHEDTOOL_URL :=3D = > http://freequaos.host.sk/schedtool/$(SCHEDTOOL).$(SCHEDTOOL_SUFFIX) > > +SCHEDTOOL_SOURCE :=3D $(SRCDIR)/$(SCHEDTOOL).$(SCHEDTOOL_SUFFIX) > > +SCHEDTOOL_DIR :=3D $(BUILDDIR)/$(SCHEDTOOL) > > +SCHEDTOOL_LICENSE :=3D GPLv2 > > + > > +# = > > = > +--------------------------------------------------------------------- > > +------- > > +# Prepare > > +# = > > = > +--------------------------------------------------------------------- > > +------- > > + > > +SCHEDTOOL_CONF_TOOL :=3D NO > > +SCHEDTOOL_MAKE_ENV :=3D $(CROSS_ENV) > = > add CPPFLAGS=3D"$(CROSS_CFLAGS) $(CROSS_CPPFLAGS)" here. = > Otherwise the CROSS_CFLAGS set by ptxdist are missing (e.g. = > PTXCONF_TARGET_EXTRA_CFLAGS). Is there a documentation available about those flags, which are avaliable a= nd which one to use in which case? In "how to become a PTXdist Guru" there = are only a few. Looking what other people have done in other packages also = didn't help me much further as it seems that everyone is doing it a little = different... Can you give me a hint which package I can use as a example of how it shoul= d be done? Or are the packages all this different from each other so that t= here are just no similar ones? > = > I know this is not easy to spot. So for testing things like = > this I usually > have: > PTXCONF_TARGET_EXTRA_CPPFLAGS=3D"-Iptx-cppflags" > PTXCONF_TARGET_EXTRA_CFLAGS=3D"-Iptx-cflags" > PTXCONF_TARGET_EXTRA_CXXFLAGS=3D"-Iptx-cxxflags" > PTXCONF_TARGET_EXTRA_LDFLAGS=3D"-Lptx-ldflags" > = > to see which flags are really added to the command line. What are those variables supposed to do? I've built my package once with an= d once without them, but there is no difference on what is displayed. > = > > +SCHEDTOOL_MAKE_OPT :=3D CC=3D$(CROSS_CC) = > = > Check your white spaces. > = > SCHEDTOOL_INSTALL_OPT :=3D DESTPREFIX=3D/usr install > = > and then ... > = > > + > > +$(STATEDIR)/schedtool.prepare: > > + @$(call targetinfo) > > + @$(call touch) > > + > > +# = > > = > +--------------------------------------------------------------------- > > +------- > > +# Target-Install > > +# = > > = > +--------------------------------------------------------------------- > > +------- > > + > > +$(STATEDIR)/schedtool.targetinstall: > > + @$(call targetinfo) > > + > > + @$(call install_init, schedtool) > > + @$(call install_fixup, schedtool,PRIORITY,optional) > > + @$(call install_fixup, schedtool,SECTION,base) > > + @$(call install_fixup, schedtool,AUTHOR,"Martin Wagner = > ") > > + @$(call install_fixup, schedtool,DESCRIPTION,missing) > > + > = > ... change this here: > = > @$(call install_copy, schedtool, 0, 0, 0755, -, = > /usr/bin/schedtool) > = > Michael > = > > + > > + @$(call install_finish, schedtool) > > + > > + @$(call touch) > > + > > +# vim: syntax=3Dmake > > = > > = = Mit freundlichen Gr=FC=DFen = i.A. Martin Wagner Hardwareentwicklung = = Neuberger Geb=E4udeautomation GmbH Oberer Kaiserweg 6 91541 Rothenburg o.d.T. = Telefon: +49 9861 402-548 Telefax: +49 9861 402-533 E-Mail: martin.wagner@neuberger.net Internet: www.neuberger.net = Handelsregister: AG Ansbach HRB 4933 Sitz: Rothenburg ob der Tauber Gesch=E4ftsf=FChrer: Klaus Lenkner Ust.IdNr. DE 271 188 426 = -- = ptxdist mailing list ptxdist@pengutronix.de