From: "Andreas Bießmann" <andreas@biessmann.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] bin/ptxdist: check_dirs_mkdir() utilize umask
Date: Thu, 26 Jan 2012 17:08:49 +0100 [thread overview]
Message-ID: <80e8cfd420214e57d49969fad2ada90d@biessmann.de> (raw)
In-Reply-To: <20120126151800.GL25121@pengutronix.de>
Hi Michael,
On Thu, 26 Jan 2012 16:18:00 +0100, Michael Olbrich wrote:
> On Thu, Jan 26, 2012 at 10:29:00AM +0100, Andreas Bießmann wrote:
>> In some cases the check_dirs_mkdir() function will create
>> directories on the
>> way (parents) with insufficient rights. Therefore the chmod/chown
>> later on
>> will fail due to missing rights.
>>
>> This patch forces 'umask 0022' for creating the directories on the
>> way and
>> additionally add the missing '-m755' switch to the 'sudo'-variant.
>
> Hmmm, we're mkdir etc. elsewhere as well. Shouldn't we just jet umask
> globally sometime at the beginning of ptxdist?
well ... we could. Will you find a place to set the mask?
best regards
Andreas Bießmann
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-01-26 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 9:29 Andreas Bießmann
2012-01-26 15:18 ` Michael Olbrich
2012-01-26 16:08 ` Andreas Bießmann [this message]
2012-02-03 10:48 ` [ptxdist] [PATCH v2] bin/ptxdist: set umask globally Andreas Bießmann
2012-02-07 13:22 ` Michael Olbrich
2012-02-07 13:36 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80e8cfd420214e57d49969fad2ada90d@biessmann.de \
--to=andreas@biessmann.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox