Re: [ptxdist] [RFC PATCH 1/3] imx-uuc: new package

[Denis Osterland-Heim <denis.osterland@diehl.com>]

Hi Roland,

Am Mittwoch, den 25.03.2020, 21:40 +0100 schrieb Roland Hieber:
> On Wed, Mar 25, 2020 at 07:52:54PM +0100, Roland Hieber wrote:
> > On Wed, Mar 25, 2020 at 07:43:46PM +0100, Roland Hieber wrote:
> > > On Tue, Mar 24, 2020 at 02:53:23PM +0000, Denis Osterland-Heim wrote:
> > > > NXP user space util used by mfgtool.
> > > > 
> > > > Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
> > > > ---
> > > >  rules/imx-uuc.in   |  7 ++++++
> > > >  rules/imx-uuc.make | 62 ++++++++++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 69 insertions(+)
> > > >  create mode 100644 rules/imx-uuc.in
> > > >  create mode 100644 rules/imx-uuc.make
> > > > 
> > > > diff --git a/rules/imx-uuc.in b/rules/imx-uuc.in
> > > > new file mode 100644
> > > > index 000000000..ec0cbcd3a
> > > > --- /dev/null
> > > > +++ b/rules/imx-uuc.in
> > > > @@ -0,0 +1,7 @@
> > > > +## SECTION=communication
> > > > +
> > > > +config IMX_UUC
> > > > +	tristate
> > > > +	prompt "imx-uuc"
> > > > +	help
> > > > +	  A Daemon wait for Freescale/NXP mfgtools host's command.
> 
> Oh, and also keep the tabs as indentation here, not spaces (except for
> the two spaces before the help text).
Yes, of course. It are tabs. When I select it, it is bigger than one space.

> 
> > > > diff --git a/rules/imx-uuc.make b/rules/imx-uuc.make
> > > > new file mode 100644
> > > > index 000000000..d275ec8af
> > > > --- /dev/null
> > > > +++ b/rules/imx-uuc.make
> > > > @@ -0,0 +1,62 @@
> > > > +# -*-makefile-*-
> > > > +#
> > > > +# Copyright (C) 2016-2020 by Denis Osterland <Denis.Osterland@diehl.com>
> > > > +#
> > > > +# See CREDITS for details about who has contributed to this project.
> > > 
> > > This line keeps coming back to haunt us… :)
> > > https://git.pengutronix.de/cgit/ptxdist/commit?h=cbd6bda680c6
I see. I will remove it. It is lying around since 2016.

> > > 
> > > > +#
> > > > +# For further information about the PTXdist project and license conditions
> > > > +# see the README file.
> > > > +#
> > > > +
> > > > +PACKAGES-$(PTXCONF_IMX_UUC) += imx-uuc
> > > > +
> > > > +#
> > > > +# Paths and names
> > > > +#
> > > > +IMX_UUC_VERSION    := d6afb27e55d73d7ad08cd2dd51c784d8ec9694dc
> > > > +IMX_UUC_MD5        := 1a807ab59464385309b92794b43b5caa
> 
> Same here: tabs for alignment before the :=.
I will change it.

> 
> > Sorry, I slipped while writing the mail. What I wanted to write in the
> > first place:
> > 
> > Nitpick: I don't know how picky opkg-based systems are with having
> > monotonically increasing version numbers, but in case someone uses them
> > to update software in the field, you could make them happy by providing
> > a fake 'git describe' tag as a version:
> > 
> > IMX_UUC_VERSION    := 0.0-1-gd6afb27e55d73d7ad08cd2dd51c784d8ec9694dc
> > 
> > and then increase the -1 every time for a version bump. This way git
> > can extract the commit ID from the version info and opkg versions are
> > increasing monotonically. The MD5 will be different though.
Cool. I will apply.

I hope for a release, but looks not promising.
https://github.com/NXPmicro/imx-uuc/issues/12

> > 
> >  - Roland
> > 
> > > > +IMX_UUC            := imx-uuc-$(IMX_UUC_VERSION)
> > > > +IMX_UUC_SUFFIX     := tar.gz
> > > > +IMX_UUC_URL        := https://github.com/NXPmicro/imx-uuc.git;tag=$(IMX_UUC_VERSION)
> > > > +IMX_UUC_SOURCE     := $(SRCDIR)/$(IMX_UUC).$(IMX_UUC_SUFFIX)
> > > > +IMX_UUC_DIR        := $(BUILDDIR)/$(IMX_UUC)
> > > > +IMX_UUC_LICENSE    := GPL-2.0-or-later
> > > > +IMX_UUC_LICENSE_FILES	:= \
> > > > +	file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263
> > > > +
> > > > +# ----------------------------------------------------------------------------
> > > > +# Prepare
> > > > +# ----------------------------------------------------------------------------
> > > > +
> > > > +IMX_UUC_CONF_TOOL	:= NO
> > > > +
> > > > +# ----------------------------------------------------------------------------
> > > > +# Compile
> > > > +# ----------------------------------------------------------------------------
> > > > +
> > > > +IMX_UUC_MAKE_ENV       := $(CROSS_ENV)
> > > > +
> > > > +# ----------------------------------------------------------------------------
> > > > +# Target-Install
> > > > +# ----------------------------------------------------------------------------
> > > > +
> > > > +$(STATEDIR)/imx-uuc.targetinstall:
> > > > +	@$(call targetinfo)
> 
> And here too, otherwise make will complain for recipes.
definitely a tab.
Do you have problems to apply it?

> 
>  - Roland
> 
> > > > +
> > > > +	@$(call install_init, imx-uuc)
> > > > +	@$(call install_fixup, imx-uuc,PRIORITY,optional)
> > > > +	@$(call install_fixup, imx-uuc,SECTION,base)
> > > > +	@$(call install_fixup, imx-uuc,AUTHOR,"Denis Osterland <Denis.Osterland@diehl.com>")
> > > > +	@$(call install_fixup, imx-uuc,DESCRIPTION,missing)
> > > > +
> > > > +	@$(call install_copy, imx-uuc, 0, 0, 0755, -, /usr/bin/uuc)
> > > > +	@$(call install_copy, imx-uuc, 0, 0, 0755, -, /usr/bin/ufb)
> > > > +	@$(call install_copy, imx-uuc, 0, 0, 0755, -, /usr/bin/sdimage)
> > > > +	@$(call install_alternative, imx-uuc, 0, 0, 0755, /linuxrc)
> > > 
> > > Upstream has a bold choice of config file locations...
I am not sure what you want to say here.
https://github.com/NXPmicro/imx-uuc/blob/master/linuxrc
sets up the USB function fs stuff for mfgtool.
Unfortunately it uses array syntax, which is not supported by busybox.
You may enable bash (have not tested and shebang says sh) or change the script.
That´s what I did.
Maybe I find the time to fix the script upstream, to use only sh features.

Regards Denis

> > > 
> > >  - Roland
> > > 
> > > > +	@$(call install_alternative, imx-uuc, 0, 0, 0644, /fat)
> > > > +
> > > > +	@$(call install_finish, imx-uuc)
> > > > +
> > > > +	@$(call touch)
> > > > +
> > > > +# vim: syntax=make
> > > > -- 
> > > > 2.25.2
> > > > 
> > > > 
> > > > 
> > > > Diehl Connectivity Solutions GmbH
> > > > Geschäftsführung: Horst Leonberger
> > > > Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> > > > Nürnberg: HRB 32315
> > > > ___________________________________________________________________________________________________
> > > > 
> > > > Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> > > > Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> > > > Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> > > > - Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/
> > > > 
> > > > The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> > > > mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
> > > > - For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
> > > > 
> > > > _______________________________________________
> > > > ptxdist mailing list
> > > > ptxdist@pengutronix.de
> > > > 
> > > 
> > > -- 
> > > Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> > > Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> > > 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> > > Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > 
> > -- 
> > Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> > Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> > 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> 
> 


Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
- For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de