From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Mon, 13 Feb 2023 14:59:04 +0100
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1pRZMH-006H05-JV
	for lore@lore.pengutronix.de; Mon, 13 Feb 2023 14:59:04 +0100
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1pRZME-000715-M8; Mon, 13 Feb 2023 14:59:02 +0100
Received: from luzerne.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::52])
 by metis.ext.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <s.pueschel@pengutronix.de>) id 1pRZM1-00070w-FB
 for ptxdist@pengutronix.de; Mon, 13 Feb 2023 14:58:49 +0100
Message-ID: <7a6848be-61a6-6e2b-eb1c-7f9490676f82@pengutronix.de>
Date: Mon, 13 Feb 2023 14:58:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Content-Language: en-US
To: ptxdist@pengutronix.de
From: =?UTF-8?Q?Sven_P=c3=bcschel?= <s.pueschel@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [ptxdist] Globally define GIT_CEILING_DIRECTORIES?
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

I would suggest globally setting the GIT_CEILING_DIRECTORIES environment 
variable when building packages.

Besides lshw, sockperf is now the second time I've encountered the 
buildsystem to check the current git repository. But as Git also checks 
the parent directories when searching for Git repositories, these checks 
may result in getting an unwanted Git repository (usually the BSP), 
resulting in package versions with a Git commit/version that has nothing 
to do with the actual package.

With GIT_CEILING_DIRECTORIES set to the parent directory of the 
extracted sources, Git will stop searching for parent Git repositories, 
when it encounters this directory. See my sockperf v2 patch for an 
example of using this environment variable.

Given this is a global change, does anyone see a potential problem?


Best regards

Sven