Re: [ptxdist] [PATCH] rootfs: option to link /etc/resolv.conf to /lib/systemd/resolv.conf

["Enrico Weigelt, metux IT consult" <enrico.weigelt@gr13.net>]

On 20.03.2017 15:34, Artur Wiebe wrote:
> Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> ---
>  rules/rootfs.in    | 11 +++++++++++
>  rules/rootfs.make  |  3 +++
>  rules/systemd.make |  1 +
>  3 files changed, 15 insertions(+)
> 
> diff --git a/rules/rootfs.in b/rules/rootfs.in
> index 5965417e1..1b459b6d7 100644
> --- a/rules/rootfs.in
> +++ b/rules/rootfs.in
> @@ -426,6 +426,17 @@ choice
>  		  systemd-resolved and is filled with data from the systemd
>  		  managed interfaces.
>  
> +	config ROOTFS_RESOLV_STATIC

Misleading config item name.

Should clearly reflect the fact that it links to a file belonging to
one particular optional package. So, perhaps call it

   CONFIG_ROOTFS_RESOLV_SYSTEMD_STATIC

OTOH, as it's from only one of dozens optional packages that might
add/maintain local resolver config, I wonder why it's not handled
within that particular package (in that case: systemd). By the same
logic, we would also have to add similar options for all the various
dhcp clients of other network management tools within the rootfs
package. And the same for lots of other files in /etc.


--mtx


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de