Re: [ptxdist] Difficulties to compile package utils-linux while upgrading from PTXDIST-2023.09.0 to PTXDIST-2023.19.0.

[Christian Melki <christian.melki@t2data.com>]

Hi,

On 1/8/24 1:14 PM, ruggero wrote:
> [Du f?r inte e-post ofta fr?n rrossi@atb-biomag.de. L?s om varf?r det h?r ?r viktigt p? https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hello everybody,
> 
> 
> my BSP still uses an old version of linux / libC, that does not provide
> all modern features.
> 
> Compiling utils-linux with PTXDIST-2023.09.0 was painless.
> Upgrading to PTXDIST-2023.11.0 caused several compilation errors.
> 
> Both PTXDIST release uses the same version of utils-linux (2.39.2) the
> only difference being the build system. PTXDIST-2023.09.0 uses autotools,
> while PTXDIST-2023.11.0 uses meson.
> 
> Here a list of the problems:
> 
> My linux do not provide <linux/blkzoned.h>. This causes an error while
> compiling blkzone.
> 
> My linux do not provide <linux/pr.h>. This causes an error compiling blkpr.
> 
> My linux do not provide <linux/kcmp.h>. This causes an error compiling
> lsfd.
> 
> My linux do not provide the symbol SIOCGSKNS in linux/sockios.h. This
> causes an error while compiling test_mkfds.
> 
> In the autotool version, all these programs were disabled. This seems to
> be not possible with meson.
> 
> My libC provides the symbol openpty in the libutils module. The
> PTXDIST-2023.09.0 makefile util-linux.make explicitly enables libutils,
> the  PTXDIST-2023.11.0 explicitly disables them.
> 
> I was able to find a solution to all the problems. Attached are my patches.
> 
> In meson.build I disabled build of blkzone if linux/blkzoned.h does not
> exists, lsfd if linux/pr.h is missing, etc.
> 
> In the makefile util-linux.make I just changed libutils form disabled to
> enabled. Maybe one can consider to use a parameter instead.
> 
> I'm not sure if this is the best way to do, since it is my first
> experience with meson. It would be nice if somebody can check them, and
> maybe include them in the future versions of ptxdist.
> 

Thanks for reporting and working with these issues.
I suggest also reporting them upstream to the util-linux project itself.
There are going to be a lot of these types of issues.
Ie when converting build systems, be it autotools or anything else.

Regards,
Christian

> 
> 
> Ruggero
> 
> 
> 
>