From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Message-ID: <769ca87113f54fecb87b6692ffc91164728730c4.camel@pengutronix.de>
From: Jan =?ISO-8859-1?Q?L=FCbbe?= <jlu@pengutronix.de>
Date: Fri, 15 May 2020 13:41:54 +0200
In-Reply-To: <5c78df95-a79d-24ae-f59d-8ed98d2be2ad@pengutronix.de>
References: <20200514134300.16105-1-bst@pengutronix.de>
 <20200514134300.16105-4-bst@pengutronix.de>
 <20200515103628.GA7220@pengutronix.de>
 <5c78df95-a79d-24ae-f59d-8ed98d2be2ad@pengutronix.de>
MIME-Version: 1.0
Subject: Re: [ptxdist] [PATCH 04/13] ptxd_lib_code_signing: introduce CA
 helper
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: Bastian Krause <bst@pengutronix.de>, ptxdist@pengutronix.de

On Fri, 2020-05-15 at 13:21 +0200, Bastian Krause wrote:
> I guess if we first append a file with no EOL at the end and then
> append something else this can lead to..
> 
> "-----END CERTIFICATE----------BEGIN CERTIFICATE-----"
> 
> .. on a single line.

Yes, this is the case is was thinking of.

> Is there a smart way of adding an EOL? Or should we always append a
> final new line? Does this break any known usecases?

Empty lines don't hurt here, so always adding one seems the safe and
simple solution.

Regards,
Jan


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de