From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from smtprelay01.ispgateway.de ([80.67.31.28])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <bernhard@bwalle.de>) id 1S9ujL-0004wR-Cz
	for ptxdist@pengutronix.de; Tue, 20 Mar 2012 09:47:48 +0100
Received: from [80.67.16.114] (helo=webmail.df.eu)
	by smtprelay01.ispgateway.de with esmtpa (Exim 4.68)
	(envelope-from <bernhard@bwalle.de>) id 1S9ujE-00027C-9x
	for ptxdist@pengutronix.de; Tue, 20 Mar 2012 09:47:40 +0100
MIME-Version: 1.0
Date: Tue, 20 Mar 2012 09:47:40 +0100
From: Bernhard Walle <bernhard@bwalle.de>
In-Reply-To: <20120320084339.GJ20481@pengutronix.de>
References: <1332187070-7282-1-git-send-email-linux@bohmer.net>
	<20120320084339.GJ20481@pengutronix.de>
Message-ID: <7397e853a04b4f647c9c73debb3830ea@bwalle.de>
Subject: Re: [ptxdist]
 =?utf-8?q?=5BPATCH=5D_=5Bflashbench=5D_Fix_syntax_error?=
 =?utf-8?q?_in_case_FLASHBENCH=5FMAX=5FBUFSIZE_not_defined?=
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Am 20.03.2012 09:43, schrieb Michael Olbrich:
> On Mon, Mar 19, 2012 at 08:57:50PM +0100, Remy Bohmer wrote:
>> This error occurs in case PTXCONF_FLASHBENCH_MAX_BUFSIZE is not 
>> defined:
>> $ ptxdist get
>> expr: syntax error
>> make: Nothing to be done for `get'.
>>
>> Change-Id: I1978d62b8781dbd5090b8a47b8fd8b944e6c79dc
>> Signed-off-by: Remy Bohmer <linux@bohmer.net>
>> ---
>>  rules/flashbench.make |    8 +++++++-
>>  1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/rules/flashbench.make b/rules/flashbench.make
>> index fcb669e..b312979 100644
>> --- a/rules/flashbench.make
>> +++ b/rules/flashbench.make
>> @@ -31,8 +31,14 @@ FLASHBENCH_LICENSE	:= GPL v2
>>
>>  FLASHBENCH_CONF_TOOL	:= NO
>>  FLASHBENCH_MAKE_ENV	:= $(CROSS_ENV)
>> +
>> +ifdef PTXCONF_FLASHBENCH_MAX_BUFSIZE
>> +FLASHBENCH_MAX_BUFSIZE	:= $(PTXCONF_FLASHBENCH_MAX_BUFSIZE)
>> +else
>> +FLASHBENCH_MAX_BUFSIZE	:= 1
>> +endif
>
> I think we should report an error here:
>
> ifndef PTXCONF_FLASHBENCH_MAX_BUFSIZE
> $(error some error message here)
> endif

I think the problem is here that flashbench is not selected, so the 
PTXCONF_FLASHBENCH_MAX_BUFSIZE
option is unset.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de