Re: [ptxdist] [PATCH] ptxd_make_fit_image: Add mandatory properties

[Denis Osterland-Heim <denis.osterland@diehl.com>]

Hi,

AFAIK bootloaders should have reasonable defaults for this values.
So they should be optional.

Regrads, Denis

Am Dienstag, den 10.11.2020, 10:11 +0100 schrieb avazquez.dev@gmail.com:
> From: AVazquez <avazquez.dev@gmail.com>
>
> Add mandatory properties for types kernel and ramdisk.
>
> Signed-off-by: AVazquez <avazquez.dev@gmail.com>
> ---
>  platforms/kernel-fit.in            | 10 ++++++++++
>  scripts/lib/ptxd_make_fit_image.sh |  4 ++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/platforms/kernel-fit.in b/platforms/kernel-fit.in
> index 8cbc1a8..d917a97 100644
> --- a/platforms/kernel-fit.in
> +++ b/platforms/kernel-fit.in
> @@ -17,6 +17,16 @@ menuconfig KERNEL_FIT
>
>  if KERNEL_FIT
>
> +config KERNEL_FIT_LOAD
> +string
> +default "0xC0008000"
> +prompt "Kernel load address"
> +
> +config KERNEL_FIT_ENTRY
> +string
> +default "0xC0008000"
> +prompt "Kernel entry address"
> +
>  config KERNEL_FIT_SIGNED
>  bool
>  prompt "sign FIT image"
> diff --git a/scripts/lib/ptxd_make_fit_image.sh b/scripts/lib/ptxd_make_fit_image.sh
> index 9754d1e..4314b0e 100644
> --- a/scripts/lib/ptxd_make_fit_image.sh
> +++ b/scripts/lib/ptxd_make_fit_image.sh
> @@ -21,7 +21,10 @@ ptxd_make_image_fit_its() {
>  data = /incbin/("${image_kernel}");
>  type = "kernel";
>  arch = "$(ptxd_get_ptxconf PTXCONF_ARCH_STRING)";
> +os = "linux";
>  compression = "none";
> +load = <$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_LOAD)>;
> +entry = <$(ptxd_get_ptxconf PTXCONF_KERNEL_FIT_ENTRY)>;
>  hash-1 {
>  algo = "sha256";
>  };
> @@ -33,6 +36,7 @@ EOF
>  description = "initramfs";
>  data = /incbin/("${image_initramfs}");
>  type = "ramdisk";
> +os = "linux";
>  compression = "none";
>  hash-1 {
>  algo = "sha256";
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de