From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 04 Mar 2022 09:26:56 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQ3H6-00HN8T-Pe for lore@lore.pengutronix.de; Fri, 04 Mar 2022 09:26:56 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nQ3H5-0003lo-U7; Fri, 04 Mar 2022 09:26:55 +0100 Received: from mail-eopbgr130049.outbound.protection.outlook.com ([40.107.13.49] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ3Go-0003lZ-NG; Fri, 04 Mar 2022 09:26:39 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9jveNuoZafSnLXnmo0RonxHlln0wkqsCGEij6KZ90ST/rV4k/kvWkRdjfet+7/2CjRzOCASIC9/nX20Hd01bz3lXp6JQFYWrFkNr8baMr6VjpyOPQ2P+RHmoe7W2nmcxlhoaNvCsQZO+RcO9qMM8hi4ztTSwE2S6881veQCKOiSBHxBv3t1I9GU3oxol+GncGul9oegdX25n8r5k2DfG6sGwGe1fKSKWXZ7556K3q05XYeaX3s4XEgQBKWKKg4NP0kvG9rEiWDz+bppKyWqhu8oLdRgkCatox/Lzz0rCaYi+L2zmItAZDh1csST8kQf99iXmyyYdBYkumYB1MvMdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ATTBfA+zR3GIHoHwAFnTA9ClM7d2MhEs6+C7plUkZWg=; b=JdvwRCfoVUJ1VrGj15azK9Z9vA6yxjmCFgdS4ARUCbeYLjmhe7rsSKTmHYE1H9eu7JV1kGS3NR1qm3XWQH61hhKuZrBrLjY+Hm9llZ7U6hVfK+9m/IhfZDtQwViC4hr8k4uyTMzRhmlBIMdsgsF8WzhMS0dDHFrS5LQBZku82bEo36KVZa2G9FbJSGFGR9iBiEslrC5f1VZDN30NxokBlIPdWodg0tAqZqeI9/uCMlscdK/Gh7rJ+94PF/C+apEG8YItrgKCH6sHk7IAfya8bNphJvF3GkE/l3PUkCD9ionwhK4LtvFVhm7VjHUeHXb/5p/ZTKFZYa/eNyPcgkbfjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=t2data.com; dmarc=pass action=none header.from=t2data.com; dkim=pass header.d=t2data.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ATTBfA+zR3GIHoHwAFnTA9ClM7d2MhEs6+C7plUkZWg=; b=kyUDBAy6Svcl8SmK9xlEGeiGunt+QTBMSukXqlUqSw2wwa7zBJLUtd4VXPbwbFXv316ZGSud4UvO6o4/yl/lceaVwNjyABh9VlNABPbgSoSDHTwkq0A6OwCKBAG+H0w/8HFIuad82bBuwpTR4kQu24c18CWvKoviQ6NWBlfC+eE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=t2data.com; Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) by AS1P251MB0430.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:4a9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 08:26:36 +0000 Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::1cba:3835:dd1e:63d3]) by DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::1cba:3835:dd1e:63d3%6]) with mapi id 15.20.5038.014; Fri, 4 Mar 2022 08:26:36 +0000 Message-ID: <7105cf63-9ef6-7c5a-594f-731cb92061cf@t2data.com> Date: Fri, 4 Mar 2022 09:24:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Content-Language: en-US To: Michael Olbrich References: <20220303134028.GN12709@pengutronix.de> <7ee003fb-e6c3-34d7-d9e2-d29279369b0c@t2data.com> <9e421142-d037-6b62-79c4-2a7a9a09d120@benfm.de> <00ae8995-135e-dc67-737e-4c7d6ec3e08a@t2data.com> <20220303201138.GB26895@falbala.internal.home.lespocky.de> <20220303203533.GC26895@falbala.internal.home.lespocky.de> From: Christian Melki In-Reply-To: X-ClientProxiedBy: GV3P280CA0001.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::31) To DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3965ef1b-b047-4608-49d6-08d9fdb8b25a X-MS-TrafficTypeDiagnostic: AS1P251MB0430:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YtBLWqtl6UF0Y0uF5AXoWHtfBjwo+3TP/tWdD7lZsmeqC4NfsZNBj+qbW80wAfUku6Xa+I0CzRwoVfmuwcRap5qFN3dgp5+qEz+Zz4MqQBATVAyeH2GFFEMBVJ3+qLcAnjd0L6o3EgipWWpZb41DUZUCwn8os8Lw35DvyTsPDePjVj19FD9owoaCMns5Q8YLo2cpDivjntmy3W4dkJgQQKECTb9HMGIH1k1ANKgQTDeaL3g6PUuXqIKTdArabfvcVFn3uJEHo/c0h7bJwjEHEYPvieS/rx09urqMBcjjIChbKk2TaPqM+bZ/vAQQYBLaCxFKExtUdPhxwK7PALDoLIc3ckCPAvlDtMDRfVCbNlxcNJtVidNqsiKOcB82n8GdnTH2pAKGVtfKsi2WEoo0Ls6o6Qsv5EpHhq4kdX0iBP0EXuO1e0y00cI48LAtuX2ifjnSxHgxf8/gcIchhef2e+4u4LCZBmwPD3sUoPzo1n4qyfCFjhSiBsuymh0SY8at/zGR8eVXAYHQWm8llZntrC7M86C09Dytz07gdZwhobFGDCGjjpPR6n4TrJAaIP9Ng/pwUuLoCVsvmc5d9OC8ZxCgrsr7/BaLmpNhCV2DhDvUYIhf1Fv/NwOMwdgP3qIfdag7w+zuqSYyvD57u6Pl+8t7h0wXYzOO5gr9IGHF/S3NGSUNpkxVYpFJXYuVrdgWGbAKMUJuqjUSZ5WQG9PZFUQkE1rZ7ICfmu4W+V5w670waBaQdVNsCQfROlatUNRwrEiCZ8o8epXBpvWBjMdMgj0Mqr8Yef0FS8n67cujp5k= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P251MB0618.EURP251.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(376002)(366004)(136003)(39830400003)(396003)(346002)(38100700002)(8936002)(66476007)(66556008)(66946007)(450100002)(316002)(38350700002)(508600001)(6512007)(5660300002)(8676002)(2906002)(2616005)(4326008)(6486002)(31696002)(6666004)(44832011)(36756003)(86362001)(31686004)(26005)(186003)(6916009)(6506007)(52116002)(83380400001)(53546011)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGVoRlkrSVNHT0RNYUVRaHlWRXIyRk9WYzR2UkdzVHFCd2FuSExraUVaSTZH?= =?utf-8?B?dWpUSjVnOHJrSGJIdW5ybk5EdjJzUWVwenBFUDFXWWxRcGNQeEVMK3cyUlBv?= =?utf-8?B?MzdQbVZVUmc2WFI0TTZXNTllaTVjczFkcGVReklVYXRaNXRNaDRDcHNKVmVY?= =?utf-8?B?NTErUTN3NkN0cXNYdXNid05jSkpQWEp0MXMvRDV1OG1KWDVnKzArSlI5ZWlO?= =?utf-8?B?VzFpYTNtbXBnZmhUMlZ6K0FsSEFwSHJhSHd4ekVEbWJlM0F1dFRuTzhZS09t?= =?utf-8?B?b1N1bG5zaERHR0Z1T21DS2MwM3FSOEZ4QXh3TzJ2RGxDNHdxTHN1T1hnQlRO?= =?utf-8?B?dUg1ZU9ZKzJTVVNhSXJ1NUtzM1lpbmpHbzJ3bUJhb3RxYXp4aGJqSzJ1K244?= =?utf-8?B?RmNRWW9OSXpiRy8vOWpjVDNpRHNlcjFBT2NmNU9ha0tzcy8vblZmNVM0Z3ph?= =?utf-8?B?RCtiOVNmaUhUMFVFcjY4R2NWd1pkQXovQVNRZjZreUhBbzYxSTVjK2JpK093?= =?utf-8?B?U1VoSHNpcXFXajd4TDRRTmdiR2UxeE4zQTNLc1RjU25QZzZiajBIN1pCU3Vl?= =?utf-8?B?bW9rZ00vOEY2bVNaL3k5NSs2bmhQdEFZRG95TzBvMWM4eEQzV2R4cWFGV3RL?= =?utf-8?B?Z2wzc3REY2ZLMmgrOE9IYlZhSlh6TlFmYkxQMkdheExvSU8zcDZoWnRLNkVP?= =?utf-8?B?Q3l0S2w2eTUvYkhlSUtZS0dtT0JsUGMxbllJV2UvdFJTaWdJUTA1ajFxVlhl?= =?utf-8?B?clFSSnM5U0dEaGlpbUl4cHlMUWxHT05MVmNraGpCaVZndUNTdHd5aWN6ZEha?= =?utf-8?B?SmE4QXE5dkRCRTdUWFhCNjlwNzhORzdhNFBMVkJLZDdOZUV6TUpQQ2ZZUmpL?= =?utf-8?B?Qmt4TThSdTNHeS9pdmkvUWxuaHFweDZveUNKL2xzVHBDeUR6Ylc5TlRkdG51?= =?utf-8?B?b2Flb1BpRWNYdVFzajZVVmprUHpZV1RYMmFuNk9oajV2OTVDeGZlbjBYMW5p?= =?utf-8?B?aStza2xySHhuZGlxbXRhTE0xOTQ1RGlBUFNoTUoxRzhiN3RFNVlNUjZ4bmFp?= =?utf-8?B?ckgvZFJHZVU4RnVOSTVDN1VXN3haQW5VUHpvUElRWnFZWkhyaEpnN2xOVmdy?= =?utf-8?B?K2IxaFJLSlhncUFLR3cxdzBFV0NKZTNPd0tYaFU5RXBmUlMvWk5nbDNrdWcz?= =?utf-8?B?K0hUMFpRdm5vNWxyRGxDRTdMRXA4MkhDaG9qQklGcVRPOG1vUWFIaWNuMG1B?= =?utf-8?B?VzJZOGNGcjEzSWVpZnhmSWNYRVJrMmxCbXFiYnVtYXpNVW5KZ0lqakRVb2Z5?= =?utf-8?B?ajJhZDlwVDBOc3dhbGxORC9IUUZCQ0xGcHFsL1IyNjI0Yk83N29GL1E1aklN?= =?utf-8?B?QXVvSDVCQi9nZXZpWFhlRnk2V2F3Rnc0SnRMczlyM2cyMXR4eEVpdSszeFha?= =?utf-8?B?YVBsYkdjQ1I1SE04dHROcHJ1VWxtNTg0eWFDWEQyVHFrbmlTZDJzYUgvNk1x?= =?utf-8?B?TWxjQzU1Sk04NXYrSmgwZjBaMHJ2dkROVjk1SFc1V1FPcUhNMmFleXp1VkNP?= =?utf-8?B?UytkeTV4eStwZUNJSnhQQmphbks4RDVkMVd4dDRrbVFKMnZubFNpTjN2WjUr?= =?utf-8?B?aUtuc3dmMzFMT0kxQXJ6Z3lTVlU1Z2VrdGlOZDNvVFVzNmQ2cll2ZGxRN2w5?= =?utf-8?B?WkxrY0Y1SFRVbnR2NEVYLytTSTNUYVd0dVg5d3BkaGxZY2NCd0Q3SEZpQlF6?= =?utf-8?B?S2I3cGQyZExDY2x2aHNJYlIydm1NbFZ5Qi9rTTR2WExab2pRSGN1OStQOW05?= =?utf-8?B?UDJqVUlNVVdnR2ljNTlHbHNSUVBLZVI3MnNQU2JidXBmeWRqQS9IQjl6clpZ?= =?utf-8?B?QTJQMHFZNEtOU1FTblpUdWFxcDhtUjdNZU1PRFVzSTRjbmFxS1Exemh3cE9a?= =?utf-8?B?c3RTekFvclVJUlhZMFV3eitnbWFkZDlZRzJSM2tuOFVDTHNBaHBjTlJUVlJF?= =?utf-8?B?eTN3NVdtL0pOQWY0Yjl2UFVNQ2l4WENxQ2s4c3VsNWswUUJuTDBEV25JMElX?= =?utf-8?B?UEsxME5iYkNqSW5ZSXJ5MFFxVVlrYnJEVG5sR3owcCt3ZG53V1p3TllrNmNC?= =?utf-8?B?RlFKbUxjc1lWeWpMdCtYbmtKRW9sUHhENnV0cm9LZ2JpQnNKbGhYdEJ6ZVlw?= =?utf-8?B?azh2akx1YXpnU29Wb1VBRk8zSk5UeDdweTJFTC9mbkRHUS80Ukkyb082RUhu?= =?utf-8?Q?fKFLy/75+W/7bmHpEHlciwD9EofoLaa/rVaP2wVwBo=3D?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3965ef1b-b047-4608-49d6-08d9fdb8b25a X-MS-Exchange-CrossTenant-AuthSource: DB9P251MB0618.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 08:26:35.9425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3jENZhZSFb9XpGjNqKJaIhkzdx9hcGGCVBOElmi0nwRPr5xK+drcrQwVTMS9wtilcpzxqkUiBFiD8EDKHvaBBggwtPwX/TcIZ1li1gAls3Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P251MB0430 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] Patch series for package per project? X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 3/4/22 9:10 AM, Michael Olbrich wrote: > Hi, > > On Thu, Mar 03, 2022 at 09:35:36PM +0100, Alexander Dahl wrote: >> On Thu, Mar 03, 2022 at 09:11:39PM +0100, Alexander Dahl wrote: >>> On Thu, Mar 03, 2022 at 08:37:45PM +0100, Christian Melki wrote: >>>> On 3/3/22 18:07, Felix Mellmann wrote: >>>>> On 03.03.22 15:22, Christian Melki wrote: >>>>>> Just one barebox version, but for different archs, with different >>>>>> patchsets. I'd like the patches to live in the same place as they've >>>>>> always done, i.e. under patches/package/... >>>>>> But patches/package/series.$platform or similar does not seem to work? >>>>>> >>>>> Would it be an option to put the patches below each of the platformdirs? >>>>> >>>>> I ran into a similiar situation when starting to migrate to a different >>>>> CPU platform. After a couple of years putting serveral "platformconfig" >>>>> files within the same directory as "ptxconfig" I'm now using separate >>>>> subdirs for each platform where separate sets of platform dependent >>>>> patches are lying. > > That would be my first suggestion as well. > >>>> Ideally not. It irks me a bit that patches have to go to a different >>>> place because they belong to another platform than the "default". Or >>>> that they have to go somewhere else altogether because they need to be >>>> split into platforms. >>>> It doesn't make much sense to me. > > I guess that's a matter of perspective. For me, either the patch stack is > shared. Then I out it in the common directory. Or each platform has a > completely separate patch stack. Then it feels natural to have them in > separate locations in each platform. > It is a matter of perspective and taste. I prefer patches not scattered everywhere. Ideally a structure at one point in a tree. I don't like chasing: "Where did this come from? Oh. Someone placed something somewhere else too.", as in other unnamed environments. >>> If I understand you correctly, your folder patches/barebox-2022.03.0 >>> (or whatever common version you use) must look like this somehow, all >>> patches of the different series interleaved? >>> >>> 0001-apples.patch >>> 0001-foo.patch >>> 0001-this.patch >>> 0002-bar.patch >>> 0002-oranges.patch >>> 0002-that.patch >>> 0003-baz.patch >>> series.one >>> series.three >>> series.two >> >> Now, what if those series are not mutually exclusive, but certain >> patches are part of multiple series? Even worse: in different places, >> like first patch in one, and third patch in the other series? Each >> call of `git ptx-patches` would change the file numbers in the file >> names, breaking the other series? > > Exactly. Maintaining shared patches is a mess. When I have more patches and > especially if they are shared, then I work with a clone of the package > upstream git. I use 'ptxdist local-src' for development and then export a > full patch stack into the BSP. > If the patch stacks for multiple platforms share some patches then they are > in a shared branch in git, but in the BSP each platform has its own copy. > > >>> Seriously, that looks messy to me, how should anyone looking at the >>> directory know which patch belongs to which series without looking at >>> the series files? What if someone wants to copy/move all patches >>> belonging to only one series to a different place? >> Preferably not dumped like that no. If I could, a directory structure would be nice. >> What I would do, and in fact I did this with patches for U-Boot for >> five different boards: throw all patches into one series. Why >> separate them? Or if that's not possible, put distinct patch series >> configs/platform-XXX/patches/barebox-2022.03.0 as suggested before. > > I personally don't like having unrelated and unnecessary patches in my > patchstack... > >> Well, there's one more possibility: put the patch series to different >> top layers. ;-) > > You could also put something like this in platforms/barebox-series.in: > > config BAREBOX_SERIES > string > default "series${PTXDIST_PLATFORMSUFFIX}" > > This will be used automatically and you have a series for each platform. > Or add a prompt and explicitly set the series filename. > Sure. I could copy the kernel handling. But I'd prefer if that also could go away for a more generic handling. Ie, kernel has this. If I give barebox this, it would be just cluttering. Regards, Christian > Michael > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de