Re: [ptxdist] [PATCH] libptxdist: explicitly use sed to run migrate_*

["Andreas Bießmann" <andreas@biessmann.de>]

Dear Michael,

On Fri, 14 Oct 2011 16:04:34 +0200, Michael Olbrich wrote:
> Hi,
>
> On Tue, Oct 11, 2011 at 12:16:09PM +0200, andreas@biessmann.de wrote:
>> On Mon, 10 Oct 2011 18:04:56 +0200, Michael Olbrich wrote:

<snip>

> I've been thinking about this for some time. I don't like 
> preprocessing a
> lot of files, because that makes developing ptxdist a pain. What I've
> considered, but not implemented (no time so far) is the following:
>
> create scripts/ptxdist_tools.sh.in that is preprocessed with autoconf 
> the
> stuff like this:
> [...]
> export PTXDIST_PYTHON="@PYTHON@"
> export PTXDIST_SED="@SED@"
> [...]
>
> I think it should be sourced right before scripts/ptxdist_vars.sh.
> Then use "${PTXDIST_PYTHON}", "${PTXDIST_SED}" everywhere. This way 
> we get
> the tools detected by configure without preprocessing a lot of files. 
> Do
> you think this can handle all the Problems you have?

Yes it will ...

> However, making sure everything is using the correct tools will not 
> be
> easy. Replacing the calls in ptxdist is easy, but there are many 
> packages
> that call these tools directly, so they must be patched.

But I also see your objections and therefore favour your second 
suggestion.

> So far I've not had the time to even start this, but I'd be happy to 
> apply
> such patches.
> I'll apply my patch for now. We can change 'sed' to '${PTXDIST_SED}' 
> again
> later.

That is ok for me, at least it will fix my problem with migration 
scripts.

> Hmmm, I just had another idea: How about fixing the environment in 
> ptxdist:
>
> mkdir <TMP_BIN>/
> ln -s @PYTHON@ <TMP_BIN>/python
> ln -s @SED@ <TMP_BIN>/sed
> [...]
> export PATH=<TMP_BIN>:$PATH
> [...]
>
> just do this as early as possible in ptxdist and PATH will provide 
> the
> correct tools. Do you think that could work?

Yes I think so. It should be done while installing the 
scripts/rules/a.s.o and 'export PATH=<TMP_BIN>:$PATH' should be added to 
ptxdist_vars.sh.
So how about naming <TMP_BIN> $PTXDIST_BIN and placing it at 
${PTXDIST_TOPDIR}/bin? If that is ok I will provide patches to get 
ptxdist working on OS X these days.

>> There is one other point for me that would prefer the a) solution.
>> We (sh|c)ould use
>> more of the autotools foo to have a cleaner install directory (e.g.
>> why installing all
>> the files necessary to build the kconfig tools?).
>
> Because it's easier and doesn't hurt? :-) Send patches...

Will do.

best regards

Andreas Bießmann


-- 
ptxdist mailing list
ptxdist@pengutronix.de