mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/3] host-ua-nodeset: New package.
Date: Tue, 28 Jan 2020 16:36:52 +0100	[thread overview]
Message-ID: <6r36bzbnjf.fsf@pengutronix.de> (raw)
In-Reply-To: <20200114092401.gxff3cv6mlcw7l2r@pengutronix.de>

On Tue, Jan 14 2020 at 10:24 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> On Mon, Jan 13, 2020 at 02:35:55PM +0100, Björn Esser wrote:
>> The OPC Foundation UA Nodeset.  Needed to build open62541.
>>
>> Signed-off-by: Björn Esser <b.esser@pengutronix.de>
>> ---
>>  rules/host-ua-nodeset.in   |  6 ++++++
>>  rules/host-ua-nodeset.make | 44 ++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 50 insertions(+)
>>  create mode 100644 rules/host-ua-nodeset.in
>>  create mode 100644 rules/host-ua-nodeset.make
>>
>> diff --git a/rules/host-ua-nodeset.in b/rules/host-ua-nodeset.in
>> new file mode 100644
>> index 000000000..c582ec934
>> --- /dev/null
>> +++ b/rules/host-ua-nodeset.in
>> @@ -0,0 +1,6 @@
>> +## SECTION=hosttools_noprompt
>> +
>> +config HOST_UA_NODESET
>> +	tristate
>> +	help
>> +	  OPC UA NodeSets
>
> Hm, that's not a very helpful help text... but I guess for
> hosttools_noprompt this doesn't matter.

Hi Roland,

I took over from Björn Esser and just sent a v2 with a somewhat more
thorough commit message and Kconfig option's help text.

Best regards
Ulrich


>  - Roland
>
>> diff --git a/rules/host-ua-nodeset.make b/rules/host-ua-nodeset.make
>> new file mode 100644
>> index 000000000..0b846f31d
>> --- /dev/null
>> +++ b/rules/host-ua-nodeset.make
>> @@ -0,0 +1,44 @@
>> +# -*-makefile-*-
>> +#
>> +# Copyright (C) 2019 by Bjoern Esser <bes@pengutronix.de>
>> +#
>> +# For further information about the PTXdist project and license conditions
>> +# see the README file.
>> +#
>> +
>> +#
>> +# We provide this package
>> +#
>> +HOST_PACKAGES-$(PTXCONF_HOST_UA_NODESET) += host-ua-nodeset
>> +
>> +#
>> +# Paths and names
>> +#
>> +HOST_UA_NODESET_VERSION	:= 1.04.4-2020-01-08
>> +HOST_UA_NODESET_MD5	:= ce7b39c7f2d65617f76e0301f654a9ea
>> +HOST_UA_NODESET		:= ua-nodeset-$(HOST_UA_NODESET_VERSION)
>> +HOST_UA_NODESET_SUFFIX	:= tar.gz
>> +HOST_UA_NODESET_URL	:= https://github.com/OPCFoundation/UA-Nodeset/archive/UA-$(HOST_UA_NODESET_VERSION)/$(HOST_UA_NODESET).$(HOST_UA_NODESET_SUFFIX)
>> +HOST_UA_NODESET_SOURCE	:= $(SRCDIR)/$(HOST_UA_NODESET).$(HOST_UA_NODESET_SUFFIX)
>> +HOST_UA_NODESET_DIR	:= $(HOST_BUILDDIR)/$(HOST_UA_NODESET)
>> +
>> +# ----------------------------------------------------------------------------
>> +# Compile
>> +# ----------------------------------------------------------------------------
>> +
>> +$(STATEDIR)/host-ua-nodeset.compile:
>> +	@$(call targetinfo)
>> +	@$(call touch)
>> +
>> +# ----------------------------------------------------------------------------
>> +# Install
>> +# ----------------------------------------------------------------------------
>> +
>> +$(STATEDIR)/host-ua-nodeset.install:
>> +	@$(call targetinfo)
>> +
>> +	@mkdir -p $(HOST_UA_NODESET_PKGDIR)/usr/share/ua-nodeset
>> +	@cp -a $(HOST_BUILDDIR)/$(HOST_UA_NODESET)/* \
>> +		$(HOST_UA_NODESET_PKGDIR)/usr/share/ua-nodeset
>> +
>> +	@$(call touch)
>> --
>> 2.25.0.rc1
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2020-01-28 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 13:35 [ptxdist] [PATCH 1/3] mbedtls: " Björn Esser
2020-01-13 13:35 ` [ptxdist] [PATCH 2/3] host-ua-nodeset: " Björn Esser
2020-01-14  9:24   ` Roland Hieber
2020-01-28 15:36     ` Ulrich Ölmann [this message]
2020-01-13 13:35 ` [ptxdist] [PATCH 3/3] open62541: " Björn Esser
2020-01-14  9:56   ` Alexander Dahl
2020-01-14 11:16     ` Ulrich Ölmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6r36bzbnjf.fsf@pengutronix.de \
    --to=u.oelmann@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox