mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v5 3/3] open62541: new package
Date: Wed, 11 Mar 2020 16:40:23 +0100	[thread overview]
Message-ID: <6r1rpyq4rc.fsf@pengutronix.de> (raw)
In-Reply-To: <20200214125023.GG7958@pengutronix.de>

On Fri, Feb 14 2020 at 13:50 +0100, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> On Wed, Feb 05, 2020 at 11:42:41AM +0100, Ulrich Ölmann wrote:
>> From: Björn Esser <b.esser@pengutronix.de>
>> 
>> The open62541 project is an open source implementation of the OPC UA
>> communication infrastructure which is used in industrial control.
>> 
>> Signed-off-by: Björn Esser <b.esser@pengutronix.de>
>> [uol: adjusted commit message]
>> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
>> ---
>> v2 --> v3: adjusted commit message
>> 
>> [...]
>> 
>> diff --git a/rules/open62541.make b/rules/open62541.make
>> new file mode 100644
>> index 000000000000..62e030ed3752
>> --- /dev/null
>> +++ b/rules/open62541.make
>> @@ -0,0 +1,140 @@
>> +# -*-makefile-*-
>> +#
>> +# Copyright (C) 2018 by Robert Schwebel <r.schwebel@pengutronix.de>
>> +# Copyright (C) 2019 by Bjoern Esser <b.esser@pengutronix.de>
>> +#
>> +# See CREDITS for details about who has contributed to this project.
>> +#
>> +# For further information about the PTXdist project and license conditions
>> +# see the README file.
>> +#
>> +
>> +#
>> +# We provide this package
>> +#
>> +PACKAGES-$(PTXCONF_OPEN62541) += open62541
>> +
>> +#
>> +# Paths and names
>> +#
>> +OPEN62541_VERSION		:= 1.0
>> +OPEN62541_MD5			:= b8e02d7310e8b48faf52efc539fa9496
>> +OPEN62541			:= open62541-$(OPEN62541_VERSION)
>> +OPEN62541_SUFFIX		:= tar.gz
>> +OPEN62541_URL			:= https://github.com/open62541/open62541/archive/v$(OPEN62541_VERSION)/$(OPEN62541).$(OPEN62541_SUFFIX)
>> +OPEN62541_SOURCE		:= $(SRCDIR)/$(OPEN62541).$(OPEN62541_SUFFIX)
>> +OPEN62541_DIR			:= $(BUILDDIR)/$(OPEN62541)
>> +OPEN62541_LICENSE		:= MPL-2.0
>> +OPEN62541_LICENSE_FILES		:= file://LICENSE;md5=815ca599c9df247a0c7f619bab123dad
>> +
>> +OPEN62541_MDNSD_VERSION		:= 4bd993e0fdd06d54c8fd0b8f416cda6a8db18585
>> +OPEN62541_MDNSD_MD5		:= 0961fc8dc253753ec8ea157104671498
>> +OPEN62541_MDNSD_URL		:= https://github.com/Pro/mdnsd/archive/$(OPEN62541_MDNSD_VERSION)/open62541-mdnsd-$(OPEN62541_MDNSD_VERSION).tar.gz
>> +OPEN62541_MDNSD_SOURCE		:= $(SRCDIR)/open62541-mdnsd-$(OPEN62541_MDNSD_VERSION).tar.gz
>
> The suffix deserves a separate variable.

Okay.

>> +$(OPEN62541_MDNSD_SOURCE)	:= OPEN62541_MDNSD
>> +OPEN62541_MDNSD_DIR		:= $(OPEN62541_DIR)/deps/mdnsd
>> +OPEN62541_MDNSD_LICENSE		:= BSD-3-Clause
>> +OPEN62541_MDNSD_LICENSE_FILES	:= file://LICENSE;md5=3bb4047dc4095cd7336de3e2a9be94f0
>> +
>> +# open62541-mdnsd needs the source dir.
>> +OPEN62541_DEVPKG		:= NO
>
> Right now open62541-mdnsd is part of the same package, so the comment
> makes no sense.

Removed in the next iteration of the series.

Best regards
Ulrich
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  parent reply	other threads:[~2020-03-11 15:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 10:42 [ptxdist] [PATCH v5 1/3] mbedtls: " Ulrich Ölmann
2020-02-05 10:42 ` [ptxdist] [PATCH v5 2/3] host-ua-nodeset: " Ulrich Ölmann
2020-02-05 10:42 ` [ptxdist] [PATCH v5 3/3] open62541: " Ulrich Ölmann
2020-02-14 12:50   ` Michael Olbrich
2020-02-17  9:50     ` Roland Hieber
2020-02-17 10:32       ` Michael Olbrich
2020-03-11 15:42         ` Ulrich Ölmann
2020-03-11 15:40     ` Ulrich Ölmann [this message]
2020-02-15  9:58   ` Michael Olbrich
2020-03-11 15:38     ` Ulrich Ölmann
2020-02-17  9:39 ` [ptxdist] [PATCH v5 1/3] mbedtls: " Michael Olbrich
2020-03-11 15:36   ` Ulrich Ölmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6r1rpyq4rc.fsf@pengutronix.de \
    --to=u.oelmann@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox