From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 20 Oct 2023 13:11:52 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtnQ1-00FSpH-AP for lore@lore.pengutronix.de; Fri, 20 Oct 2023 13:11:52 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qtnQ0-0007kH-8t; Fri, 20 Oct 2023 13:11:52 +0200 Received: from mail.ela-soft.com ([213.23.49.162]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtnPc-0007ji-0e; Fri, 20 Oct 2023 13:11:32 +0200 Received: from [192.168.220.154] (169-109-142-46.pool.kielnet.net [46.142.109.169]) by mail.ela-soft.com (mailsystem) with ESMTPSA id E602B9CE3; Fri, 20 Oct 2023 13:11:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ela-soft.com; s=2021; t=1697800286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aoH45k3m0hARLbqTb5a+W7wIwkLgn6yn39of3ZCtEtI=; b=f4D+R6sZ5qq4HNKpPBEU/NCXHcFLr+yeh11dwY5D22aWf0w67KTXwlqqSdxYkIWhZzuFAV WddQdfBtiulBXGPrZFR5IRP5FSo0uBalIUZZQvigRxustp/OZt0mM6qmYwQ/TJKelbsMck YbHLj9pLzM6Y2euLDVht+eD4JkQ1u0ASIi2joto/XnFFxII1huOiXCoq9/NiI8lZtlDVfc wtZkQh35UqlMd2zMWkTMxOdt/gK5/oyT150Hbs4LGdSbaMfyltvKt2KkP7NhJc5KVmlQ+G uIOiHw7i4CiAKTl3mnSr/q4kCJBhfpz30n6ompmI4n93Tz1REBYrawyAvlCxwA== Message-ID: <6d7aea5e-2860-4593-a0ac-e3e2c1ad9485@ela-soft.com> Date: Fri, 20 Oct 2023 13:11:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-DE To: Michael Olbrich References: <20231018160014.197898-1-ahelmcke@ela-soft.com> <20231019-clumsily-praying-d840b025f2a6@ifak-system.com> <20231019-unvalued-outtakes-1ee75b22f0b8@ifak-system.com> From: Andreas Helmcke Autocrypt: addr=ahelmcke@ela-soft.com; keydata= xsDiBDqtzDQRBADYJNLjNC+RK93Lhqx89UudxF0GIBfb+7AzjKRMe1aWRB5o3a14vm7ScQh+ xFIw8j2jaxM1jNZ/6eZw3nT8vy/3gRVazBnJg/JXKxU0axpvCwioodS8UKy82Wp89Gya+yhF IH10Q/2Rp2Y33oxbmwAl/YSS8eqN2oPjCrnCbEWcQQCg/w2d6Pwilu2ajlxtNby1lXOs7R0E AIveEzbSpi5hFsUgRz3MEnvBxTYvP3F0yU8x/LPl08FTa+0kNb+8FVqPxNPenBAtX0mRPLLA BRknO9xEQ8Zi1bnQ3/1Gcj1W+92XIClMkFJWTxPn5lmHOLsH1K/FaWEDS9z1+usxgPVDUVxT MbPSxhXxJU7S9tC02noI0rB1/0WLBACGNP3II9pZ5cZJP7ZBje/LtZCMK+anx6Ix9DHBpedL kkPYFBwSCEB9AciFtPa0IVkuvynqnyeiyfdwQK7ul9nMowjSWarnmWcdQkByfMNzEdVQF1oy IV+FJCx3bPYc6Bxb8mRmwEK7s6i8Y3qdgFwyyphGTWkMcFtvTr/Tknf3L80nQW5kcmVhcyBI ZWxtY2tlIDxhaGVsbWNrZUBlbGEtc29mdC5jb20+wn0EExEIAD0CGwMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgBYhBFA9ZZ0xTAe07lSeJg1WleJJOvBfBQJiuyA3BQkrwowDAAoJEA1WleJJ OvBfdCgAoNRkGKBA2rMuyYhUv99ZxZMvqyd7AJ9PeDsEDdRcbUtuXHVy9G1O8Daz687BTQQ6 rcw0EAgA9kJXtwh/CBdyorrWqULzBej5UxE5T7bxbrlLOCDaAadWoxTpj0BV89AHxstDqZSt 90xkhkn4DIO9ZekX1KHTUPj1WV/cdlJPPT2N286Z4VeSWc39uK50T8X8dryDxUcwYc58yWb/ Ffm7/ZFexwGq01uejaClcjrUGvC/RgBYK+X0iP1YTknbzSC0neSRBzZrM2w4DUUdD3yIsxx8 Wy2O9vPJI8BD8KVbGI2Ou1WMuF040zT9fBdXQ6MdGGzeMyEstSr/POGxKUAYEY18hKcKctaG xAMZyAcpesqVDNmWn6vQClCbAkbTCD1mpF1Bn5x8vYlLIhkmuquiXsNV6TILOwACAggAwYsD zwilCtMj1WbBxKHhjyLf57L0AJsHx1SB8gixbvSS9Z1lvWri7UXwljvI747af56DgwxWs+/p c/voH/xkVHdgSEf4AuUc2lWQcoFmNHo8QJKN4An1j1H7DvJXKyffRLHj7YsgQ7NPs8/FsPm9 69oHX61xuzRiY7ndi34DduMjChFvoWV/ddQjitjvekP5gCm64TGQg23mUMGixuTWXAgUmgN0 fHPieqYXqVvEgwChgm1iZQJDSQ0sYRfOqfMK4vvwQCp6aSlRPrd06EKaOvxCL8HWUWX7tPzt n3BwxNU8uWqXFejPTymRry3WsoABRgpBvAhO8+ByoRA1ZV9EK8JpBBgRCAApBRsMAAAAFiEE UD1lnTFMB7TuVJ4mDVaV4kk68F8FAmK7IDgFCSvCjAMACgkQDVaV4kk68F971QCfdAx/iSSd dAtyCVc29GEW8zOnNikAnRd3L/RtOOHEcA01APdZ9+uQrKUM In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-102.1 required=4.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v3] lighttpd: Version bump, 1.4.67 -> 1.4.72 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Am 20.10.23 um 09:54 schrieb Michael Olbrich: > On Thu, Oct 19, 2023 at 01:11:51PM +0200, Andreas Helmcke wrote: >> Am 19.10.23 um 11:16 schrieb Alexander Dahl: >>> got it sorted out, although the experience in #lighttpd IRC channel >>> was not as friendly as I hoped for. See below. >>> >>> Am Thu, Oct 19, 2023 at 10:33:47AM +0200 schrieb Alexander Dahl: >>>> sorry to bother you again. :-/ >>>> >>>> I just tested v3 of your patch on my target. See below. >>>> >>>> Am Wed, Oct 18, 2023 at 06:00:14PM +0200 schrieb Andreas Helmcke: >>>>> Bugfixes and several changes. e.g. >>>>> - Stronger TLS defaults >>>>> - HTTP/2 Support now as optional module >>>>> - Some former modules are now build in >>>>> >>>>> Link: https://www.lighttpd.net/2023/1/3/1.4.68/ >>>>> Link: https://www.lighttpd.net/2023/2/10/1.4.69/ >>>>> Link: https://www.lighttpd.net/2023/5/10/1.4.70/ >>>>> Link: https://www.lighttpd.net/2023/5/27/1.4.71/ >>>>> Link: https://www.lighttpd.net/2023/10/6/1.4.72/ >>>>> Signed-off-by: Andreas Helmcke >>>>> --- >>>>> rules/lighttpd.in | 35 +++++++++++------------------------ >>>>> rules/lighttpd.make | 15 +++++---------- >>>>> 2 files changed, 16 insertions(+), 34 deletions(-) >>>>> >>>>> diff --git a/rules/lighttpd.in b/rules/lighttpd.in >>>>> index 910271087..670a00d15 100644 >>>>> --- a/rules/lighttpd.in >>>>> +++ b/rules/lighttpd.in >>>>> @@ -69,13 +69,6 @@ endmenu >>>>> >>>>> menu "modules " >>>>> >>>>> -config LIGHTTPD_MOD_ACCESS >>>>> - bool >>>>> - prompt "mod_access" >>>>> - default y >>>>> - help >>>>> - Deny access to some files. >>>>> - >>>>> config LIGHTTPD_MOD_ACCESSLOG >>>>> bool >>>>> prompt "mod_accesslog" >>>>> @@ -83,12 +76,6 @@ config LIGHTTPD_MOD_ACCESSLOG >>>>> help >>>>> flexible logging of requests served >>>>> >>>>> -config LIGHTTPD_MOD_ALIAS >>>>> - bool >>>>> - prompt "mod_alias" >>>>> - help >>>>> - Specify a special document-root for a given url-subset. >>>>> - >>>>> config LIGHTTPD_MOD_AUTH >>>>> bool >>>>> prompt "mod_auth" >>>>> @@ -123,11 +110,12 @@ config LIGHTTPD_BZ2LIB >>>>> Enable bzip2 support for mod_deflate. >>>>> endif >>>>> >>>>> -config LIGHTTPD_MOD_FASTCGI >>>>> +config LIGHTTPD_MOD_DIRLISTING >>>>> bool >>>>> - prompt "mod_fastcgi" >>>>> - >>>>> -if LIGHTTPD_MOD_FASTCGI >>>>> + prompt "mod_dirlisting" >>>>> + default y >>>>> + help >>>>> + Creates an HTML page listing the contents of the target directory. >>>>> >>>>> config LIGHTTPD_MOD_FASTCGI_PHP >>>>> bool >>>>> @@ -140,7 +128,12 @@ config LIGHTTPD_MOD_FASTCGI_PHP >>>>> comment "PHP CGI SAPI must be enabled" >>>>> depends on !PHP8_SAPI_CGI >>>>> >>>>> -endif >>>>> +config LIGHTTPD_MOD_H2 >>>>> + bool >>>>> + prompt "mod_h2" >>>>> + default y >>>>> + help >>>>> + HTTP/2 support >>>> >>>> I fear we can not make this an option (yet). >>> >>> If you do not load 'mod_h2', you need an additional setting in >>> lighttpd.conf to make lighttpd happy. Maybe we could add that in the >>> help text? Or in the commit message? It is this one: >>> >>> server.feature-flags += ( "server.h2proto" => "disable" ) >>> >> >> Maybe like this? >> >> help >> HTTP/2 support >> To use lighttpd without HTTP/2 you need to disable it in the configuration file: >> server.feature-flags += ( "server.h2proto" => "disable" ) >> > [...] >>>>> +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_H2) += mod_h2 >>>> >>>> We probably need to always install mod_h2. I turned the option off >>>> and now I get this at runtime >>>> (`lighttpd -tt -f /etc/lighttpd/lighttpd.conf`): >>>> >>>> 2012-01-01 00:46:15: (plugin.c.209) dlopen() failed for: /usr/lib/lighttpd/mod_h2.so /usr/lib/lighttpd/mod_h2.so: cannot open shared object file: No such file or directory >>> >>> You get this message if you don't have "mod_h2" in server.modules in >>> lighttpd.conf. You need to set the line from above. There's a >>> default configuration file 'projectroot/etc/lighttpd/lighttpd.conf' in >>> ptxdist. Maybe with some magic like this: >>> >>> server.feature-flags += ( "server.h2proto" => "@H2ENDIS@" ) >>> >>> And then replacing the placeholder with either 'enable' or 'disable'? I go with this magic: @NOH2@server.feature-flags += ( "server.h2proto" => "disable" ) replacing @NOH2@ with either "" or "#" This way it would be clear, that the default is to use HTTP/2 and the line could be omitted if HTTP/2 is used. >> This only helps if you also use the default configuration. >> I would therefore leave it at the help text. > > Please add both. The default config should work without manual > modifications. Ok. Andreas