From: Philipp Zabel <p.zabel@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] mesalib: version bump 24.3.4 -> 25.0.1
Date: Fri, 07 Mar 2025 13:34:05 +0100 [thread overview]
Message-ID: <69872e40ed124b1bd0c7613aff50357d37e85e27.camel@pengutronix.de> (raw)
In-Reply-To: <Z8rgHBfJfdWH9B9H@pengutronix.de>
On Fr, 2025-03-07 at 13:01 +0100, Michael Olbrich wrote:
> > @@ -128,6 +128,9 @@ MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_PANFROST) += panfrost
> > endif
> > MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_SWRAST) += swrast
> > MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_VIRTIO) += virtio
> > +MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_NOUVEAU) += nouveau
> > +MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_ASAHI) += asahi
>
> That one is only available on ARM64 hardware right? So maybe restrict it to
> that.
Wrapped in ifdef PTXCONF_ARCH_ARM64 in v2, it's currently disabled
anyway due to a missing dependency on target LIBCLC by way of
MESALIB_DRI_ASAHI.
> > +MESALIB_VULKAN_DRIVERS-$(PTXCONF_MESALIB_VULKAN_GFXSTREAM) += gfxstream
>
> Fails to build on ARMv7 with:
>
> ../mesa-25.0.1/src/gfxstream/guest/vulkan_enc/ResourceTracker.cpp:4905:23: error: format '%p' expects argument of type 'void*', but argument 4 has type 'VkFence' {aka 'long long unsigned int'} [-Werror=format=]
>
> We should probably only build it for 64-bit architectures
> (PTXCONF_ARCH_LP64). I don't see it beeing used anywhere else anyways.
Wrapped in ifdef PTXCONF_ARCH_LP64 in v2.
regards
Philipp
prev parent reply other threads:[~2025-03-07 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 10:00 Philipp Zabel
2025-03-07 12:01 ` Michael Olbrich
2025-03-07 12:34 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69872e40ed124b1bd0c7613aff50357d37e85e27.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox